From 500f38182799cc976020f3d461a00817b1ce3533 Mon Sep 17 00:00:00 2001 From: Andrew Meadows Date: Tue, 14 Nov 2017 15:56:55 -0800 Subject: [PATCH] collect hard-coded time budgets in one spot --- libraries/entities-renderer/src/EntityTreeRenderer.cpp | 2 -- libraries/shared/src/PrioritySortUtil.h | 4 ++++ 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/libraries/entities-renderer/src/EntityTreeRenderer.cpp b/libraries/entities-renderer/src/EntityTreeRenderer.cpp index 9e4bfe22c8..13e5973e27 100644 --- a/libraries/entities-renderer/src/EntityTreeRenderer.cpp +++ b/libraries/entities-renderer/src/EntityTreeRenderer.cpp @@ -318,7 +318,6 @@ void EntityTreeRenderer::updateChangedEntities(const render::ScenePointer& scene } float expectedUpdateCost = _avgRenderableUpdateCost * _renderablesToUpdate.size(); - const float MAX_UPDATE_RENDERABLES_TIME_BUDGET = 2 * USECS_PER_MSEC; if (expectedUpdateCost < MAX_UPDATE_RENDERABLES_TIME_BUDGET) { // we expect to update all renderables within available time budget PROFILE_RANGE_EX(simulation_physics, "UpdateRenderables", 0xffff00ff, (uint64_t)_renderablesToUpdate.size()); @@ -367,7 +366,6 @@ void EntityTreeRenderer::updateChangedEntities(const render::ScenePointer& scene // compute remaining time budget uint64_t updateStart = usecTimestampNow(); - const uint64_t MIN_SORTED_UPDATE_RENDERABLES_TIME_BUDGET = 1 * USECS_PER_MSEC; uint64_t timeBudget = MIN_SORTED_UPDATE_RENDERABLES_TIME_BUDGET; uint64_t sortCost = updateStart - sortStart; if (sortCost < MAX_UPDATE_RENDERABLES_TIME_BUDGET - MIN_SORTED_UPDATE_RENDERABLES_TIME_BUDGET) { diff --git a/libraries/shared/src/PrioritySortUtil.h b/libraries/shared/src/PrioritySortUtil.h index 6f4897c7b4..1d11a04265 100644 --- a/libraries/shared/src/PrioritySortUtil.h +++ b/libraries/shared/src/PrioritySortUtil.h @@ -133,5 +133,9 @@ namespace PrioritySortUtil { }; } // namespace PrioritySortUtil +// for now we're keeping hard-coded sorted time budgets in one spot +const uint64_t MAX_UPDATE_RENDERABLES_TIME_BUDGET = 2000; // usec +const uint64_t MIN_SORTED_UPDATE_RENDERABLES_TIME_BUDGET = 1000; // usec + #endif // hifi_PrioritySortUtil_h