From 4e9b8c1ef94e7e1384f2fc0e697708f72d229855 Mon Sep 17 00:00:00 2001 From: "Anthony J. Thibault" Date: Thu, 6 Jul 2017 11:01:59 -0700 Subject: [PATCH] updated comments --- plugins/openvr/src/ViveControllerManager.cpp | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/plugins/openvr/src/ViveControllerManager.cpp b/plugins/openvr/src/ViveControllerManager.cpp index a531dfad4c..e505051536 100644 --- a/plugins/openvr/src/ViveControllerManager.cpp +++ b/plugins/openvr/src/ViveControllerManager.cpp @@ -713,10 +713,10 @@ void ViveControllerManager::InputDevice::handleHandController(float deltaTime, u } // defaultToReferenceMat is an offset from avatar space to sensor space. -// it aligns the default head in avatar space with the hmd in sensor space. +// it aligns the default center-eye in avatar space with the hmd in sensor space. // -// * E_a is the the default center-eye transform in avatar space. -// * E_s is the the hmd center-eye transform in sensor space, with roll and pitch removed. +// * E_a is the the default center-of-the-eyes transform in avatar space. +// * E_s is the the hmd eye-center transform in sensor space, with roll and pitch removed. // * D is the defaultReferenceMat. // // E_s = D * E_a => @@ -739,7 +739,9 @@ glm::mat4 ViveControllerManager::InputDevice::calculateDefaultToReferenceForHmd( } // defaultToReferenceMat is an offset from avatar space to sensor space. -// it aligns the default head in avatar space with the head-puck in sensor space. +// it aligns the default center-of-the-eyes transform in avatar space with the head-puck in sensor space. +// The offset from the center-of-the-eyes to the head-puck can be configured via _headPuckYOffset and _headPuckZOffset, +// these values are exposed in the configuration UI. // // * E_a is the the default center-eye transform in avatar space. // * E_s is the the head-puck center-eye transform in sensor space, with roll and pitch removed.