From 4d4a68d706e1ea760f7f5cfd03e30019fd512505 Mon Sep 17 00:00:00 2001 From: Zach Pomerantz Date: Wed, 31 Aug 2016 14:44:45 -0700 Subject: [PATCH] add FIXME about loudness in AudioRingBuffer --- libraries/audio/src/AudioRingBuffer.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/libraries/audio/src/AudioRingBuffer.cpp b/libraries/audio/src/AudioRingBuffer.cpp index b088e94871..260c682cde 100644 --- a/libraries/audio/src/AudioRingBuffer.cpp +++ b/libraries/audio/src/AudioRingBuffer.cpp @@ -187,6 +187,7 @@ int16_t* AudioRingBuffer::shiftedPositionAccomodatingWrap(int16_t* position, int } float AudioRingBuffer::getFrameLoudness(const int16_t* frameStart) const { + // FIXME: This is a bad measure of loudness - normal estimation uses sqrt(sum(x*x)) float loudness = 0.0f; const int16_t* sampleAt = frameStart; const int16_t* bufferLastAt = _buffer + _bufferLength - 1;