Mirrors/overte
3
0
Fork 0
mirror of https://github.com/overte-org/overte.git synced 2025-08-10 08:48:53 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

Tweaking packet processing locking

Browse source
This commit is contained in:
Brad Davis 2015-07-01 14:53:08 -07:00
parent d4d6f8f5d5
commit 4c200d75bc
2 changed files with 8 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
libraries/networking/src/ReceivedPacketProcessor.cpp
View file

@ -23,7 +23,7 @@ void ReceivedPacketProcessor::queueReceivedPacket(const SharedNodePointer& sendi
NetworkPacket networkPacket(sendingNode, packet); NetworkPacket networkPacket(sendingNode, packet);
lock(); lock();
_packets.push_back(networkPacket); _queuedPackets.push_back(networkPacket);
_nodePacketCounts[sendingNode->getUUID()]++; _nodePacketCounts[sendingNode->getUUID()]++;
unlock(); unlock();
@ -33,29 +33,28 @@ void ReceivedPacketProcessor::queueReceivedPacket(const SharedNodePointer& sendi
bool ReceivedPacketProcessor::process() { bool ReceivedPacketProcessor::process() {
if (_packets.size() == 0) { if (_queuedPackets.size() == 0) {
_waitingOnPacketsMutex.lock(); _waitingOnPacketsMutex.lock();
_hasPackets.wait(&_waitingOnPacketsMutex, getMaxWait()); _hasPackets.wait(&_waitingOnPacketsMutex, getMaxWait());
_waitingOnPacketsMutex.unlock(); _waitingOnPacketsMutex.unlock();
} }
preProcess(); preProcess();
QVector<NetworkPacket> currentPackets; if (!_queuedPackets.size()) {
if (!_packets.size()) {
return isStillRunning(); return isStillRunning();
} }
lock(); lock();
std::swap(currentPackets, _packets); _processingPackets.swap(_queuedPackets);
unlock(); unlock();
foreach(auto& packet, currentPackets) { foreach(auto& packet, _processingPackets) {
processPacket(packet.getNode(), packet.getByteArray()); processPacket(packet.getNode(), packet.getByteArray());
midProcess(); midProcess();
} }
lock(); lock();
foreach(auto& packet, currentPackets) { foreach(auto& packet, _processingPackets) {
_nodePacketCounts[packet.getNode()->getUUID()]--; _nodePacketCounts[packet.getNode()->getUUID()]--;
} }
unlock(); unlock();

3
libraries/networking/src/ReceivedPacketProcessor.h
View file

@ -75,7 +75,8 @@ protected:
protected: protected:
QVector<NetworkPacket> _packets; QVector<NetworkPacket> _queuedPackets;
QVector<NetworkPacket> _processingPackets;
QHash<QUuid, int> _nodePacketCounts; QHash<QUuid, int> _nodePacketCounts;
QWaitCondition _hasPackets; QWaitCondition _hasPackets;