From 49f1ecb1bfe1c70a1a4f9c7e89804885c6c95dec Mon Sep 17 00:00:00 2001 From: sabrina-shanman Date: Fri, 9 Aug 2019 11:12:35 -0700 Subject: [PATCH] Fix new bugs in TabletLODTools.qml --- .../resources/qml/hifi/dialogs/TabletLODTools.qml | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/interface/resources/qml/hifi/dialogs/TabletLODTools.qml b/interface/resources/qml/hifi/dialogs/TabletLODTools.qml index e4d21e5aa9..ed0545e6ad 100644 --- a/interface/resources/qml/hifi/dialogs/TabletLODTools.qml +++ b/interface/resources/qml/hifi/dialogs/TabletLODTools.qml @@ -31,9 +31,10 @@ Rectangle { readonly property real defaultMaxVisibilityDistance: 400.0 readonly property real unitElementMaxExtent: Math.sqrt(3.0) * 0.5 - function lodAngleDegToVisibilityDistance(var lodAngleDeg) { - var lodAngleRadians = lodAngleDeg * Math.PI / 180.0; - return unitElementMaxExtent / tan(lodAngleRadians); + function visibilityDistanceToLODAngleDeg(visibilityDistance) { + var lodHalfAngle = Math.atan(unitElementMaxExtent / visibilityDistance); + var lodAngle = lodHalfAngle * 2.0; + return lodAngle * 180.0 / Math.PI; } Column { @@ -74,7 +75,7 @@ Rectangle { id: adjustCheckbox boxSize: 20 anchors.verticalCenter: parent.verticalCenter - onCheckedChanged: LODManager.setAutomaticLODAdjust(!checked); + onCheckedChanged: LODManager.setAutomaticLODAdjust(!adjustCheckbox.checked); } } @@ -95,7 +96,7 @@ Rectangle { value: defaultMaxVisibilityDistance tickmarksEnabled: false onValueChanged: { - LODManager.setLODAngleDeg(lodAngleDegToVisibilityDistance(value)); + LODManager.lodAngleDeg = visibilityDistanceToLODAngleDeg(slider.value); whatYouCanSeeLabel.text = LODManager.getLODFeedbackText() } }