From e1fb01e6ddf93b57a90caac92c2d366280456773 Mon Sep 17 00:00:00 2001 From: Leonardo Murillo Date: Tue, 16 Jun 2015 14:49:19 -0600 Subject: [PATCH 1/2] Fixing bug on platforms for which we don't release --- libraries/auto-updater/src/AutoUpdater.cpp | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/libraries/auto-updater/src/AutoUpdater.cpp b/libraries/auto-updater/src/AutoUpdater.cpp index 445cdaec7b..50d11a2af5 100644 --- a/libraries/auto-updater/src/AutoUpdater.cpp +++ b/libraries/auto-updater/src/AutoUpdater.cpp @@ -104,9 +104,13 @@ void AutoUpdater::parseLatestVersionData() { } void AutoUpdater::checkVersionAndNotify() { + if (QCoreApplication::applicationVersion() == "dev" || _builds.empty()) { + // No version checking is required in dev builds or when not builds + // data was found for the platform + return; + } int latestVersionAvailable = _builds.lastKey(); - if (QCoreApplication::applicationVersion() != "dev" && - QCoreApplication::applicationVersion().toInt() < latestVersionAvailable) { + if (QCoreApplication::applicationVersion().toInt() < latestVersionAvailable) { emit newVersionIsAvailable(); } } From 80ab2f31f44895200f5c05b35d3a7d1872c55fe7 Mon Sep 17 00:00:00 2001 From: Leonardo Murillo Date: Tue, 16 Jun 2015 14:49:55 -0600 Subject: [PATCH 2/2] typo --- libraries/auto-updater/src/AutoUpdater.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libraries/auto-updater/src/AutoUpdater.cpp b/libraries/auto-updater/src/AutoUpdater.cpp index 50d11a2af5..8c6aa5605d 100644 --- a/libraries/auto-updater/src/AutoUpdater.cpp +++ b/libraries/auto-updater/src/AutoUpdater.cpp @@ -105,7 +105,7 @@ void AutoUpdater::parseLatestVersionData() { void AutoUpdater::checkVersionAndNotify() { if (QCoreApplication::applicationVersion() == "dev" || _builds.empty()) { - // No version checking is required in dev builds or when not builds + // No version checking is required in dev builds or when no build // data was found for the platform return; }