diff --git a/interface/src/Menu.h b/interface/src/Menu.h index d17f82de9d..77d9a78ced 100644 --- a/interface/src/Menu.h +++ b/interface/src/Menu.h @@ -135,10 +135,6 @@ public: void setFieldOfView(float fieldOfView) { _fieldOfView = fieldOfView; bumpSettings(); } float getRealWorldFieldOfView() const { return _realWorldFieldOfView; } void setRealWorldFieldOfView(float realWorldFieldOfView) { _realWorldFieldOfView = realWorldFieldOfView; bumpSettings(); } - float getSixenseReticleMoveSpeed() const { return _sixenseReticleMoveSpeed; } - void setSixenseReticleMoveSpeed(float sixenseReticleMoveSpeed) { _sixenseReticleMoveSpeed = sixenseReticleMoveSpeed; bumpSettings(); } - bool getInvertSixenseButtons() const { return _invertSixenseButtons; } - void setInvertSixenseButtons(bool invertSixenseButtons) { _invertSixenseButtons = invertSixenseButtons; bumpSettings(); } QString getSnapshotsLocation() const; void setSnapshotsLocation(QString snapshotsLocation) { _snapshotsLocation = snapshotsLocation; bumpSettings(); } @@ -215,8 +211,7 @@ private: #if defined(Q_OS_MAC) || defined(Q_OS_WIN) SpeechRecognizer _speechRecognizer; #endif - float _sixenseReticleMoveSpeed = DEFAULT_SIXENSE_RETICLE_MOVE_SPEED; - bool _invertSixenseButtons = DEFAULT_INVERT_SIXENSE_MOUSE_BUTTONS; + bool _hasLoginDialogDisplayed = false; int _maxOctreePacketsPerSecond = DEFAULT_MAX_OCTREE_PPS; diff --git a/interface/src/devices/SixenseManager.cpp b/interface/src/devices/SixenseManager.cpp index 12aae818f7..f3131af590 100644 --- a/interface/src/devices/SixenseManager.cpp +++ b/interface/src/devices/SixenseManager.cpp @@ -301,7 +301,7 @@ const float RANGE_MULT = (MAX_PIXEL_RANGE_MULT - MIN_PIXEL_RANGE_MULT) * 0.01; //Returns a multiplier to be applied to the cursor range for the controllers float SixenseManager::getCursorPixelRangeMult() const { //scales (0,100) to (MINIMUM_PIXEL_RANGE_MULT, MAXIMUM_PIXEL_RANGE_MULT) - return Menu::getInstance()->getSixenseReticleMoveSpeed() * RANGE_MULT + MIN_PIXEL_RANGE_MULT; + return _reticleMoveSpeed * RANGE_MULT + MIN_PIXEL_RANGE_MULT; } #ifdef HAVE_SIXENSE @@ -459,7 +459,7 @@ void SixenseManager::emulateMouse(PalmData* palm, int index) { unsigned int deviceID = index == 0 ? CONTROLLER_0_EVENT : CONTROLLER_1_EVENT; - if (Menu::getInstance()->getInvertSixenseButtons()) { + if (_invertButtons) { bumperButton = Qt::LeftButton; triggerButton = Qt::RightButton; } else { diff --git a/interface/src/devices/SixenseManager.h b/interface/src/devices/SixenseManager.h index 4082edd153..427faab970 100644 --- a/interface/src/devices/SixenseManager.h +++ b/interface/src/devices/SixenseManager.h @@ -55,6 +55,11 @@ public: void update(float deltaTime); float getCursorPixelRangeMult() const; + float getReticleMoveSpeed() const { return _reticleMoveSpeed; } + void setReticleMoveSpeed(float sixenseReticleMoveSpeed) { _reticleMoveSpeed = sixenseReticleMoveSpeed; } + bool getInvertButtons() const { return _invertButtons; } + void setInvertButtons(bool invertSixenseButtons) { _invertButtons = invertSixenseButtons; } + public slots: void setFilter(bool filter); @@ -102,6 +107,9 @@ private: bool _lowVelocityFilter; bool _controllersAtBase; + + float _reticleMoveSpeed = DEFAULT_SIXENSE_RETICLE_MOVE_SPEED; + bool _invertButtons = DEFAULT_INVERT_SIXENSE_MOUSE_BUTTONS; }; #endif // hifi_SixenseManager_h diff --git a/interface/src/ui/PreferencesDialog.cpp b/interface/src/ui/PreferencesDialog.cpp index 2ff572f24b..68579a2a13 100644 --- a/interface/src/ui/PreferencesDialog.cpp +++ b/interface/src/ui/PreferencesDialog.cpp @@ -12,6 +12,7 @@ #include #include +#include #include "Application.h" #include "Audio.h" @@ -163,9 +164,9 @@ void PreferencesDialog::loadPreferences() { ui.oculusUIAngularSizeSpin->setValue(qApp->getApplicationOverlay().getOculusUIAngularSize()); - ui.sixenseReticleMoveSpeedSpin->setValue(menuInstance->getSixenseReticleMoveSpeed()); - - ui.invertSixenseButtonsCheckBox->setChecked(menuInstance->getInvertSixenseButtons()); + SixenseManager& sixense = SixenseManager::getInstance(); + ui.sixenseReticleMoveSpeedSpin->setValue(sixense.getReticleMoveSpeed()); + ui.invertSixenseButtonsCheckBox->setChecked(sixense.getInvertButtons()); } @@ -244,10 +245,10 @@ void PreferencesDialog::savePreferences() { Menu::getInstance()->setMaxOctreePacketsPerSecond(ui.maxOctreePPSSpin->value()); qApp->getApplicationOverlay().setOculusUIAngularSize(ui.oculusUIAngularSizeSpin->value()); - - Menu::getInstance()->setSixenseReticleMoveSpeed(ui.sixenseReticleMoveSpeedSpin->value()); - - Menu::getInstance()->setInvertSixenseButtons(ui.invertSixenseButtonsCheckBox->isChecked()); + + SixenseManager& sixense = SixenseManager::getInstance(); + sixense.setReticleMoveSpeed(ui.sixenseReticleMoveSpeedSpin->value()); + sixense.setInvertButtons(ui.invertSixenseButtonsCheckBox->isChecked()); auto audio = DependencyManager::get