cleanup from code review comments

This commit is contained in:
Stephen Birarda 2013-08-05 10:37:23 -07:00
parent d51e0b59bd
commit 45d84add05
5 changed files with 2 additions and 5 deletions

View file

@ -14,7 +14,6 @@
#include <SharedUtil.h> #include <SharedUtil.h>
#include <UDPSocket.h> #include <UDPSocket.h>
const int ASSIGNMENT_SERVER_LISTEN_PORT = 7007;
const int MAX_PACKET_SIZE_BYTES = 1400; const int MAX_PACKET_SIZE_BYTES = 1400;
struct Assignment {}; struct Assignment {};

View file

@ -94,8 +94,6 @@ const char* Node::getTypeName() const {
return NODE_TYPE_NAME_AUDIO_INJECTOR; return NODE_TYPE_NAME_AUDIO_INJECTOR;
case NODE_TYPE_ANIMATION_SERVER: case NODE_TYPE_ANIMATION_SERVER:
return NODE_TYPE_NAME_ANIMATION_SERVER; return NODE_TYPE_NAME_ANIMATION_SERVER;
case NODE_TYPE_UNASSIGNED:
return NODE_TYPE_NAME_UNASSIGNED;
default: default:
return NODE_TYPE_NAME_UNKNOWN; return NODE_TYPE_NAME_UNKNOWN;
} }

View file

@ -368,7 +368,6 @@ int NodeList::processDomainServerList(unsigned char* packetData, size_t dataByte
void NodeList::sendAssignmentRequest() { void NodeList::sendAssignmentRequest() {
const char ASSIGNMENT_SERVER_HOSTNAME[] = "assignment.highfidelity.io"; const char ASSIGNMENT_SERVER_HOSTNAME[] = "assignment.highfidelity.io";
const unsigned short ASSIGNMENT_SERVER_PORT = 7007;
static sockaddr_in assignmentServerSocket = socketForHostname(ASSIGNMENT_SERVER_HOSTNAME); static sockaddr_in assignmentServerSocket = socketForHostname(ASSIGNMENT_SERVER_HOSTNAME);
assignmentServerSocket.sin_port = htons(ASSIGNMENT_SERVER_PORT); assignmentServerSocket.sin_port = htons(ASSIGNMENT_SERVER_PORT);

View file

@ -24,6 +24,5 @@ const NODE_TYPE NODE_TYPE_AUDIO_MIXER = 'M';
const NODE_TYPE NODE_TYPE_AVATAR_MIXER = 'W'; const NODE_TYPE NODE_TYPE_AVATAR_MIXER = 'W';
const NODE_TYPE NODE_TYPE_AUDIO_INJECTOR = 'A'; const NODE_TYPE NODE_TYPE_AUDIO_INJECTOR = 'A';
const NODE_TYPE NODE_TYPE_ANIMATION_SERVER = 'a'; const NODE_TYPE NODE_TYPE_ANIMATION_SERVER = 'a';
const NODE_TYPE NODE_TYPE_UNASSIGNED = 1;
#endif #endif

View file

@ -54,4 +54,6 @@ const int MAX_PACKET_HEADER_BYTES = sizeof(PACKET_TYPE) + sizeof(PACKET_VERSION)
#define ADD_SCENE_COMMAND "add scene" #define ADD_SCENE_COMMAND "add scene"
#define TEST_COMMAND "a message" #define TEST_COMMAND "a message"
const int ASSIGNMENT_SERVER_PORT = 7007;
#endif #endif