From 515c185887163294238ffa36be942a3a2090031e Mon Sep 17 00:00:00 2001 From: Seth Alves Date: Mon, 16 Apr 2018 19:10:16 -0700 Subject: [PATCH] don't call setPort on hifi urls when port is 0 (unset) --- libraries/networking/src/AddressManager.cpp | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/libraries/networking/src/AddressManager.cpp b/libraries/networking/src/AddressManager.cpp index 431a2e8ad5..daebcfb40d 100644 --- a/libraries/networking/src/AddressManager.cpp +++ b/libraries/networking/src/AddressManager.cpp @@ -439,7 +439,9 @@ void AddressManager::goToAddressFromObject(const QVariantMap& dataObject, const QUrl domainURL; domainURL.setScheme(URL_SCHEME_HIFI); domainURL.setHost(domainHostname); - domainURL.setPort(domainPort); + if (domainPort > 0) { + domainURL.setPort(domainPort); + } emit possibleDomainChangeRequired(domainURL, domainID); } else { QString iceServerAddress = domainObject[DOMAIN_ICE_SERVER_ADDRESS_KEY].toString(); @@ -610,7 +612,9 @@ bool AddressManager::handleNetworkAddress(const QString& lookupString, LookupTri QUrl domainURL; domainURL.setScheme(URL_SCHEME_HIFI); domainURL.setHost(domainIPString); - domainURL.setPort(domainPort); + if (domainPort > 0) { + domainURL.setPort(domainPort); + } hostChanged = setDomainInfo(domainURL, trigger); return true; @@ -631,7 +635,9 @@ bool AddressManager::handleNetworkAddress(const QString& lookupString, LookupTri QUrl domainURL; domainURL.setScheme(URL_SCHEME_HIFI); domainURL.setHost(domainHostname); - domainURL.setPort(domainPort); + if (domainPort > 0) { + domainURL.setPort(domainPort); + } hostChanged = setDomainInfo(domainURL, trigger); return true; @@ -763,7 +769,9 @@ bool AddressManager::setHost(const QString& host, LookupTrigger trigger, quint16 _domainURL = QUrl(); _domainURL.setScheme(URL_SCHEME_HIFI); _domainURL.setHost(host); - _domainURL.setPort(port); + if (port > 0) { + _domainURL.setPort(port); + } // any host change should clear the shareable place name _shareablePlaceName.clear();