From 44b8a57ed3813c159db0a146da8759f71b78f42b Mon Sep 17 00:00:00 2001 From: ZappoMan Date: Tue, 24 Jan 2017 12:18:33 -0800 Subject: [PATCH] more CR feedback --- libraries/avatars/src/AvatarData.cpp | 8 ++++---- libraries/avatars/src/AvatarData.h | 8 ++++---- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/libraries/avatars/src/AvatarData.cpp b/libraries/avatars/src/AvatarData.cpp index 92b7f378a3..17f85372eb 100644 --- a/libraries/avatars/src/AvatarData.cpp +++ b/libraries/avatars/src/AvatarData.cpp @@ -193,15 +193,15 @@ bool AvatarData::faceTrackerInfoChangedSince(quint64 time) { float AvatarData::getDistanceBasedMinRotationDOT(glm::vec3 viewerPosition) { auto distance = glm::distance(_globalPosition, viewerPosition); - float result = ROTATION_179D_DOT; // assume worst + float result = ROTATION_CHANGE_179D; // assume worst if (distance < AVATAR_DISTANCE_LEVEL_1) { result = AVATAR_MIN_ROTATION_DOT; } else if (distance < AVATAR_DISTANCE_LEVEL_2) { - result = ROTATION_15D_DOT; + result = ROTATION_CHANGE_15D; } else if (distance < AVATAR_DISTANCE_LEVEL_3) { - result = ROTATION_45D_DOT; + result = ROTATION_CHANGE_45D; } else if (distance < AVATAR_DISTANCE_LEVEL_4) { - result = ROTATION_90D_DOT; + result = ROTATION_CHANGE_90D; } return result; } diff --git a/libraries/avatars/src/AvatarData.h b/libraries/avatars/src/AvatarData.h index 84c82c5acd..9c19deae1b 100644 --- a/libraries/avatars/src/AvatarData.h +++ b/libraries/avatars/src/AvatarData.h @@ -256,10 +256,10 @@ const float AVATAR_SEND_FULL_UPDATE_RATIO = 0.02f; const float AVATAR_MIN_ROTATION_DOT = 0.9999999f; const float AVATAR_MIN_TRANSLATION = 0.0001f; -const float ROTATION_15D_DOT = 0.9914449f; -const float ROTATION_45D_DOT = 0.9238795f; -const float ROTATION_90D_DOT = 0.7071068f; -const float ROTATION_179D_DOT = 0.0087266f; +const float ROTATION_CHANGE_15D = 0.9914449f; +const float ROTATION_CHANGE_45D = 0.9238795f; +const float ROTATION_CHANGE_90D = 0.7071068f; +const float ROTATION_CHANGE_179D = 0.0087266f; const float AVATAR_DISTANCE_LEVEL_1 = 10.0f; const float AVATAR_DISTANCE_LEVEL_2 = 100.0f;