From 42579f3d167a67aa2f2a1ebd72f6a488b15fcbfa Mon Sep 17 00:00:00 2001
From: Wayne Chen <wayne@highfidelity.io>
Date: Tue, 25 Sep 2018 18:21:51 -0700
Subject: [PATCH] fixing oops dialog text index lookups

---
 scripts/system/redirectOverlays.js | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/scripts/system/redirectOverlays.js b/scripts/system/redirectOverlays.js
index c3aca60a94..fdd69fdab3 100644
--- a/scripts/system/redirectOverlays.js
+++ b/scripts/system/redirectOverlays.js
@@ -18,8 +18,9 @@
 
     function getOopsText() {
         error = Window.getLastDomainConnectionError();
-        if (hardRefusalErrors.indexOf(error) >= 0) {
-            return ERROR_MESSAGE_MAP[error];
+        var errorMessageMapIndex = hardRefusalErrors.indexOf(error);
+        if (errorMessageMapIndex >= 0) {
+            return ERROR_MESSAGE_MAP[errorMessageMapIndex];
         } else {
             // some other text.
             return ERROR_MESSAGE_MAP[4];
@@ -84,12 +85,13 @@
     function toggleOverlays() {
         var overlaysVisible = false;
         error = Window.getLastDomainConnectionError();
+        var errorMessageMapIndex = hardRefusalErrors.indexOf(error);
         var oopsText = "";
         if (error === -1) {
             overlaysVisible = false;
-        } else if (hardRefusalErrors.indexOf(error) >= 0) {
+        } else if (errorMessageMapIndex >= 0) {
             overlaysVisible = true;
-            oopsText = ERROR_MESSAGE_MAP[error];
+            oopsText = ERROR_MESSAGE_MAP[errorMessageMapIndex];
         } else {
             overlaysVisible = true;
             oopsText = ERROR_MESSAGE_MAP[4];