This commit is contained in:
Wayne Chen 2018-06-27 10:53:32 -07:00
commit 412d5c3709
4 changed files with 18 additions and 11 deletions

View file

@ -126,10 +126,12 @@ Item {
activeFocusOnPress: true activeFocusOnPress: true
ShortcutText { ShortcutText {
z: 10
anchors { anchors {
verticalCenter: usernameField.textFieldLabel.verticalCenter left: usernameField.left
left: usernameField.textFieldLabel.right top: usernameField.top
leftMargin: 10 leftMargin: usernameField.textFieldLabel.contentWidth + 10
topMargin: -19
} }
text: "<a href='https://highfidelity.com/users/password/new'>Forgot Username?</a>" text: "<a href='https://highfidelity.com/users/password/new'>Forgot Username?</a>"
@ -154,10 +156,12 @@ Item {
activeFocusOnPress: true activeFocusOnPress: true
ShortcutText { ShortcutText {
z: 10
anchors { anchors {
verticalCenter: passwordField.textFieldLabel.verticalCenter left: passwordField.left
left: passwordField.textFieldLabel.right top: passwordField.top
leftMargin: 10 leftMargin: passwordField.textFieldLabel.contentWidth + 10
topMargin: -19
} }
text: "<a href='https://highfidelity.com/users/password/new'>Forgot Password?</a>" text: "<a href='https://highfidelity.com/users/password/new'>Forgot Password?</a>"
@ -168,6 +172,7 @@ Item {
onLinkActivated: loginDialog.openUrl(link) onLinkActivated: loginDialog.openUrl(link)
} }
onFocusChanged: { onFocusChanged: {
root.text = ""; root.text = "";
root.isPassword = true; root.isPassword = true;

View file

@ -2294,6 +2294,7 @@ void Application::domainConnectionRefused(const QString& reasonMessage, int reas
QString message = "Unable to connect to the location you are visiting.\n"; QString message = "Unable to connect to the location you are visiting.\n";
message += reasonMessage; message += reasonMessage;
OffscreenUi::asyncWarning("", message); OffscreenUi::asyncWarning("", message);
getMyAvatar()->setWorldVelocity(glm::vec3(0.0f));
break; break;
} }
default: default:

View file

@ -279,18 +279,16 @@ EntityItemProperties RenderableModelEntityItem::getProperties(EntityPropertyFlag
} }
bool RenderableModelEntityItem::supportsDetailedRayIntersection() const { bool RenderableModelEntityItem::supportsDetailedRayIntersection() const {
return isModelLoaded(); return true;
} }
bool RenderableModelEntityItem::findDetailedRayIntersection(const glm::vec3& origin, const glm::vec3& direction, bool RenderableModelEntityItem::findDetailedRayIntersection(const glm::vec3& origin, const glm::vec3& direction,
OctreeElementPointer& element, float& distance, BoxFace& face, OctreeElementPointer& element, float& distance, BoxFace& face,
glm::vec3& surfaceNormal, QVariantMap& extraInfo, bool precisionPicking) const { glm::vec3& surfaceNormal, QVariantMap& extraInfo, bool precisionPicking) const {
auto model = getModel(); auto model = getModel();
if (!model) { if (!model || !isModelLoaded()) {
return true; return false;
} }
// qCDebug(entitiesrenderer) << "RenderableModelEntityItem::findDetailedRayIntersection() precisionPicking:"
// << precisionPicking;
return model->findRayIntersectionAgainstSubMeshes(origin, direction, distance, return model->findRayIntersectionAgainstSubMeshes(origin, direction, distance,
face, surfaceNormal, extraInfo, precisionPicking, false); face, surfaceNormal, extraInfo, precisionPicking, false);

View file

@ -191,6 +191,7 @@ void ScriptEngines::shutdownScripting() {
// Gracefully stop the engine's scripting thread // Gracefully stop the engine's scripting thread
scriptEngine->stop(); scriptEngine->stop();
removeScriptEngine(scriptEngine);
// We need to wait for the engine to be done running before we proceed, because we don't // We need to wait for the engine to be done running before we proceed, because we don't
// want any of the scripts final "scriptEnding()" or pending "update()" methods from accessing // want any of the scripts final "scriptEnding()" or pending "update()" methods from accessing
@ -394,6 +395,7 @@ void ScriptEngines::stopAllScripts(bool restart) {
// stop all scripts // stop all scripts
qCDebug(scriptengine) << "stopping script..." << it.key(); qCDebug(scriptengine) << "stopping script..." << it.key();
scriptEngine->stop(); scriptEngine->stop();
removeScriptEngine(scriptEngine);
} }
// wait for engines to stop (ie: providing time for .scriptEnding cleanup handlers to run) before // wait for engines to stop (ie: providing time for .scriptEnding cleanup handlers to run) before
// triggering reload of any Client scripts / Entity scripts // triggering reload of any Client scripts / Entity scripts
@ -441,6 +443,7 @@ bool ScriptEngines::stopScript(const QString& rawScriptURL, bool restart) {
} }
} }
scriptEngine->stop(); scriptEngine->stop();
removeScriptEngine(scriptEngine);
stoppedScript = true; stoppedScript = true;
qCDebug(scriptengine) << "stopping script..." << scriptURL; qCDebug(scriptengine) << "stopping script..." << scriptURL;
} }