From 3b7d1cb6cfdab27c24d018ac33d08604ef68936c Mon Sep 17 00:00:00 2001
From: David Kelly <davidmichaelkelly@gmail.com>
Date: Thu, 9 Aug 2018 13:56:42 -0700
Subject: [PATCH] Only update gain if it really changed

and only fire UserActivity if we really do change the gain
---
 interface/resources/qml/hifi/NameCard.qml | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/interface/resources/qml/hifi/NameCard.qml b/interface/resources/qml/hifi/NameCard.qml
index c7c2174e9f..780679d183 100644
--- a/interface/resources/qml/hifi/NameCard.qml
+++ b/interface/resources/qml/hifi/NameCard.qml
@@ -526,12 +526,15 @@ Item {
         anchors.left: nameCardVUMeter.left;
         // Properties
         visible: (isMyCard || (selected && pal.activeTab == "nearbyTab")) && isPresent;
-        value: Users.getAvatarGain(uuid)
         minimumValue: -60.0
         maximumValue: 20.0
         stepSize: 5
         updateValueWhileDragging: true
+        Component.onCompleted: {
+            value = Users.getAvatarGain(uuid);
+        }
         onValueChanged: {
+            console.log("onValueChanged:" + uuid + ", value="+value);
             updateGainFromQML(uuid, value, false);
         }
         onPressedChanged: {
@@ -587,9 +590,11 @@ Item {
    }
 
     function updateGainFromQML(avatarUuid, sliderValue, isReleased) {
-        Users.setAvatarGain(avatarUuid, sliderValue);
-        if (isReleased) {
-           UserActivityLogger.palAction("avatar_gain_changed", avatarUuid);
+        if (Users.getAvatarGain(avatarUuid) != sliderValue) {
+            Users.setAvatarGain(avatarUuid, sliderValue);
+            if (isReleased) {
+                UserActivityLogger.palAction("avatar_gain_changed", avatarUuid);
+            }
         }
     }