From 3969288996b0217c89160deba589040884619c7c Mon Sep 17 00:00:00 2001
From: Stephen Birarda <commit@birarda.com>
Date: Wed, 31 Jan 2018 15:26:54 -0800
Subject: [PATCH] re-hide advanced settings and show with collapsible

---
 domain-server/resources/web/base-settings.html | 16 +++++++++++++++-
 domain-server/resources/web/css/style.css      |  4 ++++
 2 files changed, 19 insertions(+), 1 deletion(-)

diff --git a/domain-server/resources/web/base-settings.html b/domain-server/resources/web/base-settings.html
index 13787b5fbe..2f0fcbe73b 100644
--- a/domain-server/resources/web/base-settings.html
+++ b/domain-server/resources/web/base-settings.html
@@ -24,6 +24,10 @@
                 <% return !value.deprecated %>
               <% })[0] %>
 
+              <% var split_settings = _.partition(group.settings, function(value, index) { %>
+                <% return !value.advanced %>
+              <% }) %>
+
               <% isGrouped = !!group.name %>
               <% panelID = isGrouped ? group.name : group.html_id %>
 
@@ -35,10 +39,20 @@
                   <span class="badge"></span>
                 </div>
                 <div class="panel-body">
-                  <% _.each(settings, function(setting) { %>
+                  <% _.each(split_settings[0], function(setting) { %>
                     <% keypath = isGrouped ? group.name + "." + setting.name : setting.name %>
                     <%= getFormGroup(keypath, setting, values, false) %>
                   <% }); %>
+
+                  <% if (split_settings[1].length > 0) { %>
+                    <button type="button" class="btn btn-default" data-toggle="collapse" data-target="#<%- panelID %>-advanced">Advanced Settings <span class="caret"></span></button>
+                    <div id="<%- panelID %>-advanced" class="collapse advanced-settings-section">
+                      <% _.each(split_settings[1], function(setting) { %>
+                        <% keypath = isGrouped ? group.name + "." + setting.name : setting.name %>
+                        <%= getFormGroup(keypath, setting, values, true) %>
+                      <% }); %>
+                    </div>
+                  <% } %>
                 </div>
               </div>
             <% } %>
diff --git a/domain-server/resources/web/css/style.css b/domain-server/resources/web/css/style.css
index 5155ab2330..8090c9f450 100644
--- a/domain-server/resources/web/css/style.css
+++ b/domain-server/resources/web/css/style.css
@@ -426,3 +426,7 @@ ul.nav li.dropdown ul.dropdown-menu .divider {
   position: relative;
   top: -1px;
 }
+
+.advanced-settings-section {
+  margin-top: 20px;
+}