From 36e526d1cde8280f09bb7b21ee4fb748e63bef68 Mon Sep 17 00:00:00 2001 From: Howard Stearns Date: Mon, 1 Jul 2019 15:23:00 -0700 Subject: [PATCH] cr feedback --- libraries/platform/src/platform/backend/WINPlatform.cpp | 8 ++++---- libraries/platform/src/platform/backend/WINPlatform.h | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/libraries/platform/src/platform/backend/WINPlatform.cpp b/libraries/platform/src/platform/backend/WINPlatform.cpp index f71782a20b..d07bb83510 100644 --- a/libraries/platform/src/platform/backend/WINPlatform.cpp +++ b/libraries/platform/src/platform/backend/WINPlatform.cpp @@ -78,12 +78,12 @@ void WINInstance::enumerateNics() { // We can usually do better than the QNetworkInterface::humanReadableName() by // matching up Iphlpapi.lib IP_ADAPTER_INFO by mac id. ULONG buflen = sizeof(IP_ADAPTER_INFO); - IP_ADAPTER_INFO *pAdapterInfo = (IP_ADAPTER_INFO *)malloc(buflen); + IP_ADAPTER_INFO* pAdapterInfo = (IP_ADAPTER_INFO*) malloc(buflen); // Size the buffer: if (GetAdaptersInfo(pAdapterInfo, &buflen) == ERROR_BUFFER_OVERFLOW) { free(pAdapterInfo); - pAdapterInfo = (IP_ADAPTER_INFO *)malloc(buflen); + pAdapterInfo = (IP_ADAPTER_INFO *) malloc(buflen); } // Now get the data... @@ -93,8 +93,8 @@ void WINInstance::enumerateNics() { QString qtmac = nic[keys::nic::mac].get().c_str(); QString qtraw = qtmac.remove(QChar(':'), Qt::CaseInsensitive).toLower(); // ... and find the matching one in pAdapter: - for (IP_ADAPTER_INFO *pAdapter = pAdapterInfo; pAdapter; pAdapter = pAdapter->Next) { - QByteArray wmac = QByteArray((const char *)(pAdapter->Address), pAdapter->AddressLength); + for (IP_ADAPTER_INFO* pAdapter = pAdapterInfo; pAdapter; pAdapter = pAdapter->Next) { + QByteArray wmac = QByteArray((const char*) (pAdapter->Address), pAdapter->AddressLength); QString wraw = wmac.toHex(); if (qtraw == wraw) { nic[keys::nic::name] = pAdapter->Description; diff --git a/libraries/platform/src/platform/backend/WINPlatform.h b/libraries/platform/src/platform/backend/WINPlatform.h index 4dae0d2d0b..4926d578f7 100644 --- a/libraries/platform/src/platform/backend/WINPlatform.h +++ b/libraries/platform/src/platform/backend/WINPlatform.h @@ -19,7 +19,7 @@ namespace platform { void enumerateGpus() override; void enumerateMemory() override; void enumerateComputer () override; - void enumerateNics(); + void enumerateNics() override; }; } // namespace platform