From 36e1366cc467133056f587a8b122e665999a9e83 Mon Sep 17 00:00:00 2001
From: Preston Bezos <preston@highfidelity.io>
Date: Thu, 6 Jun 2019 14:19:37 -0700
Subject: [PATCH] added Notifies to various QProperties in order to remove
 warnings in interface logs

---
 interface/src/avatar/MyAvatar.cpp      | 1 +
 interface/src/avatar/MyAvatar.h        | 9 ++++++++-
 interface/src/scripting/AudioDevices.h | 2 +-
 libraries/shared/src/shared/Camera.h   | 2 +-
 4 files changed, 11 insertions(+), 3 deletions(-)

diff --git a/interface/src/avatar/MyAvatar.cpp b/interface/src/avatar/MyAvatar.cpp
index ad39b6663a..f3172772ab 100644
--- a/interface/src/avatar/MyAvatar.cpp
+++ b/interface/src/avatar/MyAvatar.cpp
@@ -5014,6 +5014,7 @@ float MyAvatar::getAnalogSprintSpeed() const {
 
 void MyAvatar::setAnalogPlusWalkSpeed(float value) {
     _analogPlusWalkSpeed.set(value);
+    analogPlusWalkSpeedChanged(value);
     // Sprint speed for Analog Plus should be double walk speed.
     _analogPlusSprintSpeed.set(value * 2.0f);
 }
diff --git a/interface/src/avatar/MyAvatar.h b/interface/src/avatar/MyAvatar.h
index 9fb6c85a78..7736eba7ea 100644
--- a/interface/src/avatar/MyAvatar.h
+++ b/interface/src/avatar/MyAvatar.h
@@ -370,7 +370,7 @@ class MyAvatar : public Avatar {
     Q_PROPERTY(QUuid SELF_ID READ getSelfID CONSTANT)
 
     Q_PROPERTY(float walkSpeed READ getWalkSpeed WRITE setWalkSpeed);
-    Q_PROPERTY(float analogPlusWalkSpeed READ getAnalogPlusWalkSpeed WRITE setAnalogPlusWalkSpeed);
+    Q_PROPERTY(float analogPlusWalkSpeed READ getAnalogPlusWalkSpeed WRITE setAnalogPlusWalkSpeed NOTIFY analogPlusWalkSpeedChanged);
     Q_PROPERTY(float analogPlusSprintSpeed READ getAnalogPlusSprintSpeed WRITE setAnalogPlusSprintSpeed);
     Q_PROPERTY(float walkBackwardSpeed READ getWalkBackwardSpeed WRITE setWalkBackwardSpeed);
     Q_PROPERTY(float sprintSpeed READ getSprintSpeed WRITE setSprintSpeed);
@@ -2161,6 +2161,13 @@ signals:
      */
     void audioListenerModeChanged();
 
+    /**jsdoc
+     * Notifies when the analogPlusWalkSpeed value changed.
+     * @function MyAvatar.analogPlusWalkSpeedChanged
+     * @returns {Signal} 
+     */
+    void analogPlusWalkSpeedChanged(float value);
+
     /**jsdoc
      * @function MyAvatar.transformChanged
      * @returns {Signal} 
diff --git a/interface/src/scripting/AudioDevices.h b/interface/src/scripting/AudioDevices.h
index 3d12f93113..2ea034d9fe 100644
--- a/interface/src/scripting/AudioDevices.h
+++ b/interface/src/scripting/AudioDevices.h
@@ -80,7 +80,7 @@ public:
 
 class AudioInputDeviceList : public AudioDeviceList {
     Q_OBJECT
-    Q_PROPERTY(bool peakValuesAvailable READ peakValuesAvailable)
+    Q_PROPERTY(bool peakValuesAvailable READ peakValuesAvailable CONSTANT)
     Q_PROPERTY(bool peakValuesEnabled READ peakValuesEnabled WRITE setPeakValuesEnabled NOTIFY peakValuesEnabledChanged)
 
 public:
diff --git a/libraries/shared/src/shared/Camera.h b/libraries/shared/src/shared/Camera.h
index f41183479c..0df83cfb9a 100644
--- a/libraries/shared/src/shared/Camera.h
+++ b/libraries/shared/src/shared/Camera.h
@@ -38,7 +38,7 @@ class Camera : public QObject {
 
     Q_PROPERTY(glm::vec3 position READ getPosition WRITE setPosition)
     Q_PROPERTY(glm::quat orientation READ getOrientation WRITE setOrientation)
-    Q_PROPERTY(QString mode READ getModeString WRITE setModeString)
+    Q_PROPERTY(QString mode READ getModeString WRITE setModeString NOTIFY modeUpdated)
     Q_PROPERTY(QVariantMap frustum READ getViewFrustum CONSTANT)
 
 public: