From 35194b0f44403707e6f8ea9131b951f13982b6fa Mon Sep 17 00:00:00 2001 From: steve hocktail Date: Mon, 28 Feb 2022 22:09:43 -0500 Subject: [PATCH] fixed deprecated qml implicitly defined onFoo properties in connections --- interface/resources/qml/+android_interface/Stats.qml | 2 +- interface/resources/qml/AnimStats.qml | 2 +- interface/resources/qml/AudioScopeUI.qml | 4 ++-- .../+android_interface/LinkAccountBody.qml | 8 ++++---- .../LoginDialog/+android_interface/SignUpBody.qml | 8 ++++---- .../qml/LoginDialog/CompleteProfileBody.qml | 4 ++-- .../resources/qml/LoginDialog/LinkAccountBody.qml | 4 ++-- .../resources/qml/LoginDialog/LoggingInBody.qml | 12 ++++++------ interface/resources/qml/LoginDialog/SignUpBody.qml | 8 ++++---- .../qml/LoginDialog/UsernameCollisionBody.qml | 12 ++++++------ interface/resources/qml/Stats.qml | 2 +- interface/resources/qml/controls/ButtonAwesome.qml | 2 +- interface/resources/qml/dialogs/FileDialog.qml | 4 ++-- interface/resources/qml/dialogs/TabletFileDialog.qml | 4 ++-- .../qml/dialogs/assetDialog/AssetDialogContent.qml | 2 +- interface/resources/qml/hifi/Pal.qml | 6 +++--- .../qml/hifi/avatarPackager/AvatarProject.qml | 2 +- .../resources/qml/hifi/dialogs/RunningScripts.qml | 4 ++-- .../resources/qml/hifi/dialogs/TabletDebugWindow.qml | 8 ++++---- .../qml/hifi/dialogs/TabletRunningScripts.qml | 4 ++-- .../qml/hifi/simplifiedUI/avatarApp/AvatarApp.qml | 2 +- .../inputDeviceButton/InputDeviceButton.qml | 4 ++-- .../simplifiedUI/settingsApp/general/General.qml | 6 +++--- .../hifi/simplifiedUI/topBar/SimplifiedTopBar.qml | 2 +- interface/resources/qml/hifi/tablet/TabletButton.qml | 2 +- interface/resources/qml/hifi/tablet/TabletRoot.qml | 2 +- interface/resources/qml/hifi/tablet/WindowRoot.qml | 2 +- .../hifi/tablet/tabletWindows/TabletFileDialog.qml | 4 ++-- interface/resources/qml/hifi/toolbars/Toolbar.qml | 4 +++- interface/resources/qml/windows/Decoration.qml | 6 +++--- interface/resources/qml/windows/Window.qml | 2 +- scripts/communityScripts/chat/FloofChat.qml | 3 ++- .../ui/qml/SimplifiedEmoteIndicator.qml | 2 +- 33 files changed, 73 insertions(+), 70 deletions(-) diff --git a/interface/resources/qml/+android_interface/Stats.qml b/interface/resources/qml/+android_interface/Stats.qml index 913a817cd9..97d076ab6a 100644 --- a/interface/resources/qml/+android_interface/Stats.qml +++ b/interface/resources/qml/+android_interface/Stats.qml @@ -412,7 +412,7 @@ Item { Connections { target: root.parent - onWidthChanged: { + function onWidthChanged() { root.x = root.parent.width - root.width; } } diff --git a/interface/resources/qml/AnimStats.qml b/interface/resources/qml/AnimStats.qml index 70f2e37927..16bbe17eec 100644 --- a/interface/resources/qml/AnimStats.qml +++ b/interface/resources/qml/AnimStats.qml @@ -174,7 +174,7 @@ Item { Connections { target: root.parent - onWidthChanged: { + function onWidthChanged() { root.x = root.parent.width - root.width; } } diff --git a/interface/resources/qml/AudioScopeUI.qml b/interface/resources/qml/AudioScopeUI.qml index 91908807e2..75a71a32c5 100644 --- a/interface/resources/qml/AudioScopeUI.qml +++ b/interface/resources/qml/AudioScopeUI.qml @@ -614,7 +614,7 @@ Item { Connections { target: AudioScope - onPauseChanged: { + function onPauseChanged() { if (!AudioScope.getPause()) { pauseButton.text = "Pause"; pauseButton.color = hifi.buttons.black; @@ -625,7 +625,7 @@ Item { pauseButton.color = hifi.buttons.blue; } } - onTriggered: { + function onTriggered() { _triggered = true; collectTriggerData(); AudioScope.setPause(true); diff --git a/interface/resources/qml/LoginDialog/+android_interface/LinkAccountBody.qml b/interface/resources/qml/LoginDialog/+android_interface/LinkAccountBody.qml index a40110b1e9..8570273bde 100644 --- a/interface/resources/qml/LoginDialog/+android_interface/LinkAccountBody.qml +++ b/interface/resources/qml/LoginDialog/+android_interface/LinkAccountBody.qml @@ -247,7 +247,7 @@ Item { Connections { target: loginDialog - onHandleLoginCompleted: { + function onHandleLoginCompleted() { console.log("Login Succeeded, linking steam account") if (loginDialog.isSteamRunning()) { @@ -258,19 +258,19 @@ Item { bodyLoader.item.height = root.pane.height } } - onHandleLoginFailed: { + function onHandleLoginFailed() { console.log("Login Failed") mainTextContainer.visible = true toggleLoading(false) } - onHandleLinkCompleted: { + function onHandleLinkCompleted() { console.log("Link Succeeded") bodyLoader.setSource("../WelcomeBody.qml", { "welcomeBack" : true }) bodyLoader.item.width = root.pane.width bodyLoader.item.height = root.pane.height } - onHandleLinkFailed: { + function onHandleLinkFailed() { console.log("Link Failed") toggleLoading(false) } diff --git a/interface/resources/qml/LoginDialog/+android_interface/SignUpBody.qml b/interface/resources/qml/LoginDialog/+android_interface/SignUpBody.qml index 10909e4c85..f2329c065c 100644 --- a/interface/resources/qml/LoginDialog/+android_interface/SignUpBody.qml +++ b/interface/resources/qml/LoginDialog/+android_interface/SignUpBody.qml @@ -253,13 +253,13 @@ Item { Connections { target: loginDialog - onHandleSignupCompleted: { + function onHandleSignupCompleted() { console.log("Sign Up Succeeded"); // now that we have an account, login with that username and password loginDialog.login(usernameField.text, passwordField.text) } - onHandleSignupFailed: { + function onHandleSignupFailed() { console.log("Sign Up Failed") toggleLoading(false) @@ -268,12 +268,12 @@ Item { d.resize(); } - onHandleLoginCompleted: { + function onHandleLoginCompleted() { bodyLoader.setSource("../WelcomeBody.qml", { "welcomeBack": false }) bodyLoader.item.width = root.pane.width bodyLoader.item.height = root.pane.height } - onHandleLoginFailed: { + function onHandleLoginFailed() { // we failed to login, show the LoginDialog so the user will try again bodyLoader.setSource("LinkAccountBody.qml", { "failAfterSignUp": true }) bodyLoader.item.width = root.pane.width diff --git a/interface/resources/qml/LoginDialog/CompleteProfileBody.qml b/interface/resources/qml/LoginDialog/CompleteProfileBody.qml index f90a7d8561..13e778209f 100644 --- a/interface/resources/qml/LoginDialog/CompleteProfileBody.qml +++ b/interface/resources/qml/LoginDialog/CompleteProfileBody.qml @@ -492,7 +492,7 @@ Item { Connections { target: loginDialog - onHandleCreateCompleted: { + function onHandleCreateCompleted90 { console.log("Create Succeeded"); if (completeProfileBody.withSteam) { if (completeProfileBody.loginDialogPoppedUp) { @@ -506,7 +506,7 @@ Item { bodyLoader.setSource("LoggingInBody.qml", { "loginDialog": loginDialog, "root": root, "bodyLoader": bodyLoader, "withSteam": completeProfileBody.withSteam, "linkSteam": false, "withOculus": completeProfileBody.withOculus, "linkOculus": false }); } - onHandleCreateFailed: { + function onHandleCreateFailed() { console.log("Create Failed: " + error); if (completeProfileBody.withSteam || completeProfileBody.withOculus) { if (completeProfileBody.loginDialogPoppedUp) { diff --git a/interface/resources/qml/LoginDialog/LinkAccountBody.qml b/interface/resources/qml/LoginDialog/LinkAccountBody.qml index f2239be7f5..c095ecf492 100644 --- a/interface/resources/qml/LoginDialog/LinkAccountBody.qml +++ b/interface/resources/qml/LoginDialog/LinkAccountBody.qml @@ -724,14 +724,14 @@ Item { Connections { target: loginDialog - onFocusEnabled: { + function onFocusEnabled() { if (!linkAccountBody.lostFocus) { Qt.callLater(function() { displayNameField.forceActiveFocus(); }); } } - onFocusDisabled: { + function onFocusDisabled() { linkAccountBody.lostFocus = !root.isTablet && !root.isOverlay; if (linkAccountBody.lostFocus) { Qt.callLater(function() { diff --git a/interface/resources/qml/LoginDialog/LoggingInBody.qml b/interface/resources/qml/LoginDialog/LoggingInBody.qml index 757c8b7449..04af9eadc9 100644 --- a/interface/resources/qml/LoginDialog/LoggingInBody.qml +++ b/interface/resources/qml/LoginDialog/LoggingInBody.qml @@ -303,7 +303,7 @@ Item { Connections { target: loginDialog - onHandleCreateCompleted: { + function onHandleCreateCompleted() { console.log("Create Succeeded") if (loggingInBody.withOculus) { if (loggingInBody.loginDialogPoppedUp) { @@ -318,7 +318,7 @@ Item { oculusSuccessTimer.start(); } } - onHandleCreateFailed: { + function onHandleCreateFailed() { console.log("Create Failed: " + error); if (loggingInBody.withOculus) { if (loggingInBody.loginDialogPoppedUp) { @@ -331,7 +331,7 @@ Item { "withOculus": loggingInBody.withOculus, "errorString": error }); } } - onHandleLinkCompleted: { + function onHandleLinkCompleted() { console.log("Link Succeeded"); if (loggingInBody.linkSteam) { loggingInBody.linkSteam = false; @@ -352,7 +352,7 @@ Item { } loggingInBody.loadingSuccess(); } - onHandleLinkFailed: { + function onHandleLinkFailed() { console.log("Link Failed: " + error); loggingInSpinner.visible = false; if (loggingInBody.linkOculus) { @@ -377,12 +377,12 @@ Item { } } - onHandleLoginCompleted: { + function onHandleLoginCompleted(): { console.log("Login Succeeded"); loggingInBody.loadingSuccess(); } - onHandleLoginFailed: { + function onHandleLoginFailed() { console.log("Login Failed") loggingInSpinner.visible = false; loggingInGlyph.visible = false; diff --git a/interface/resources/qml/LoginDialog/SignUpBody.qml b/interface/resources/qml/LoginDialog/SignUpBody.qml index 04ae40d19e..aae0f7609d 100644 --- a/interface/resources/qml/LoginDialog/SignUpBody.qml +++ b/interface/resources/qml/LoginDialog/SignUpBody.qml @@ -455,7 +455,7 @@ Item { } Connections { target: loginDialog - onHandleSignupCompleted: { + function onHandleSignupCompleted() { console.log("Sign Up Completed"); if (signUpBody.loginDialogPoppedUp) { @@ -468,7 +468,7 @@ Item { loginDialog.login(usernameField.text, passwordField.text); bodyLoader.setSource("LoggingInBody.qml", { "loginDialog": loginDialog, "root": root, "bodyLoader": bodyLoader, "withSteam": false, "linkSteam": false }); } - onHandleSignupFailed: { + function onHandleSignupFailed() { console.log("Sign Up Failed") if (signUpBody.loginDialogPoppedUp) { @@ -495,14 +495,14 @@ Item { errorContainer.anchors.left = usernameField.left; } } - onFocusEnabled: { + function onFocusEnabled() { if (!signUpBody.lostFocus) { Qt.callLater(function() { emailField.forceActiveFocus(); }); } } - onFocusDisabled: { + function onFocusDisabled() { signUpBody.lostFocus = !root.isTablet && !root.isOverlay; if (signUpBody.lostFocus) { Qt.callLater(function() { diff --git a/interface/resources/qml/LoginDialog/UsernameCollisionBody.qml b/interface/resources/qml/LoginDialog/UsernameCollisionBody.qml index 70ee0e3d3f..86f60bc067 100644 --- a/interface/resources/qml/LoginDialog/UsernameCollisionBody.qml +++ b/interface/resources/qml/LoginDialog/UsernameCollisionBody.qml @@ -262,7 +262,7 @@ Item { Connections { target: loginDialog - onHandleCreateCompleted: { + function onHandleCreateCompleted() { console.log("Create Succeeded"); if (usernameCollisionBody.withOculus) { if (usernameCollisionBody.loginDialogPoppedUp) { @@ -284,7 +284,7 @@ Item { bodyLoader.setSource("LoggingInBody.qml", { "loginDialog": loginDialog, "root": root, "bodyLoader": bodyLoader, "withSteam": usernameCollisionBody.withSteam, "withOculus": usernameCollisionBody.withOculus, "linkSteam": false, "linkOculus": false }) } - onHandleCreateFailed: { + function onHandleCreateFailed() { console.log("Create Failed: " + error) if (usernameCollisionBody.loginDialogPoppedUp) { var data = { @@ -297,7 +297,7 @@ Item { mainTextContainer.visible = true mainTextContainer.text = "\"" + textField.text + qsTr("\" is invalid or already taken."); } - onHandleLoginCompleted: { + function onHandleLoginCompleted() { console.log("Login Succeeded"); if (usernameCollisionBody.loginDialogPoppedUp) { var data = { @@ -310,7 +310,7 @@ Item { root.tryDestroy(); } - onHandleLoginFailed: { + function onHandleLoginFailed() { console.log("Login Failed") if (usernameCollisionBody.loginDialogPoppedUp) { var data = { @@ -323,14 +323,14 @@ Item { } - onFocusEnabled: { + function onFocusEnabled() { if (!usernameCollisionBody.lostFocus) { Qt.callLater(function() { textField.forceActiveFocus(); }); } } - onFocusDisabled: { + function onFocusDisabled() { usernameCollisionBody.lostFocus = !root.isTablet && !root.isOverlay; if (nusernameCollisionBody.lostFocus) { Qt.callLater(function() { diff --git a/interface/resources/qml/Stats.qml b/interface/resources/qml/Stats.qml index f18fb06dc3..0b5eba99d0 100644 --- a/interface/resources/qml/Stats.qml +++ b/interface/resources/qml/Stats.qml @@ -463,7 +463,7 @@ Item { Connections { target: root.parent - onWidthChanged: { + function onWidthChanged() { root.x = root.parent.width - root.width; } } diff --git a/interface/resources/qml/controls/ButtonAwesome.qml b/interface/resources/qml/controls/ButtonAwesome.qml index bb1df94471..12f2a6b40d 100644 --- a/interface/resources/qml/controls/ButtonAwesome.qml +++ b/interface/resources/qml/controls/ButtonAwesome.qml @@ -30,7 +30,7 @@ Original.Button { Connections { target: control - onActiveFocusChanged: { + function onActiveFocusChanged() { if (control.activeFocus) { pulseAnimation.restart(); } else { diff --git a/interface/resources/qml/dialogs/FileDialog.qml b/interface/resources/qml/dialogs/FileDialog.qml index 4eea3566b8..fa4d911b65 100644 --- a/interface/resources/qml/dialogs/FileDialog.qml +++ b/interface/resources/qml/dialogs/FileDialog.qml @@ -264,8 +264,8 @@ ModalWindow { readonly property string currentSelectionPath: helper.urlToPath(currentSelectionUrl); property bool currentSelectionIsFolder; property var backStack: [] - property var tableViewConnection: Connections { target: fileTableView; onCurrentRowChanged: d.update(); } - property var modelConnection: Connections { target: fileTableModel; onFolderChanged: d.update(); } + property var tableViewConnection: Connections { target: fileTableView; function onCurrentRowChanged() { d.update(); } } + property var modelConnection: Connections { target: fileTableModel; function onFolderChanged() { d.update(); } } property var homeDestination: helper.home(); function capitalizeDrive(path) { diff --git a/interface/resources/qml/dialogs/TabletFileDialog.qml b/interface/resources/qml/dialogs/TabletFileDialog.qml index 5bcc42f101..4ee53d44ef 100644 --- a/interface/resources/qml/dialogs/TabletFileDialog.qml +++ b/interface/resources/qml/dialogs/TabletFileDialog.qml @@ -229,8 +229,8 @@ TabletModalWindow { readonly property string currentSelectionPath: helper.urlToPath(currentSelectionUrl); property bool currentSelectionIsFolder; property var backStack: [] - property var tableViewConnection: Connections { target: fileTableView; onCurrentRowChanged: d.update(); } - property var modelConnection: Connections { target: fileTableModel; onFolderChanged: d.update(); } + property var tableViewConnection: Connections { target: fileTableView; function onCurrentRowChanged() { d.update(); } } + property var modelConnection: Connections { target: fileTableModel; function onFolderChanged() { d.update(); } } property var homeDestination: helper.home(); function capitalizeDrive(path) { diff --git a/interface/resources/qml/dialogs/assetDialog/AssetDialogContent.qml b/interface/resources/qml/dialogs/assetDialog/AssetDialogContent.qml index da976ef3e1..eaf1d72fea 100644 --- a/interface/resources/qml/dialogs/assetDialog/AssetDialogContent.qml +++ b/interface/resources/qml/dialogs/assetDialog/AssetDialogContent.qml @@ -151,7 +151,7 @@ Item { property string currentSelectionPath property bool currentSelectionIsFolder - property var tableViewConnection: Connections { target: assetTableView; onCurrentRowChanged: d.update(); } + property var tableViewConnection: Connections { target: assetTableView; function onCurrentRowChanged() { d.update(); } } function update() { var row = assetTableView.currentRow; diff --git a/interface/resources/qml/hifi/Pal.qml b/interface/resources/qml/hifi/Pal.qml index 15fa8df93d..a17eb0c765 100644 --- a/interface/resources/qml/hifi/Pal.qml +++ b/interface/resources/qml/hifi/Pal.qml @@ -84,7 +84,7 @@ Rectangle { } Connections { target: GlobalServices - onMyUsernameChanged: { + function onMyUsernameChanged() { myData.userName = Account.username; myDataChanged(); // Setting a property within an object isn't enough to update dependencies. This will do it. } @@ -696,7 +696,7 @@ Rectangle { Connections { target: nearbyTable - onTitlePaintedPosSignal: { + function onTitlePaintedPosSignal(column) { if (column === 1) { // name column questionRect.anchors.leftMargin = actionButtonWidth + nearbyTable.titlePaintedPos[column] } @@ -1395,6 +1395,6 @@ Rectangle { } Connections { target: nearbyTable.selection; - onSelectionChanged: pal.noticeSelection(); + function onSelectionChanged() { pal.noticeSelection(); } } } diff --git a/interface/resources/qml/hifi/avatarPackager/AvatarProject.qml b/interface/resources/qml/hifi/avatarPackager/AvatarProject.qml index 62540d34d7..2b06d7e99e 100644 --- a/interface/resources/qml/hifi/avatarPackager/AvatarProject.qml +++ b/interface/resources/qml/hifi/avatarPackager/AvatarProject.qml @@ -191,7 +191,7 @@ Item { Connections { target: root.uploader - onStateChanged: { + function onStateChanged(newState) { root.hasSuccessfullyUploaded = newState >= 4; } } diff --git a/interface/resources/qml/hifi/dialogs/RunningScripts.qml b/interface/resources/qml/hifi/dialogs/RunningScripts.qml index 421068a119..de7b5a179f 100644 --- a/interface/resources/qml/hifi/dialogs/RunningScripts.qml +++ b/interface/resources/qml/hifi/dialogs/RunningScripts.qml @@ -89,7 +89,7 @@ Windows.ScrollingWindow { Connections { target: ScriptDiscoveryService - onScriptCountChanged: { + function onScriptCountChanged() { runningScriptsModel = listModelBuilder.createObject(root); refreshTimer.restart(); } @@ -397,7 +397,7 @@ Windows.ScrollingWindow { Connections { target: treeView.selection - onCurrentIndexChanged: { + function onCurrentIndexChanged() { var path = scriptsModel.data(treeView.selection.currentIndex, 0x100) if (path) { selectedScript.text = path diff --git a/interface/resources/qml/hifi/dialogs/TabletDebugWindow.qml b/interface/resources/qml/hifi/dialogs/TabletDebugWindow.qml index 213dca8b48..12a4cf1761 100644 --- a/interface/resources/qml/hifi/dialogs/TabletDebugWindow.qml +++ b/interface/resources/qml/hifi/dialogs/TabletDebugWindow.qml @@ -59,10 +59,10 @@ Rectangle { Connections { target: ScriptDiscoveryService - onPrintedMessage: sendToLogWindow("", message, engineName); - onWarningMessage: sendToLogWindow("WARNING", message, engineName); - onErrorMessage: sendToLogWindow("ERROR", message, engineName); - onInfoMessage: sendToLogWindow("INFO", message, engineName); + function onPrintedMessage(message, engineName) { sendToLogWindow("", message, engineName); } + function onWarningMessage(message, engineName) { sendToLogWindow("WARNING", message, engineName); } + function onErrorMessage(message, engineName) { sendToLogWindow("ERROR", message, engineName); } + function onInfoMessage(message, engineName) { sendToLogWindow("INFO", message, engineName); } } TextArea { diff --git a/interface/resources/qml/hifi/dialogs/TabletRunningScripts.qml b/interface/resources/qml/hifi/dialogs/TabletRunningScripts.qml index 5c01a16720..4aeeada1e5 100644 --- a/interface/resources/qml/hifi/dialogs/TabletRunningScripts.qml +++ b/interface/resources/qml/hifi/dialogs/TabletRunningScripts.qml @@ -75,7 +75,7 @@ Rectangle { Connections { target: ScriptDiscoveryService - onScriptCountChanged: { + function onScriptCountChanged() { runningScriptsModel = listModelBuilder.createObject(root); refreshTimer.restart(); } @@ -430,7 +430,7 @@ Rectangle { Connections { target: treeView.selection - onCurrentIndexChanged: { + function onCurrentIndexChanged() { var path = scriptsModel.data(treeView.selection.currentIndex, 0x100) if (path) { selectedScript.text = path diff --git a/interface/resources/qml/hifi/simplifiedUI/avatarApp/AvatarApp.qml b/interface/resources/qml/hifi/simplifiedUI/avatarApp/AvatarApp.qml index 5ca2227dfb..b99ce92806 100644 --- a/interface/resources/qml/hifi/simplifiedUI/avatarApp/AvatarApp.qml +++ b/interface/resources/qml/hifi/simplifiedUI/avatarApp/AvatarApp.qml @@ -49,7 +49,7 @@ Rectangle { Connections { target: MyAvatar - onSkeletonModelURLChanged: { + function onSkeletonModelURLChanged() { root.updatePreviewUrl(); } } diff --git a/interface/resources/qml/hifi/simplifiedUI/inputDeviceButton/InputDeviceButton.qml b/interface/resources/qml/hifi/simplifiedUI/inputDeviceButton/InputDeviceButton.qml index 7f007d10df..9e02820168 100644 --- a/interface/resources/qml/hifi/simplifiedUI/inputDeviceButton/InputDeviceButton.qml +++ b/interface/resources/qml/hifi/simplifiedUI/inputDeviceButton/InputDeviceButton.qml @@ -41,11 +41,11 @@ Rectangle { Connections { target: AudioScriptingInterface - onNoiseGateOpened: { + function onNoiseGateOpened() { gated = false; } - onNoiseGateClosed: { + function onNoiseGateClosed() { gated = false; } } diff --git a/interface/resources/qml/hifi/simplifiedUI/settingsApp/general/General.qml b/interface/resources/qml/hifi/simplifiedUI/settingsApp/general/General.qml index 2c17ecf6c3..68f667ec78 100644 --- a/interface/resources/qml/hifi/simplifiedUI/settingsApp/general/General.qml +++ b/interface/resources/qml/hifi/simplifiedUI/settingsApp/general/General.qml @@ -145,7 +145,7 @@ Flickable { Connections { target: Settings - onValueChanged: { + function onValueChanged(setting, value) { if (setting === "simplifiedUI/allowEmoteDrawerExpansion") { emoteSwitch.checked = value; } @@ -262,7 +262,7 @@ Flickable { Connections { target: Camera - onModeUpdated: { + function onModeUpdated() { if (Camera.mode === "first person look at") { firstPerson.checked = true } else if (Camera.mode === "look at") { @@ -276,7 +276,7 @@ Flickable { Connections { target: HMD - onDisplayModeChanged: { + function onDisplayModeChanged() { selfie.visible = isHMDMode ? false : true } } diff --git a/interface/resources/qml/hifi/simplifiedUI/topBar/SimplifiedTopBar.qml b/interface/resources/qml/hifi/simplifiedUI/topBar/SimplifiedTopBar.qml index 778c626048..801d89092d 100644 --- a/interface/resources/qml/hifi/simplifiedUI/topBar/SimplifiedTopBar.qml +++ b/interface/resources/qml/hifi/simplifiedUI/topBar/SimplifiedTopBar.qml @@ -49,7 +49,7 @@ Rectangle { Connections { target: MyAvatar - onSkeletonModelURLChanged: { + function onSkeletonModelURLChanged() { root.updatePreviewUrl(); if ((MyAvatar.skeletonModelURL.indexOf("defaultAvatar") > -1 || MyAvatar.skeletonModelURL.indexOf("fst") === -1) && diff --git a/interface/resources/qml/hifi/tablet/TabletButton.qml b/interface/resources/qml/hifi/tablet/TabletButton.qml index ec24caeef2..bea2d31e2b 100644 --- a/interface/resources/qml/hifi/tablet/TabletButton.qml +++ b/interface/resources/qml/hifi/tablet/TabletButton.qml @@ -38,7 +38,7 @@ Item { Connections { target: flickable - onMovingChanged: { + function onMovingChanged() { //when flick/move started, and hover is on, clean hove state if (flickable.moving && tabletButton.state.indexOf("hover") !== -1) { tabletButton.state = (tabletButton.isActive) ? "active state" : "base state"; diff --git a/interface/resources/qml/hifi/tablet/TabletRoot.qml b/interface/resources/qml/hifi/tablet/TabletRoot.qml index 2fa08428ae..5e90696adc 100644 --- a/interface/resources/qml/hifi/tablet/TabletRoot.qml +++ b/interface/resources/qml/hifi/tablet/TabletRoot.qml @@ -199,7 +199,7 @@ Rectangle { Connections { id: eventBridgeConnection target: eventBridge - onWebEventReceived: { + function onWebEventReceived(message) { if (typeof message === "string" && message.slice(0, 17) === "CLARA.IO DOWNLOAD") { ApplicationInterface.addAssetToWorldFromURL(message.slice(18)); } diff --git a/interface/resources/qml/hifi/tablet/WindowRoot.qml b/interface/resources/qml/hifi/tablet/WindowRoot.qml index d888375db2..dcdc711936 100644 --- a/interface/resources/qml/hifi/tablet/WindowRoot.qml +++ b/interface/resources/qml/hifi/tablet/WindowRoot.qml @@ -117,7 +117,7 @@ Windows.ScrollingWindow { Connections { id: eventBridgeConnection target: eventBridge - onWebEventReceived: { + function onWebEventReceived(message) { if (typeof message === "string" && message.slice(0, 17) === "CLARA.IO DOWNLOAD") { ApplicationInterface.addAssetToWorldFromURL(message.slice(18)); } diff --git a/interface/resources/qml/hifi/tablet/tabletWindows/TabletFileDialog.qml b/interface/resources/qml/hifi/tablet/tabletWindows/TabletFileDialog.qml index 36a37134bf..91dc6fe568 100644 --- a/interface/resources/qml/hifi/tablet/tabletWindows/TabletFileDialog.qml +++ b/interface/resources/qml/hifi/tablet/tabletWindows/TabletFileDialog.qml @@ -223,8 +223,8 @@ Rectangle { readonly property string currentSelectionPath: helper.urlToPath(currentSelectionUrl); property bool currentSelectionIsFolder; property var backStack: [] - property var tableViewConnection: Connections { target: fileTableView; onCurrentRowChanged: d.update(); } - property var modelConnection: Connections { target: fileTableModel; onFolderChanged: d.update(); } + property var tableViewConnection: Connections { target: fileTableView; function onCurrentRowChanged() { d.update(); } } + property var modelConnection: Connections { target: fileTableModel; function onFolderChanged() { d.update(); } } property var homeDestination: helper.home(); function capitalizeDrive(path) { diff --git a/interface/resources/qml/hifi/toolbars/Toolbar.qml b/interface/resources/qml/hifi/toolbars/Toolbar.qml index b32d9c7428..56028d71f0 100644 --- a/interface/resources/qml/hifi/toolbars/Toolbar.qml +++ b/interface/resources/qml/hifi/toolbars/Toolbar.qml @@ -53,7 +53,9 @@ Window { Connections { target: proxy; - onPropertiesChanged: updateProperties(); + function onPropertiesChanged() { + updateProperties(); + } } function updateProperties() { diff --git a/interface/resources/qml/windows/Decoration.qml b/interface/resources/qml/windows/Decoration.qml index efaea6be8a..1ba7ad125d 100644 --- a/interface/resources/qml/windows/Decoration.qml +++ b/interface/resources/qml/windows/Decoration.qml @@ -68,18 +68,18 @@ Rectangle { } Connections { target: window - onMouseEntered: { + function onMouseEntered() { if (desktop.hmdHandMouseActive) { root.inflateDecorations() } } - onMouseExited: { + function onMouseExited() { root.deflateDecorations(); } } Connections { target: desktop - onHmdHandMouseActiveChanged: { + function onHmdHandMouseActiveChanged() { if (desktop.hmdHandMouseActive) { if (decorationMouseArea.containsMouse) { root.inflateDecorations(); diff --git a/interface/resources/qml/windows/Window.qml b/interface/resources/qml/windows/Window.qml index 9f180af55d..77cb35ceba 100644 --- a/interface/resources/qml/windows/Window.qml +++ b/interface/resources/qml/windows/Window.qml @@ -269,7 +269,7 @@ Fadable { } // When the desktop pinned state changes, automatically handle the current windows - Connections { target: desktop; onPinnedChanged: d.updateVisibility() } + Connections { target: desktop; function onPinnedChanged() { d.updateVisibility(); } } function raise() { diff --git a/scripts/communityScripts/chat/FloofChat.qml b/scripts/communityScripts/chat/FloofChat.qml index 8d96bf7e42..8d11122292 100644 --- a/scripts/communityScripts/chat/FloofChat.qml +++ b/scripts/communityScripts/chat/FloofChat.qml @@ -144,8 +144,9 @@ Rectangle { Connections { target: button - onClicked: + function onClicked() { sendMessage(JSON.stringify({type:"CMD",cmd:"Clicked"})); + } } } diff --git a/scripts/simplifiedUI/simplifiedEmote/ui/qml/SimplifiedEmoteIndicator.qml b/scripts/simplifiedUI/simplifiedEmote/ui/qml/SimplifiedEmoteIndicator.qml index bbd1d4d735..efc14ce901 100644 --- a/scripts/simplifiedUI/simplifiedEmote/ui/qml/SimplifiedEmoteIndicator.qml +++ b/scripts/simplifiedUI/simplifiedEmote/ui/qml/SimplifiedEmoteIndicator.qml @@ -53,7 +53,7 @@ Rectangle { Connections { target: Settings - onValueChanged: { + function onValueChanged(setting, value) { if (setting === "simplifiedUI/allowEmoteDrawerExpansion") { root.allowEmoteDrawerExpansion = value; }