From 6d5f64529959a3e0596244d4f9b2beaeefc3fb05 Mon Sep 17 00:00:00 2001 From: David Rowe Date: Mon, 8 Sep 2014 15:57:20 -0700 Subject: [PATCH 01/29] Limit avatar head and body models in preferences to FST files (or blank) --- interface/src/ui/PreferencesDialog.cpp | 30 +++++++++++++++++--------- 1 file changed, 20 insertions(+), 10 deletions(-) diff --git a/interface/src/ui/PreferencesDialog.cpp b/interface/src/ui/PreferencesDialog.cpp index 47cb9bad88..0da68a2cfe 100644 --- a/interface/src/ui/PreferencesDialog.cpp +++ b/interface/src/ui/PreferencesDialog.cpp @@ -165,19 +165,29 @@ void PreferencesDialog::savePreferences() { } QUrl faceModelURL(ui.faceURLEdit->text()); - if (faceModelURL.toString() != _faceURLString) { - // change the faceModelURL in the profile, it will also update this user's BlendFace - myAvatar->setFaceModelURL(faceModelURL); - UserActivityLogger::getInstance().changedModel("head", faceModelURL.toString()); - shouldDispatchIdentityPacket = true; + QString faceModelURLString = faceModelURL.toString(); + if (faceModelURLString != _faceURLString) { + if (faceModelURLString.isEmpty() || faceModelURLString.toLower().endsWith(".fst")) { + // change the faceModelURL in the profile, it will also update this user's BlendFace + myAvatar->setFaceModelURL(faceModelURL); + UserActivityLogger::getInstance().changedModel("head", faceModelURLString); + shouldDispatchIdentityPacket = true; + } else { + qDebug() << "ERROR: Head model not FST or blank - " << faceModelURLString; + } } QUrl skeletonModelURL(ui.skeletonURLEdit->text()); - if (skeletonModelURL.toString() != _skeletonURLString) { - // change the skeletonModelURL in the profile, it will also update this user's Body - myAvatar->setSkeletonModelURL(skeletonModelURL); - UserActivityLogger::getInstance().changedModel("skeleton", skeletonModelURL.toString()); - shouldDispatchIdentityPacket = true; + QString skeletonModelURLString = skeletonModelURL.toString(); + if (skeletonModelURLString != _skeletonURLString) { + if (skeletonModelURLString.isEmpty() || skeletonModelURLString.toLower().endsWith(".fst")) { + // change the skeletonModelURL in the profile, it will also update this user's Body + myAvatar->setSkeletonModelURL(skeletonModelURL); + UserActivityLogger::getInstance().changedModel("skeleton", skeletonModelURLString); + shouldDispatchIdentityPacket = true; + } else { + qDebug() << "ERROR: Skeleton model not FST or blank - " << skeletonModelURLString; + } } if (shouldDispatchIdentityPacket) { From 2fde67be724babf83f085b0e444e0e4f744825e0 Mon Sep 17 00:00:00 2001 From: Andrzej Kapolka Date: Wed, 10 Sep 2014 12:40:03 -0700 Subject: [PATCH 02/29] Fix for deferred lighting with 3DTV (/Oculus, although I haven't tested that yet). --- interface/src/MetavoxelSystem.cpp | 22 +++++++++++++++++----- 1 file changed, 17 insertions(+), 5 deletions(-) diff --git a/interface/src/MetavoxelSystem.cpp b/interface/src/MetavoxelSystem.cpp index 892efe7211..b84b6f97d4 100644 --- a/interface/src/MetavoxelSystem.cpp +++ b/interface/src/MetavoxelSystem.cpp @@ -181,6 +181,15 @@ void MetavoxelSystem::render() { glActiveTexture(GL_TEXTURE1); glBindTexture(GL_TEXTURE_2D, Application::getInstance()->getTextureCache()->getPrimaryNormalTextureID()); + // get the viewport side (left, right, both) + int viewport[4]; + glGetIntegerv(GL_VIEWPORT, viewport); + const int VIEWPORT_X_INDEX = 0; + const int VIEWPORT_WIDTH_INDEX = 2; + QSize widgetSize = Application::getInstance()->getGLWidget()->getDeviceSize(); + float sMin = viewport[VIEWPORT_X_INDEX] / (float)widgetSize.width(); + float sWidth = viewport[VIEWPORT_WIDTH_INDEX] / (float)widgetSize.width(); + if (Menu::getInstance()->getShadowsEnabled()) { glActiveTexture(GL_TEXTURE2); glBindTexture(GL_TEXTURE_2D, Application::getInstance()->getTextureCache()->getPrimaryDepthTextureID()); @@ -210,10 +219,13 @@ void MetavoxelSystem::render() { program->setUniformValue(locations->nearLocation, nearVal); program->setUniformValue(locations->depthScale, (farVal - nearVal) / farVal); float nearScale = -1.0f / nearVal; - program->setUniformValue(locations->depthTexCoordOffset, left * nearScale, bottom * nearScale); - program->setUniformValue(locations->depthTexCoordScale, (right - left) * nearScale, (top - bottom) * nearScale); + float sScale = 1.0f / sWidth; + float depthTexCoordScaleS = (right - left) * nearScale * sScale; + program->setUniformValue(locations->depthTexCoordOffset, left * nearScale - sMin * depthTexCoordScaleS, + bottom * nearScale); + program->setUniformValue(locations->depthTexCoordScale, depthTexCoordScaleS, (top - bottom) * nearScale); - renderFullscreenQuad(); + renderFullscreenQuad(sMin, sMin + sWidth); program->release(); @@ -226,7 +238,7 @@ void MetavoxelSystem::render() { } else { _directionalLight.bind(); - renderFullscreenQuad(); + renderFullscreenQuad(sMin, sMin + sWidth); _directionalLight.release(); } @@ -245,7 +257,7 @@ void MetavoxelSystem::render() { glColor4f(1.0f, 1.0f, 1.0f, 1.0f); - renderFullscreenQuad(); + renderFullscreenQuad(sMin, sMin + sWidth); glBindTexture(GL_TEXTURE_2D, 0); glDisable(GL_TEXTURE_2D); From c5ad603321e5fda4e09d2bdd7c8be9c66216a80b Mon Sep 17 00:00:00 2001 From: Andrzej Kapolka Date: Wed, 10 Sep 2014 12:47:46 -0700 Subject: [PATCH 03/29] Fix for glow disabled in 3D TV mode. --- interface/src/devices/TV3DManager.cpp | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/interface/src/devices/TV3DManager.cpp b/interface/src/devices/TV3DManager.cpp index 2ce78b7ac1..005f7133f0 100644 --- a/interface/src/devices/TV3DManager.cpp +++ b/interface/src/devices/TV3DManager.cpp @@ -93,8 +93,6 @@ void TV3DManager::display(Camera& whichCamera) { int portalW = Application::getInstance()->getGLWidget()->getDeviceWidth() / 2; int portalH = Application::getInstance()->getGLWidget()->getDeviceHeight(); - const bool glowEnabled = Menu::getInstance()->isOptionChecked(MenuOption::EnableGlowEffect); - ApplicationOverlay& applicationOverlay = Application::getInstance()->getApplicationOverlay(); // We only need to render the overlays to a texture once, then we just render the texture as a quad @@ -102,9 +100,7 @@ void TV3DManager::display(Camera& whichCamera) { applicationOverlay.renderOverlay(true); const bool displayOverlays = Menu::getInstance()->isOptionChecked(MenuOption::UserInterface); - if (glowEnabled) { - Application::getInstance()->getGlowEffect()->prepare(); - } + Application::getInstance()->getGlowEffect()->prepare(); glClear(GL_COLOR_BUFFER_BIT | GL_DEPTH_BUFFER_BIT); @@ -168,7 +164,5 @@ void TV3DManager::display(Camera& whichCamera) { glViewport(0, 0, Application::getInstance()->getGLWidget()->getDeviceWidth(), Application::getInstance()->getGLWidget()->getDeviceHeight()); - if (glowEnabled) { - Application::getInstance()->getGlowEffect()->render(); - } + Application::getInstance()->getGlowEffect()->render(); } From 2cba7b37bf0688ffa391c8554bcb33615cb21698 Mon Sep 17 00:00:00 2001 From: Andrzej Kapolka Date: Wed, 10 Sep 2014 13:51:14 -0700 Subject: [PATCH 04/29] Attempting to fix 3DTV/Oculus deferred lighting/ambient occlusion. --- interface/src/Application.cpp | 7 +++++++ interface/src/devices/OculusManager.cpp | 17 +++++++++++++++++ interface/src/devices/OculusManager.h | 4 ++++ interface/src/devices/TV3DManager.cpp | 16 +++++++++++++++- interface/src/devices/TV3DManager.h | 5 +++++ 5 files changed, 48 insertions(+), 1 deletion(-) diff --git a/interface/src/Application.cpp b/interface/src/Application.cpp index 7c7c455d1d..f781c9765d 100644 --- a/interface/src/Application.cpp +++ b/interface/src/Application.cpp @@ -2971,7 +2971,14 @@ void Application::getProjectionMatrix(glm::dmat4* projectionMatrix) { void Application::computeOffAxisFrustum(float& left, float& right, float& bottom, float& top, float& nearVal, float& farVal, glm::vec4& nearClipPlane, glm::vec4& farClipPlane) const { + // allow 3DTV/Oculus to override parameters from camera _viewFrustum.computeOffAxisFrustum(left, right, bottom, top, nearVal, farVal, nearClipPlane, farClipPlane); + if (OculusManager::isConnected()) { + OculusManager::overrideOffAxisFrustum(left, right, bottom, top, nearVal, farVal, nearClipPlane, farClipPlane); + + } else if (TV3DManager::isConnected()) { + TV3DManager::overrideOffAxisFrustum(left, right, bottom, top, nearVal, farVal, nearClipPlane, farClipPlane); + } } glm::vec2 Application::getScaledScreenPoint(glm::vec2 projectedPoint) { diff --git a/interface/src/devices/OculusManager.cpp b/interface/src/devices/OculusManager.cpp index bc6dc842ce..e46f2f3182 100644 --- a/interface/src/devices/OculusManager.cpp +++ b/interface/src/devices/OculusManager.cpp @@ -53,6 +53,7 @@ unsigned int OculusManager::_frameIndex = 0; bool OculusManager::_frameTimingActive = false; bool OculusManager::_programInitialized = false; Camera* OculusManager::_camera = NULL; +int OculusManager::_activeEyeIndex = -1; #endif @@ -330,6 +331,8 @@ void OculusManager::display(const glm::quat &bodyOrientation, const glm::vec3 &p //Render each eye into an fbo for (int eyeIndex = 0; eyeIndex < ovrEye_Count; eyeIndex++) { + _activeEyeIndex = eyeIndex; + #if defined(__APPLE__) || defined(_WIN32) ovrEyeType eye = _ovrHmd->EyeRenderOrder[eyeIndex]; #else @@ -363,6 +366,7 @@ void OculusManager::display(const glm::quat &bodyOrientation, const glm::vec3 &p Application::getInstance()->displaySide(*_camera); applicationOverlay.displayOverlayTextureOculus(*_camera); + _activeEyeIndex = -1; } //Wait till time-warp to reduce latency @@ -528,3 +532,16 @@ QSize OculusManager::getRenderTargetSize() { return QSize(100, 100); #endif } + +void OculusManager::overrideOffAxisFrustum(float& left, float& right, float& bottom, float& top, float& nearVal, + float& farVal, glm::vec4& nearClipPlane, glm::vec4& farClipPlane) { +#ifdef HAVE_LIBOVR + if (_activeEyeIndex != -1) { + float extent = nearVal * glm::tan(_eyeRenderDesc[_activeEyeIndex].Fov / 2.0f); + right = extent; + left = -extent; + top = extent; + bottom = -extent; + } +#endif +} diff --git a/interface/src/devices/OculusManager.h b/interface/src/devices/OculusManager.h index 3959ea1ab7..d8e55647b4 100644 --- a/interface/src/devices/OculusManager.h +++ b/interface/src/devices/OculusManager.h @@ -43,6 +43,9 @@ public: static glm::vec3 getRelativePosition(); static QSize getRenderTargetSize(); + static void overrideOffAxisFrustum(float& left, float& right, float& bottom, float& top, float& nearVal, + float& farVal, glm::vec4& nearClipPlane, glm::vec4& farClipPlane); + private: #ifdef HAVE_LIBOVR static void generateDistortionMesh(); @@ -92,6 +95,7 @@ private: static bool _frameTimingActive; static bool _programInitialized; static Camera* _camera; + static int _activeEyeIndex; #endif }; diff --git a/interface/src/devices/TV3DManager.cpp b/interface/src/devices/TV3DManager.cpp index 005f7133f0..e8644c00d0 100644 --- a/interface/src/devices/TV3DManager.cpp +++ b/interface/src/devices/TV3DManager.cpp @@ -25,6 +25,7 @@ int TV3DManager::_screenHeight = 1; double TV3DManager::_aspect = 1.0; eyeFrustum TV3DManager::_leftEye; eyeFrustum TV3DManager::_rightEye; +eyeFrustum* TV3DManager::_activeEye = NULL; bool TV3DManager::isConnected() { @@ -111,7 +112,7 @@ void TV3DManager::display(Camera& whichCamera) { glPushMatrix(); { - + _activeEye = &_leftEye; glMatrixMode(GL_PROJECTION); glLoadIdentity(); // reset projection matrix glFrustum(_leftEye.left, _leftEye.right, _leftEye.bottom, _leftEye.top, nearZ, farZ); // set left view frustum @@ -128,6 +129,7 @@ void TV3DManager::display(Camera& whichCamera) { if (displayOverlays) { applicationOverlay.displayOverlayTexture3DTV(whichCamera, _aspect, fov); } + _activeEye = NULL; } glPopMatrix(); glDisable(GL_SCISSOR_TEST); @@ -140,6 +142,7 @@ void TV3DManager::display(Camera& whichCamera) { glScissor(portalX, portalY, portalW, portalH); glPushMatrix(); { + _activeEye = &_rightEye; glMatrixMode(GL_PROJECTION); glLoadIdentity(); // reset projection matrix glFrustum(_rightEye.left, _rightEye.right, _rightEye.bottom, _rightEye.top, nearZ, farZ); // set left view frustum @@ -156,6 +159,7 @@ void TV3DManager::display(Camera& whichCamera) { if (displayOverlays) { applicationOverlay.displayOverlayTexture3DTV(whichCamera, _aspect, fov); } + _activeEye = NULL; } glPopMatrix(); glDisable(GL_SCISSOR_TEST); @@ -166,3 +170,13 @@ void TV3DManager::display(Camera& whichCamera) { Application::getInstance()->getGlowEffect()->render(); } + +void TV3DManager::overrideOffAxisFrustum(float& left, float& right, float& bottom, float& top, float& nearVal, + float& farVal, glm::vec4& nearClipPlane, glm::vec4& farClipPlane) { + if (_activeEye) { + left = _activeEye->left; + right = _activeEye->right; + bottom = _activeEye->bottom; + top = _activeEye->top; + } +} diff --git a/interface/src/devices/TV3DManager.h b/interface/src/devices/TV3DManager.h index 91a78e9bce..2b2b9e0aa1 100644 --- a/interface/src/devices/TV3DManager.h +++ b/interface/src/devices/TV3DManager.h @@ -14,6 +14,8 @@ #include +#include + class Camera; struct eyeFrustum { @@ -32,6 +34,8 @@ public: static bool isConnected(); static void configureCamera(Camera& camera, int screenWidth, int screenHeight); static void display(Camera& whichCamera); + static void overrideOffAxisFrustum(float& left, float& right, float& bottom, float& top, float& nearVal, + float& farVal, glm::vec4& nearClipPlane, glm::vec4& farClipPlane); private: static void setFrustum(Camera& whichCamera); static int _screenWidth; @@ -39,6 +43,7 @@ private: static double _aspect; static eyeFrustum _leftEye; static eyeFrustum _rightEye; + static eyeFrustum* _activeEye; }; #endif // hifi_TV3DManager_h From 600f36aa64769ccf40d7912a3b450878430d925d Mon Sep 17 00:00:00 2001 From: Andrzej Kapolka Date: Wed, 10 Sep 2014 14:14:02 -0700 Subject: [PATCH 05/29] Fix for Oculus API. --- interface/src/devices/OculusManager.cpp | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/interface/src/devices/OculusManager.cpp b/interface/src/devices/OculusManager.cpp index e46f2f3182..5e4daa3d22 100644 --- a/interface/src/devices/OculusManager.cpp +++ b/interface/src/devices/OculusManager.cpp @@ -537,11 +537,11 @@ void OculusManager::overrideOffAxisFrustum(float& left, float& right, float& bot float& farVal, glm::vec4& nearClipPlane, glm::vec4& farClipPlane) { #ifdef HAVE_LIBOVR if (_activeEyeIndex != -1) { - float extent = nearVal * glm::tan(_eyeRenderDesc[_activeEyeIndex].Fov / 2.0f); - right = extent; - left = -extent; - top = extent; - bottom = -extent; + const ovrFovPort& port = _eyeFov[_activeEyeIndex]; + right = nearVal * port.RightTan; + left = -nearVal * port.LeftTan; + top = nearVal * port.TopTan; + bottom = -nearVal * port.BottomTan; } #endif } From b328304da40de24b3990b6e24338d77018e1ff2b Mon Sep 17 00:00:00 2001 From: Andrzej Kapolka Date: Wed, 10 Sep 2014 14:15:00 -0700 Subject: [PATCH 06/29] Up/down, not top/bottom. --- interface/src/devices/OculusManager.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/interface/src/devices/OculusManager.cpp b/interface/src/devices/OculusManager.cpp index 5e4daa3d22..c47ff2c38b 100644 --- a/interface/src/devices/OculusManager.cpp +++ b/interface/src/devices/OculusManager.cpp @@ -540,8 +540,8 @@ void OculusManager::overrideOffAxisFrustum(float& left, float& right, float& bot const ovrFovPort& port = _eyeFov[_activeEyeIndex]; right = nearVal * port.RightTan; left = -nearVal * port.LeftTan; - top = nearVal * port.TopTan; - bottom = -nearVal * port.BottomTan; + top = nearVal * port.UpTan; + bottom = -nearVal * port.DownTan; } #endif } From 34ccc2ab7bb1d3c3f3c1187388368344f08470af Mon Sep 17 00:00:00 2001 From: Andrzej Kapolka Date: Wed, 10 Sep 2014 15:13:07 -0700 Subject: [PATCH 07/29] Use the FBO dimensions, which may differ from the widget dimensions (as with the Oculus). --- interface/src/MetavoxelSystem.cpp | 5 ++--- interface/src/renderer/AmbientOcclusionEffect.cpp | 10 +++++----- 2 files changed, 7 insertions(+), 8 deletions(-) diff --git a/interface/src/MetavoxelSystem.cpp b/interface/src/MetavoxelSystem.cpp index b84b6f97d4..2d27398f4b 100644 --- a/interface/src/MetavoxelSystem.cpp +++ b/interface/src/MetavoxelSystem.cpp @@ -186,9 +186,8 @@ void MetavoxelSystem::render() { glGetIntegerv(GL_VIEWPORT, viewport); const int VIEWPORT_X_INDEX = 0; const int VIEWPORT_WIDTH_INDEX = 2; - QSize widgetSize = Application::getInstance()->getGLWidget()->getDeviceSize(); - float sMin = viewport[VIEWPORT_X_INDEX] / (float)widgetSize.width(); - float sWidth = viewport[VIEWPORT_WIDTH_INDEX] / (float)widgetSize.width(); + float sMin = viewport[VIEWPORT_X_INDEX] / (float)primaryFBO->width(); + float sWidth = viewport[VIEWPORT_WIDTH_INDEX] / (float)primaryFBO->width(); if (Menu::getInstance()->getShadowsEnabled()) { glActiveTexture(GL_TEXTURE2); diff --git a/interface/src/renderer/AmbientOcclusionEffect.cpp b/interface/src/renderer/AmbientOcclusionEffect.cpp index a4977e5e01..f1c1538800 100644 --- a/interface/src/renderer/AmbientOcclusionEffect.cpp +++ b/interface/src/renderer/AmbientOcclusionEffect.cpp @@ -116,9 +116,9 @@ void AmbientOcclusionEffect::render() { glGetIntegerv(GL_VIEWPORT, viewport); const int VIEWPORT_X_INDEX = 0; const int VIEWPORT_WIDTH_INDEX = 2; - QSize widgetSize = Application::getInstance()->getGLWidget()->getDeviceSize(); - float sMin = viewport[VIEWPORT_X_INDEX] / (float)widgetSize.width(); - float sWidth = viewport[VIEWPORT_WIDTH_INDEX] / (float)widgetSize.width(); + QOpenGLFramebufferObject* primaryFBO = Application::getInstance()->getTextureCache()->getPrimaryFramebufferObject(); + float sMin = viewport[VIEWPORT_X_INDEX] / (float)primaryFBO->width(); + float sWidth = viewport[VIEWPORT_WIDTH_INDEX] / (float)primaryFBO->width(); _occlusionProgram->bind(); _occlusionProgram->setUniformValue(_nearLocation, nearVal); @@ -126,7 +126,7 @@ void AmbientOcclusionEffect::render() { _occlusionProgram->setUniformValue(_leftBottomLocation, left, bottom); _occlusionProgram->setUniformValue(_rightTopLocation, right, top); _occlusionProgram->setUniformValue(_noiseScaleLocation, viewport[VIEWPORT_WIDTH_INDEX] / (float)ROTATION_WIDTH, - widgetSize.height() / (float)ROTATION_HEIGHT); + primaryFBO->height() / (float)ROTATION_HEIGHT); _occlusionProgram->setUniformValue(_texCoordOffsetLocation, sMin, 0.0f); _occlusionProgram->setUniformValue(_texCoordScaleLocation, sWidth, 1.0f); @@ -148,7 +148,7 @@ void AmbientOcclusionEffect::render() { glBindTexture(GL_TEXTURE_2D, freeFBO->texture()); _blurProgram->bind(); - _blurProgram->setUniformValue(_blurScaleLocation, 1.0f / widgetSize.width(), 1.0f / widgetSize.height()); + _blurProgram->setUniformValue(_blurScaleLocation, 1.0f / primaryFBO->width(), 1.0f / primaryFBO->height()); renderFullscreenQuad(sMin, sMin + sWidth); From fe249ef3486cf781a357d12d593952918893d3da Mon Sep 17 00:00:00 2001 From: Andrzej Kapolka Date: Wed, 10 Sep 2014 15:51:10 -0700 Subject: [PATCH 08/29] Make sure the frustum that we use for culling contains the current camera information. --- interface/src/Application.cpp | 3 +++ interface/src/Application.h | 2 ++ interface/src/MetavoxelSystem.cpp | 12 ++++++------ 3 files changed, 11 insertions(+), 6 deletions(-) diff --git a/interface/src/Application.cpp b/interface/src/Application.cpp index b5826fbcda..273b66e4dc 100644 --- a/interface/src/Application.cpp +++ b/interface/src/Application.cpp @@ -2724,6 +2724,9 @@ void Application::displaySide(Camera& whichCamera, bool selfAvatarOnly) { PerformanceWarning warn(Menu::getInstance()->isOptionChecked(MenuOption::PipelineWarnings), "Application::displaySide()"); // transform by eye offset + // load the view frustum + loadViewFrustum(whichCamera, _displayViewFrustum); + // flip x if in mirror mode (also requires reversing winding order for backface culling) if (whichCamera.getMode() == CAMERA_MODE_MIRROR) { glScalef(-1.0f, 1.0f, 1.0f); diff --git a/interface/src/Application.h b/interface/src/Application.h index f48d88d7a4..fbcc67cf80 100644 --- a/interface/src/Application.h +++ b/interface/src/Application.h @@ -192,6 +192,7 @@ public: const AudioReflector* getAudioReflector() const { return &_audioReflector; } Camera* getCamera() { return &_myCamera; } ViewFrustum* getViewFrustum() { return &_viewFrustum; } + ViewFrustum* getDisplayViewFrustum() { return &_displayViewFrustum; } ViewFrustum* getShadowViewFrustum() { return &_shadowViewFrustum; } VoxelImporter* getVoxelImporter() { return &_voxelImporter; } VoxelSystem* getVoxels() { return &_voxels; } @@ -486,6 +487,7 @@ private: ViewFrustum _viewFrustum; // current state of view frustum, perspective, orientation, etc. ViewFrustum _lastQueriedViewFrustum; /// last view frustum used to query octree servers (voxels, particles) + ViewFrustum _displayViewFrustum; ViewFrustum _shadowViewFrustum; quint64 _lastQueriedTime; diff --git a/interface/src/MetavoxelSystem.cpp b/interface/src/MetavoxelSystem.cpp index 2d27398f4b..903e443cda 100644 --- a/interface/src/MetavoxelSystem.cpp +++ b/interface/src/MetavoxelSystem.cpp @@ -133,7 +133,7 @@ const GLenum COLOR_NORMAL_DRAW_BUFFERS[] = { GL_COLOR_ATTACHMENT0, GL_COLOR_ATTA void MetavoxelSystem::render() { // update the frustum - ViewFrustum* viewFrustum = Application::getInstance()->getViewFrustum(); + ViewFrustum* viewFrustum = Application::getInstance()->getDisplayViewFrustum(); _frustum.set(viewFrustum->getFarTopLeft(), viewFrustum->getFarTopRight(), viewFrustum->getFarBottomLeft(), viewFrustum->getFarBottomRight(), viewFrustum->getNearTopLeft(), viewFrustum->getNearTopRight(), viewFrustum->getNearBottomLeft(), viewFrustum->getNearBottomRight()); @@ -2187,7 +2187,7 @@ private: SpannerRenderVisitor::SpannerRenderVisitor(const MetavoxelLOD& lod) : SpannerVisitor(QVector() << AttributeRegistry::getInstance()->getSpannersAttribute(), QVector(), QVector(), QVector(), - lod, encodeOrder(Application::getInstance()->getViewFrustum()->getDirection())), + lod, encodeOrder(Application::getInstance()->getDisplayViewFrustum()->getDirection())), _containmentDepth(INT_MAX) { } @@ -2223,7 +2223,7 @@ private: BufferRenderVisitor::BufferRenderVisitor(const AttributePointer& attribute) : MetavoxelVisitor(QVector() << attribute), - _order(encodeOrder(Application::getInstance()->getViewFrustum()->getDirection())), + _order(encodeOrder(Application::getInstance()->getDisplayViewFrustum()->getDirection())), _containmentDepth(INT_MAX) { } @@ -2257,12 +2257,12 @@ void DefaultMetavoxelRendererImplementation::render(MetavoxelData& data, Metavox float viewportWidth = viewport[VIEWPORT_WIDTH_INDEX]; float viewportHeight = viewport[VIEWPORT_HEIGHT_INDEX]; float viewportDiagonal = sqrtf(viewportWidth * viewportWidth + viewportHeight * viewportHeight); - float worldDiagonal = glm::distance(Application::getInstance()->getViewFrustum()->getNearBottomLeft(), - Application::getInstance()->getViewFrustum()->getNearTopRight()); + float worldDiagonal = glm::distance(Application::getInstance()->getDisplayViewFrustum()->getNearBottomLeft(), + Application::getInstance()->getDisplayViewFrustum()->getNearTopRight()); _pointProgram.bind(); _pointProgram.setUniformValue(_pointScaleLocation, viewportDiagonal * - Application::getInstance()->getViewFrustum()->getNearClip() / worldDiagonal); + Application::getInstance()->getDisplayViewFrustum()->getNearClip() / worldDiagonal); glEnableClientState(GL_VERTEX_ARRAY); glEnableClientState(GL_COLOR_ARRAY); From ca4d1375f53c80da49d2cdeee37b43e701c99353 Mon Sep 17 00:00:00 2001 From: Craig Hansen-Sturm Date: Wed, 10 Sep 2014 16:21:06 -0700 Subject: [PATCH 09/29] fix for recent stereo/mono and echo local server regression --- interface/src/Audio.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/interface/src/Audio.cpp b/interface/src/Audio.cpp index 9086312bac..9427ec0525 100644 --- a/interface/src/Audio.cpp +++ b/interface/src/Audio.cpp @@ -644,6 +644,8 @@ void Audio::handleAudioInput() { _dcOffset = DC_OFFSET_AVERAGING * _dcOffset + (1.0f - DC_OFFSET_AVERAGING) * measuredDcOffset; } + _lastInputLoudness = fabs(loudness / NETWORK_BUFFER_LENGTH_SAMPLES_PER_CHANNEL); + // If Noise Gate is enabled, check and turn the gate on and off if (!_audioSourceInjectEnabled && _noiseGateEnabled) { float averageOfAllSampleFrames = 0.0f; From 590c8042f82eb28bc80c7c44b8599ef0eeb04fdf Mon Sep 17 00:00:00 2001 From: Andrzej Kapolka Date: Wed, 10 Sep 2014 16:36:32 -0700 Subject: [PATCH 10/29] Attempting to fix a bug in the Oculus overlay. --- interface/src/ui/ApplicationOverlay.cpp | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/interface/src/ui/ApplicationOverlay.cpp b/interface/src/ui/ApplicationOverlay.cpp index 20ed1d9d58..b7c7c15e13 100644 --- a/interface/src/ui/ApplicationOverlay.cpp +++ b/interface/src/ui/ApplicationOverlay.cpp @@ -803,24 +803,27 @@ void ApplicationOverlay::renderPointersOculus(const glm::vec3& eyePos) { float newVTop = 1.0 - (mouseY - reticleSize) / widgetHeight; // Project our position onto the hemisphere using the UV coordinates - float lX = sin((newULeft - 0.5f) * _textureFov); - float rX = sin((newURight - 0.5f) * _textureFov); - float bY = sin((newVBottom - 0.5f) * _textureFov); - float tY = sin((newVTop - 0.5f) * _textureFov); + float radius = _oculusuiRadius * application->getAvatar()->getScale(); + float radius2 = radius * radius; + + float lX = radius * sin((newULeft - 0.5f) * _textureFov); + float rX = radius * sin((newURight - 0.5f) * _textureFov); + float bY = radius * sin((newVBottom - 0.5f) * _textureFov); + float tY = radius * sin((newVTop - 0.5f) * _textureFov); float dist; //Bottom Left dist = sqrt(lX * lX + bY * bY); - float blZ = sqrt(1.0f - dist * dist); + float blZ = sqrt(radius2 - dist * dist); //Top Left dist = sqrt(lX * lX + tY * tY); - float tlZ = sqrt(1.0f - dist * dist); + float tlZ = sqrt(radius2 - dist * dist); //Bottom Right dist = sqrt(rX * rX + bY * bY); - float brZ = sqrt(1.0f - dist * dist); + float brZ = sqrt(radius2 - dist * dist); //Top Right dist = sqrt(rX * rX + tY * tY); - float trZ = sqrt(1.0f - dist * dist); + float trZ = sqrt(radius2 - dist * dist); glBegin(GL_QUADS); From 18975aef57250eb2822bf474cc8ded1334ba40e6 Mon Sep 17 00:00:00 2001 From: Craig Hansen-Sturm Date: Wed, 10 Sep 2014 16:48:35 -0700 Subject: [PATCH 11/29] log audio device framing errors, copy as much data as we can, but don't assert --- libraries/audio/src/AudioBuffer.h | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/libraries/audio/src/AudioBuffer.h b/libraries/audio/src/AudioBuffer.h index 2ef39430c1..0c82339dfd 100644 --- a/libraries/audio/src/AudioBuffer.h +++ b/libraries/audio/src/AudioBuffer.h @@ -110,8 +110,16 @@ public: if ( !_frameBuffer || !frames) { return; } - assert(channelCount <= _channelCountMax); - assert(frameCount <= _frameCountMax); + + if (channelCount >_channelCountMax || frameCount >_frameCountMax) { + qDebug() << "Audio framing error: _channelCount=" << _channelCount << "channelCountMax=" << _channelCountMax; + qDebug() << "Audio framing error: _frameCount=" << _frameCount << "frameCountMax=" << _frameCountMax; + + // This condition should never happen; however, we do our best to recover here copying as many frames + // as we have allocated + _channelCount = std::min(_channelCount,_channelCountMax); + _frameCount = std::min(_frameCount,_frameCountMax); + } _frameCount = frameCount; // we allow copying fewer frames than we've allocated _channelCount = channelCount; // we allow copying fewer channels that we've allocated From 146a6526bee8f9b40811aac047204f3f8b779b83 Mon Sep 17 00:00:00 2001 From: Andrzej Kapolka Date: Wed, 10 Sep 2014 17:02:04 -0700 Subject: [PATCH 12/29] Fix for Oculus mouse pointer. --- interface/src/ui/ApplicationOverlay.cpp | 21 +++++++++------------ 1 file changed, 9 insertions(+), 12 deletions(-) diff --git a/interface/src/ui/ApplicationOverlay.cpp b/interface/src/ui/ApplicationOverlay.cpp index b7c7c15e13..df7c2d2289 100644 --- a/interface/src/ui/ApplicationOverlay.cpp +++ b/interface/src/ui/ApplicationOverlay.cpp @@ -414,7 +414,7 @@ void ApplicationOverlay::displayOverlayTextureOculus(Camera& whichCamera) { renderTexturedHemisphere(); - renderPointersOculus(whichCamera.getPosition()); + renderPointersOculus(myAvatar->getHead()->getEyePosition()); glDepthMask(GL_TRUE); glBindTexture(GL_TEXTURE_2D, 0); @@ -803,27 +803,24 @@ void ApplicationOverlay::renderPointersOculus(const glm::vec3& eyePos) { float newVTop = 1.0 - (mouseY - reticleSize) / widgetHeight; // Project our position onto the hemisphere using the UV coordinates - float radius = _oculusuiRadius * application->getAvatar()->getScale(); - float radius2 = radius * radius; - - float lX = radius * sin((newULeft - 0.5f) * _textureFov); - float rX = radius * sin((newURight - 0.5f) * _textureFov); - float bY = radius * sin((newVBottom - 0.5f) * _textureFov); - float tY = radius * sin((newVTop - 0.5f) * _textureFov); + float lX = sin((newULeft - 0.5f) * _textureFov); + float rX = sin((newURight - 0.5f) * _textureFov); + float bY = sin((newVBottom - 0.5f) * _textureFov); + float tY = sin((newVTop - 0.5f) * _textureFov); float dist; //Bottom Left dist = sqrt(lX * lX + bY * bY); - float blZ = sqrt(radius2 - dist * dist); + float blZ = sqrt(1.0f - dist * dist); //Top Left dist = sqrt(lX * lX + tY * tY); - float tlZ = sqrt(radius2 - dist * dist); + float tlZ = sqrt(1.0f - dist * dist); //Bottom Right dist = sqrt(rX * rX + bY * bY); - float brZ = sqrt(radius2 - dist * dist); + float brZ = sqrt(1.0f - dist * dist); //Top Right dist = sqrt(rX * rX + tY * tY); - float trZ = sqrt(radius2 - dist * dist); + float trZ = sqrt(1.0f - dist * dist); glBegin(GL_QUADS); From de8dd4cecc94b541ca9c381b14fd4e1973d364ba Mon Sep 17 00:00:00 2001 From: Andrzej Kapolka Date: Wed, 10 Sep 2014 18:55:36 -0700 Subject: [PATCH 13/29] Share instances of TextRenderer. --- interface/src/Util.cpp | 7 ++-- interface/src/avatar/Avatar.cpp | 5 ++- interface/src/ui/BandwidthMeter.cpp | 14 +++---- interface/src/ui/BandwidthMeter.h | 2 +- interface/src/ui/TextRenderer.cpp | 49 ++++++++++++++++------- interface/src/ui/TextRenderer.h | 21 +++++++--- interface/src/ui/overlays/TextOverlay.cpp | 9 ++--- 7 files changed, 70 insertions(+), 37 deletions(-) diff --git a/interface/src/Util.cpp b/interface/src/Util.cpp index 4dbb015459..b219509ccd 100644 --- a/interface/src/Util.cpp +++ b/interface/src/Util.cpp @@ -181,9 +181,10 @@ const glm::vec3 randVector() { } static TextRenderer* textRenderer(int mono) { - static TextRenderer* monoRenderer = new TextRenderer(MONO_FONT_FAMILY); - static TextRenderer* proportionalRenderer = new TextRenderer(SANS_FONT_FAMILY, -1, -1, false, TextRenderer::SHADOW_EFFECT); - static TextRenderer* inconsolataRenderer = new TextRenderer(INCONSOLATA_FONT_FAMILY, -1, QFont::Bold, false); + static TextRenderer* monoRenderer = TextRenderer::getInstance(MONO_FONT_FAMILY); + static TextRenderer* proportionalRenderer = TextRenderer::getInstance(SANS_FONT_FAMILY, + -1, -1, false, TextRenderer::SHADOW_EFFECT); + static TextRenderer* inconsolataRenderer = TextRenderer::getInstance(INCONSOLATA_FONT_FAMILY, -1, QFont::Bold, false); switch (mono) { case 1: return monoRenderer; diff --git a/interface/src/avatar/Avatar.cpp b/interface/src/avatar/Avatar.cpp index 5c7e89fc37..ba044c9451 100644 --- a/interface/src/avatar/Avatar.cpp +++ b/interface/src/avatar/Avatar.cpp @@ -239,8 +239,9 @@ enum TextRendererType { }; static TextRenderer* textRenderer(TextRendererType type) { - static TextRenderer* chatRenderer = new TextRenderer(SANS_FONT_FAMILY, 24, -1, false, TextRenderer::SHADOW_EFFECT); - static TextRenderer* displayNameRenderer = new TextRenderer(SANS_FONT_FAMILY, 12, -1, false, TextRenderer::NO_EFFECT); + static TextRenderer* chatRenderer = TextRenderer::getInstance(SANS_FONT_FAMILY, 24, -1, + false, TextRenderer::SHADOW_EFFECT); + static TextRenderer* displayNameRenderer = TextRenderer::getInstance(SANS_FONT_FAMILY, 12); switch(type) { case CHAT: diff --git a/interface/src/ui/BandwidthMeter.cpp b/interface/src/ui/BandwidthMeter.cpp index 0f41a1a5cf..327f266106 100644 --- a/interface/src/ui/BandwidthMeter.cpp +++ b/interface/src/ui/BandwidthMeter.cpp @@ -50,7 +50,7 @@ BandwidthMeter::ChannelInfo BandwidthMeter::_CHANNELS[] = { }; BandwidthMeter::BandwidthMeter() : - _textRenderer(INCONSOLATA_FONT_FAMILY, -1, QFont::Bold, false), + _textRenderer(TextRenderer::getInstance(INCONSOLATA_FONT_FAMILY, -1, QFont::Bold, false)), _scaleMaxIndex(INITIAL_SCALE_MAXIMUM_INDEX) { _channels = static_cast( malloc(sizeof(_CHANNELS)) ); @@ -140,7 +140,7 @@ void BandwidthMeter::render(int screenWidth, int screenHeight) { float totalMax = glm::max(totalIn, totalOut); // Get font / caption metrics - QFontMetrics const& fontMetrics = _textRenderer.metrics(); + QFontMetrics const& fontMetrics = _textRenderer->metrics(); int fontDescent = fontMetrics.descent(); int labelWidthIn = fontMetrics.width(CAPTION_IN); int labelWidthOut = fontMetrics.width(CAPTION_OUT); @@ -163,9 +163,9 @@ void BandwidthMeter::render(int screenWidth, int screenHeight) { // Render captions setColorRGBA(COLOR_TEXT); - _textRenderer.draw(barWidth + SPACING_LEFT_CAPTION_UNIT, textYcenteredLine, CAPTION_UNIT); - _textRenderer.draw(-labelWidthIn - SPACING_RIGHT_CAPTION_IN_OUT, textYupperLine, CAPTION_IN); - _textRenderer.draw(-labelWidthOut - SPACING_RIGHT_CAPTION_IN_OUT, textYlowerLine, CAPTION_OUT); + _textRenderer->draw(barWidth + SPACING_LEFT_CAPTION_UNIT, textYcenteredLine, CAPTION_UNIT); + _textRenderer->draw(-labelWidthIn - SPACING_RIGHT_CAPTION_IN_OUT, textYupperLine, CAPTION_IN); + _textRenderer->draw(-labelWidthOut - SPACING_RIGHT_CAPTION_IN_OUT, textYlowerLine, CAPTION_OUT); // Render vertical lines for the frame setColorRGBA(COLOR_FRAME); @@ -229,11 +229,11 @@ void BandwidthMeter::render(int screenWidth, int screenHeight) { char fmtBuf[8]; setColorRGBA(COLOR_TEXT); sprintf(fmtBuf, "%0.1f", totalIn); - _textRenderer.draw(glm::max(xIn - fontMetrics.width(fmtBuf) - PADDING_HORIZ_VALUE, + _textRenderer->draw(glm::max(xIn - fontMetrics.width(fmtBuf) - PADDING_HORIZ_VALUE, PADDING_HORIZ_VALUE), textYupperLine, fmtBuf); sprintf(fmtBuf, "%0.1f", totalOut); - _textRenderer.draw(glm::max(xOut - fontMetrics.width(fmtBuf) - PADDING_HORIZ_VALUE, + _textRenderer->draw(glm::max(xOut - fontMetrics.width(fmtBuf) - PADDING_HORIZ_VALUE, PADDING_HORIZ_VALUE), textYlowerLine, fmtBuf); diff --git a/interface/src/ui/BandwidthMeter.h b/interface/src/ui/BandwidthMeter.h index c6a28a21c3..09353512d1 100644 --- a/interface/src/ui/BandwidthMeter.h +++ b/interface/src/ui/BandwidthMeter.h @@ -78,7 +78,7 @@ private: static ChannelInfo _CHANNELS[]; - TextRenderer _textRenderer; + TextRenderer* _textRenderer; ChannelInfo* _channels; Stream _streams[N_STREAMS]; int _scaleMaxIndex; diff --git a/interface/src/ui/TextRenderer.cpp b/interface/src/ui/TextRenderer.cpp index 4ced8c1f2e..c4f6b328ef 100644 --- a/interface/src/ui/TextRenderer.cpp +++ b/interface/src/ui/TextRenderer.cpp @@ -24,22 +24,23 @@ // the width/height of the cached glyph textures const int IMAGE_SIZE = 256; -Glyph::Glyph(int textureID, const QPoint& location, const QRect& bounds, int width) : - _textureID(textureID), _location(location), _bounds(bounds), _width(width) { +static uint qHash(const TextRenderer::Properties& key, uint seed = 0) { + // can be switched to qHash(key.font, seed) when we require Qt 5.3+ + return qHash(key.font.family(), qHash(key.font.pointSize(), seed)); } -TextRenderer::TextRenderer(const char* family, int pointSize, int weight, bool italic, - EffectType effectType, int effectThickness, QColor color) : - _font(family, pointSize, weight, italic), - _metrics(_font), - _effectType(effectType), - _effectThickness(effectThickness), - _x(IMAGE_SIZE), - _y(IMAGE_SIZE), - _rowHeight(0), - _color(color) { - - _font.setKerning(false); +static bool operator==(const TextRenderer::Properties& p1, const TextRenderer::Properties& p2) { + return p1.font == p2.font && p1.effect == p2.effect && p1.effectThickness == p2.effectThickness && p1.color == p2.color; +} + +TextRenderer* TextRenderer::getInstance(const char* family, int pointSize, int weight, bool italic, + EffectType effect, int effectThickness, const QColor& color) { + Properties properties = { QFont(family, pointSize, weight, italic), effect, effectThickness, color }; + TextRenderer*& instance = _instances[properties]; + if (!instance) { + instance = new TextRenderer(properties); + } + return instance; } TextRenderer::~TextRenderer() { @@ -122,6 +123,19 @@ int TextRenderer::computeWidth(const char* str) return width; } +TextRenderer::TextRenderer(const Properties& properties) : + _font(properties.font), + _metrics(_font), + _effectType(properties.effect), + _effectThickness(properties.effectThickness), + _x(IMAGE_SIZE), + _y(IMAGE_SIZE), + _rowHeight(0), + _color(properties.color) { + + _font.setKerning(false); +} + const Glyph& TextRenderer::getGlyph(char c) { Glyph& glyph = _glyphs[c]; if (glyph.isValid()) { @@ -213,3 +227,10 @@ const Glyph& TextRenderer::getGlyph(char c) { glBindTexture(GL_TEXTURE_2D, 0); return glyph; } + +QHash TextRenderer::_instances; + +Glyph::Glyph(int textureID, const QPoint& location, const QRect& bounds, int width) : + _textureID(textureID), _location(location), _bounds(bounds), _width(width) { +} + diff --git a/interface/src/ui/TextRenderer.h b/interface/src/ui/TextRenderer.h index 2daba79c8f..d3340462d5 100644 --- a/interface/src/ui/TextRenderer.h +++ b/interface/src/ui/TextRenderer.h @@ -33,7 +33,6 @@ const char SOLID_BLOCK_CHAR = 127; // the Inconsolata font family #define INCONSOLATA_FONT_FAMILY "Inconsolata" - class Glyph; class TextRenderer { @@ -41,9 +40,17 @@ public: enum EffectType { NO_EFFECT, SHADOW_EFFECT, OUTLINE_EFFECT }; - TextRenderer(const char* family, int pointSize = -1, int weight = -1, bool italic = false, - EffectType effect = NO_EFFECT, int effectThickness = 1, - QColor color = QColor(255, 255, 255)); + class Properties { + public: + QFont font; + EffectType effect; + int effectThickness; + QColor color; + }; + + static TextRenderer* getInstance(const char* family, int pointSize = -1, int weight = -1, bool italic = false, + EffectType effect = NO_EFFECT, int effectThickness = 1, const QColor& color = QColor(255, 255, 255)); + ~TextRenderer(); const QFontMetrics& metrics() const { return _metrics; } @@ -59,7 +66,9 @@ public: private: - const Glyph& getGlyph (char c); + TextRenderer(const Properties& properties); + + const Glyph& getGlyph(char c); // the font to render QFont _font; @@ -90,6 +99,8 @@ private: // text color QColor _color; + + static QHash _instances; }; class Glyph { diff --git a/interface/src/ui/overlays/TextOverlay.cpp b/interface/src/ui/overlays/TextOverlay.cpp index 691179ec54..bc7cbb2cfa 100644 --- a/interface/src/ui/overlays/TextOverlay.cpp +++ b/interface/src/ui/overlays/TextOverlay.cpp @@ -45,22 +45,21 @@ void TextOverlay::render() { //TextRenderer(const char* family, int pointSize = -1, int weight = -1, bool italic = false, // EffectType effect = NO_EFFECT, int effectThickness = 1); - TextRenderer textRenderer(SANS_FONT_FAMILY, _fontSize, 50, false, TextRenderer::NO_EFFECT, 1, - QColor(_color.red, _color.green, _color.blue)); + TextRenderer* textRenderer = TextRenderer::getInstance(SANS_FONT_FAMILY, _fontSize, 50); const int leftAdjust = -1; // required to make text render relative to left edge of bounds const int topAdjust = -2; // required to make text render relative to top edge of bounds int x = _bounds.left() + _leftMargin + leftAdjust; int y = _bounds.top() + _topMargin + topAdjust; - glColor3f(1.0f, 1.0f, 1.0f); + glColor3f(_color.red / MAX_COLOR, _color.green / MAX_COLOR, _color.blue / MAX_COLOR); QStringList lines = _text.split("\n"); int lineOffset = 0; foreach(QString thisLine, lines) { if (lineOffset == 0) { - lineOffset = textRenderer.calculateHeight(qPrintable(thisLine)); + lineOffset = textRenderer->calculateHeight(qPrintable(thisLine)); } - lineOffset += textRenderer.draw(x, y + lineOffset, qPrintable(thisLine)); + lineOffset += textRenderer->draw(x, y + lineOffset, qPrintable(thisLine)); const int lineGap = 2; lineOffset += lineGap; From 0078b45a8f8b972708a1059f37e601d6ab1fff3b Mon Sep 17 00:00:00 2001 From: Philip Rosedale Date: Wed, 10 Sep 2014 19:00:24 -0700 Subject: [PATCH 14/29] update headMove to have optional concept of a room that we cannot escape, update and rename butterflies script --- examples/butterflies.js | 234 ++++++++++++++++++ examples/headMove.js | 81 +++++- interface/src/Audio.cpp | 2 + .../src/entities/RenderableBoxEntityItem.cpp | 2 +- 4 files changed, 309 insertions(+), 10 deletions(-) create mode 100644 examples/butterflies.js diff --git a/examples/butterflies.js b/examples/butterflies.js new file mode 100644 index 0000000000..1f612ed4bf --- /dev/null +++ b/examples/butterflies.js @@ -0,0 +1,234 @@ +// +// butterflies.js +// +// +// Created by Adrian McCarlie on August 2, 2014 +// Modified by Brad Hefta-Gaub to use Entities on Sept. 3, 2014 +// Copyright 2014 High Fidelity, Inc. +// +// This sample script creates a swarm of butterfly entities that fly around the avatar. +// +// Distributed under the Apache License, Version 2.0. +// See the accompanying file LICENSE or http://www.apache.org/licenses/LICENSE-2.0.html +// + + +function getRandomFloat(min, max) { + return Math.random() * (max - min) + min; +} + +// Multiply vector by scalar +function vScalarMult(v, s) { + var rval = { x: v.x * s, y: v.y * s, z: v.z * s }; + return rval; +} + +// Create a random vector with individual lengths between a,b +function randVector(a, b) { + var rval = { x: a + Math.random() * (b - a), y: a + Math.random() * (b - a), z: a + Math.random() * (b - a) }; + return rval; +} + +// Returns a vector which is fraction of the way between a and b +function vInterpolate(a, b, fraction) { + var rval = { x: a.x + (b.x - a.x) * fraction, y: a.y + (b.y - a.y) * fraction, z: a.z + (b.z - a.z) * fraction }; + return rval; +} + +var startTimeInSeconds = new Date().getTime() / 1000; + +var lifeTime = 600; // lifetime of the butterflies in seconds +var range = 1.0; // Over what distance in meters do you want the flock to fly around +var frame = 0; + +var CHANCE_OF_MOVING = 0.9; +var BUTTERFLY_GRAVITY = 0;//-0.06; +var BUTTERFLY_FLAP_SPEED = 1.0; +var BUTTERFLY_VELOCITY = 0.55; +var DISTANCE_IN_FRONT_OF_ME = 1.5; +var DISTANCE_ABOVE_ME = 1.0; +var flockPosition = Vec3.sum(MyAvatar.position,Vec3.sum( + Vec3.multiply(Quat.getFront(MyAvatar.orientation), DISTANCE_ABOVE_ME), + Vec3.multiply(Quat.getFront(MyAvatar.orientation), DISTANCE_IN_FRONT_OF_ME))); + + +// set these pitch, yaw, roll to the needed values to orient the model as you want it +var pitchInDegrees = 270.0; +var yawInDegrees = 0.0; +var rollInDegrees = 0.0; +var pitchInRadians = pitchInDegrees / 180.0 * Math.PI; +var yawInRadians = yawInDegrees / 180.0 * Math.PI; +var rollInRadians = rollInDegrees / 180.0 * Math.PI; + +var rotation = Quat.fromPitchYawRollDegrees(pitchInDegrees, yawInDegrees, rollInDegrees);//experimental + +// This is our butterfly object +function defineButterfly(entityID, targetPosition) { + this.entityID = entityID; + this.previousFlapOffset = 0; + this.targetPosition = targetPosition; + this.moving = false; +} + +// Array of butterflies +var butterflies = []; +var numButterflies = 20; +function addButterfly() { + // Decide the size of butterfly + var color = { red: 100, green: 100, blue: 100 }; + var size = 0; + + size = 0.06 + Math.random() * 0.2; + + flockPosition = Vec3.sum(MyAvatar.position,Vec3.sum( + Vec3.multiply(Quat.getFront(MyAvatar.orientation), DISTANCE_ABOVE_ME), + Vec3.multiply(Quat.getFront(MyAvatar.orientation), DISTANCE_IN_FRONT_OF_ME))); + + var properties = { + type: "Model", + lifetime: lifeTime, + position: Vec3.sum(randVector(-range, range), flockPosition), + velocity: { x: 0, y: 0.0, z: 0 }, + gravity: { x: 0, y: 1.0, z: 0 }, + damping: 0.1, + radius : size, + color: color, + rotation: rotation, + animationURL: "http://business.ozblog.me/objects/butterfly/newButterfly2.fbx", + animationIsPlaying: true, + modelURL: "http://business.ozblog.me/objects/butterfly/newButterfly2.fbx" + }; + properties.position.z = properties.position.z+1; + butterflies.push(new defineButterfly(Entities.addEntity(properties), properties.position)); +} + +// Generate the butterflies +for (var i = 0; i < numButterflies; i++) { + addButterfly(); +} + +// Main update function +function updateButterflies(deltaTime) { + // Check to see if we've been running long enough that our butterflies are dead + var nowTimeInSeconds = new Date().getTime() / 1000; + if ((nowTimeInSeconds - startTimeInSeconds) >= lifeTime) { + // print("our butterflies are dying, stop our script"); + Script.stop(); + return; + } + + frame++; + // Only update every third frame + if ((frame % 3) == 0) { + flockPosition = Vec3.sum(MyAvatar.position,Vec3.sum( + Vec3.multiply(Quat.getFront(MyAvatar.orientation), DISTANCE_ABOVE_ME), + Vec3.multiply(Quat.getFront(MyAvatar.orientation), DISTANCE_IN_FRONT_OF_ME))); + + // Update all the butterflies + for (var i = 0; i < numButterflies; i++) { + entityID = butterflies[i].entityID; + var properties = Entities.getEntityProperties(entityID); + + if (properties.position.y > flockPosition.y + getRandomFloat(0.0,0.3)){ //0.3 //ceiling + properties.gravity.y = - 3.0; + properties.damping.y = 1.0; + properties.velocity.y = 0; + properties.velocity.x = properties.velocity.x; + properties.velocity.z = properties.velocity.z; + if (properties.velocity.x < 0.5){ + butterflies[i].moving = false; + } + if (properties.velocity.z < 0.5){ + butterflies[i].moving = false; + } + } + + if (properties.velocity.y <= -0.2) { + properties.velocity.y = 0.22; + properties.velocity.x = properties.velocity.x; + properties.velocity.z = properties.velocity.z; + } + + if (properties.position.y < flockPosition.y - getRandomFloat(0.0,0.3)) { //-0.3 // floor + properties.velocity.y = 0.9; + properties.gravity.y = - 4.0; + properties.velocity.x = properties.velocity.x; + properties.velocity.z = properties.velocity.z; + if (properties.velocity.x < 0.5){ + butterflies[i].moving = false; + } + if (properties.velocity.z < 0.5){ + butterflies[i].moving = false; + } + } + + + // Begin movement by getting a target + if (butterflies[i].moving == false) { + if (Math.random() < CHANCE_OF_MOVING) { + var targetPosition = Vec3.sum(randVector(-range, range), flockPosition); + if (targetPosition.x < 0) { + targetPosition.x = 0; + } + if (targetPosition.y < 0) { + targetPosition.y = 0; + } + if (targetPosition.z < 0) { + targetPosition.z = 0; + } + if (targetPosition.x > TREE_SCALE) { + targetPosition.x = TREE_SCALE; + } + if (targetPosition.y > TREE_SCALE) { + targetPosition.y = TREE_SCALE; + } + if (targetPosition.z > TREE_SCALE) { + targetPosition.z = TREE_SCALE; + } + butterflies[i].targetPosition = targetPosition; + butterflies[i].moving = true; + } + } + + // If we are moving, move towards the target + if (butterflies[i].moving) { + + var holding = properties.velocity.y; + + var desiredVelocity = Vec3.subtract(butterflies[i].targetPosition, properties.position); + desiredVelocity = vScalarMult(Vec3.normalize(desiredVelocity), BUTTERFLY_VELOCITY); + + properties.velocity = vInterpolate(properties.velocity, desiredVelocity, 0.5); + properties.velocity.y = holding ; + + + // If we are near the target, we should get a new target + if (Vec3.length(Vec3.subtract(properties.position, butterflies[i].targetPosition)) < (properties.radius / 1.0)) { + butterflies[i].moving = false; + } + + var yawRads = Math.atan2(properties.velocity.z, properties.velocity.x); + yawRads = yawRads + Math.PI / 2.0; + var newOrientation = Quat.fromPitchYawRollRadians(pitchInRadians, yawRads, rollInRadians); + properties.rotation = newOrientation; + } + + // Use a cosine wave offset to make it look like its flapping. + var offset = Math.cos(nowTimeInSeconds * BUTTERFLY_FLAP_SPEED) * (properties.radius); + properties.position.y = properties.position.y + (offset - butterflies[i].previousFlapOffset); + // Change position relative to previous offset. + butterflies[i].previousFlapOffset = offset; + Entities.editEntity(entityID, properties); + } + } +} + +// register the call back so it fires before each data send +Script.update.connect(updateButterflies); + +// Delete our little friends if script is stopped +Script.scriptEnding.connect(function() { + for (var i = 0; i < numButterflies; i++) { + Entities.deleteEntity(butterflies[i].entityID); + } +}); \ No newline at end of file diff --git a/examples/headMove.js b/examples/headMove.js index 704557b6e7..f2ff3e82a6 100644 --- a/examples/headMove.js +++ b/examples/headMove.js @@ -20,41 +20,104 @@ var HEAD_MOVE_DEAD_ZONE = 0.0; var HEAD_STRAFE_DEAD_ZONE = 0.0; var HEAD_ROTATE_DEAD_ZONE = 0.0; var HEAD_THRUST_FWD_SCALE = 12000.0; -var HEAD_THRUST_STRAFE_SCALE = 1000.0; -var HEAD_YAW_RATE = 2.0; +var HEAD_THRUST_STRAFE_SCALE = 2000.0; +var HEAD_YAW_RATE = 1.0; var HEAD_PITCH_RATE = 1.0; var HEAD_ROLL_THRUST_SCALE = 75.0; var HEAD_PITCH_LIFT_THRUST = 3.0; +var WALL_BOUNCE = 4000.0; + +// If these values are set to something +var maxVelocity = 1.25; +var noFly = true; + +//var roomLimits = { xMin: 618, xMax: 635.5, zMin: 528, zMax: 552.5 }; +var roomLimits = { xMin: -1, xMax: 0, zMin: 0, zMax: 0 }; + +function isInRoom(position) { + var BUFFER = 2.0; + if (roomLimits.xMin < 0) { + return false; + } + if ((position.x > (roomLimits.xMin - BUFFER)) && + (position.x < (roomLimits.xMax + BUFFER)) && + (position.z > (roomLimits.zMin - BUFFER)) && + (position.z < (roomLimits.zMax + BUFFER))) + { + return true; + } else { + return false; + } +} function moveWithHead(deltaTime) { + var thrust = { x: 0, y: 0, z: 0 }; + var position = MyAvatar.position; if (movingWithHead) { var deltaYaw = MyAvatar.getHeadFinalYaw() - headStartYaw; var deltaPitch = MyAvatar.getHeadDeltaPitch() - headStartDeltaPitch; - + var deltaRoll = MyAvatar.getHeadFinalRoll() - headStartRoll; + var velocity = MyAvatar.getVelocity(); var bodyLocalCurrentHeadVector = Vec3.subtract(MyAvatar.getHeadPosition(), MyAvatar.position); bodyLocalCurrentHeadVector = Vec3.multiplyQbyV(Quat.angleAxis(-deltaYaw, {x:0, y: 1, z:0}), bodyLocalCurrentHeadVector); var headDelta = Vec3.subtract(bodyLocalCurrentHeadVector, headStartPosition); headDelta = Vec3.multiplyQbyV(Quat.inverse(Camera.getOrientation()), headDelta); headDelta.y = 0.0; // Don't respond to any of the vertical component of head motion + var forward = Quat.getFront(Camera.getOrientation()); + var right = Quat.getRight(Camera.getOrientation()); + var up = Quat.getUp(Camera.getOrientation()); + if (noFly) { + forward.y = 0.0; + forward = Vec3.normalize(forward); + right.y = 0.0; + right = Vec3.normalize(right); + up = { x: 0, y: 1, z: 0}; + } + // Thrust based on leaning forward and side-to-side if (Math.abs(headDelta.z) > HEAD_MOVE_DEAD_ZONE) { - MyAvatar.addThrust(Vec3.multiply(Quat.getFront(Camera.getOrientation()), -headDelta.z * HEAD_THRUST_FWD_SCALE * deltaTime)); + if (Math.abs(Vec3.dot(velocity, forward)) < maxVelocity) { + thrust = Vec3.sum(thrust, Vec3.multiply(forward, -headDelta.z * HEAD_THRUST_FWD_SCALE * deltaTime)); + } } if (Math.abs(headDelta.x) > HEAD_STRAFE_DEAD_ZONE) { - MyAvatar.addThrust(Vec3.multiply(Quat.getRight(Camera.getOrientation()), headDelta.x * HEAD_THRUST_STRAFE_SCALE * deltaTime)); + if (Math.abs(Vec3.dot(velocity, right)) < maxVelocity) { + thrust = Vec3.sum(thrust, Vec3.multiply(right, headDelta.x * HEAD_THRUST_STRAFE_SCALE * deltaTime)); + } } if (Math.abs(deltaYaw) > HEAD_ROTATE_DEAD_ZONE) { - var orientation = Quat.multiply(Quat.angleAxis(deltaYaw * HEAD_YAW_RATE * deltaTime, {x:0, y: 1, z:0}), MyAvatar.orientation); + var orientation = Quat.multiply(Quat.angleAxis((deltaYaw + deltaRoll) * HEAD_YAW_RATE * deltaTime, {x:0, y: 1, z:0}), MyAvatar.orientation); MyAvatar.orientation = orientation; } // Thrust Up/Down based on head pitch - MyAvatar.addThrust(Vec3.multiply({ x:0, y:1, z:0 }, (MyAvatar.getHeadFinalPitch() - headStartFinalPitch) * HEAD_PITCH_LIFT_THRUST * deltaTime)); + if (!noFly) { + if ((Math.abs(Vec3.dot(velocity, up)) < maxVelocity)) { + thrust = Vec3.sum(thrust, Vec3.multiply({ x:0, y:1, z:0 }, (MyAvatar.getHeadFinalPitch() - headStartFinalPitch) * HEAD_PITCH_LIFT_THRUST * deltaTime)); + } + } // For head trackers, adjust pitch by head pitch MyAvatar.headPitch += deltaPitch * HEAD_PITCH_RATE * deltaTime; - // Thrust strafe based on roll ange - MyAvatar.addThrust(Vec3.multiply(Quat.getRight(Camera.getOrientation()), -(MyAvatar.getHeadFinalRoll() - headStartRoll) * HEAD_ROLL_THRUST_SCALE * deltaTime)); + } + if (isInRoom(position)) { + //print("In room!"); + // Impose constraints to keep you in the space + if (position.x < roomLimits.xMin) { + thrust.x += (roomLimits.xMin - position.x) * WALL_BOUNCE * deltaTime; + } else if (position.x > roomLimits.xMax) { + thrust.x += (roomLimits.xMax - position.x) * WALL_BOUNCE * deltaTime; + } + if (position.z < roomLimits.zMin) { + thrust.z += (roomLimits.zMin - position.z) * WALL_BOUNCE * deltaTime; + } else if (position.z > roomLimits.zMax) { + thrust.z += (roomLimits.zMax - position.z) * WALL_BOUNCE * deltaTime; + } + } + + // Check against movement box limits + + MyAvatar.addThrust(thrust); } Controller.keyPressEvent.connect(function(event) { diff --git a/interface/src/Audio.cpp b/interface/src/Audio.cpp index 9086312bac..9427ec0525 100644 --- a/interface/src/Audio.cpp +++ b/interface/src/Audio.cpp @@ -644,6 +644,8 @@ void Audio::handleAudioInput() { _dcOffset = DC_OFFSET_AVERAGING * _dcOffset + (1.0f - DC_OFFSET_AVERAGING) * measuredDcOffset; } + _lastInputLoudness = fabs(loudness / NETWORK_BUFFER_LENGTH_SAMPLES_PER_CHANNEL); + // If Noise Gate is enabled, check and turn the gate on and off if (!_audioSourceInjectEnabled && _noiseGateEnabled) { float averageOfAllSampleFrames = 0.0f; diff --git a/interface/src/entities/RenderableBoxEntityItem.cpp b/interface/src/entities/RenderableBoxEntityItem.cpp index 673f41574e..c5843bb31a 100644 --- a/interface/src/entities/RenderableBoxEntityItem.cpp +++ b/interface/src/entities/RenderableBoxEntityItem.cpp @@ -37,7 +37,7 @@ void RenderableBoxEntityItem::render(RenderArgs* args) { glm::quat rotation = getRotation(); - const bool useGlutCube = false; + const bool useGlutCube = true; if (useGlutCube) { glColor3ub(getColor()[RED_INDEX], getColor()[GREEN_INDEX], getColor()[BLUE_INDEX]); From 634bfe5e1df2a7ef478d121ad2de8178dd93b6da Mon Sep 17 00:00:00 2001 From: Philip Rosedale Date: Wed, 10 Sep 2014 19:02:22 -0700 Subject: [PATCH 15/29] remove renamed script --- examples/entitiesButterflyFlock.js | 241 ----------------------------- 1 file changed, 241 deletions(-) delete mode 100644 examples/entitiesButterflyFlock.js diff --git a/examples/entitiesButterflyFlock.js b/examples/entitiesButterflyFlock.js deleted file mode 100644 index b86528bda1..0000000000 --- a/examples/entitiesButterflyFlock.js +++ /dev/null @@ -1,241 +0,0 @@ -// -// butterflyFlockTest1.js -// -// -// Created by Adrian McCarlie on August 2, 2014 -// Modified by Brad Hefta-Gaub to use Entities on Sept. 3, 2014 -// Copyright 2014 High Fidelity, Inc. -// -// This sample script creates a swarm of butterfly entities that fly around the avatar. -// -// Distributed under the Apache License, Version 2.0. -// See the accompanying file LICENSE or http://www.apache.org/licenses/LICENSE-2.0.html -// - - -function getRandomFloat(min, max) { - return Math.random() * (max - min) + min; -} - -// Multiply vector by scalar -function vScalarMult(v, s) { - var rval = { x: v.x * s, y: v.y * s, z: v.z * s }; - return rval; -} - -function printVector(v) { - print(v.x + ", " + v.y + ", " + v.z + "\n"); -} -// Create a random vector with individual lengths between a,b -function randVector(a, b) { - var rval = { x: a + Math.random() * (b - a), y: a + Math.random() * (b - a), z: a + Math.random() * (b - a) }; - return rval; -} - -// Returns a vector which is fraction of the way between a and b -function vInterpolate(a, b, fraction) { - var rval = { x: a.x + (b.x - a.x) * fraction, y: a.y + (b.y - a.y) * fraction, z: a.z + (b.z - a.z) * fraction }; - return rval; -} - -var startTimeInSeconds = new Date().getTime() / 1000; - -var lifeTime = 60; // lifetime of the butterflies in seconds! -var range = 1.0; // Over what distance in meters do you want the flock to fly around -var frame = 0; - -var CHANCE_OF_MOVING = 0.9; -var BUTTERFLY_GRAVITY = 0;//-0.06; -var BUTTERFLY_FLAP_SPEED = 1.0; -var BUTTERFLY_VELOCITY = 0.55; -var DISTANCE_IN_FRONT_OF_ME = 1.5; -var DISTANCE_ABOVE_ME = 1.5; -var flockPosition = Vec3.sum(MyAvatar.position,Vec3.sum( - Vec3.multiply(Quat.getFront(MyAvatar.orientation), DISTANCE_ABOVE_ME), - Vec3.multiply(Quat.getFront(MyAvatar.orientation), DISTANCE_IN_FRONT_OF_ME))); - - -// set these pitch, yaw, roll to the needed values to orient the model as you want it -var pitchInDegrees = 270.0; -var yawInDegrees = 0.0; -var rollInDegrees = 0.0; -var pitchInRadians = pitchInDegrees / 180.0 * Math.PI; -var yawInRadians = yawInDegrees / 180.0 * Math.PI; -var rollInRadians = rollInDegrees / 180.0 * Math.PI; - -var rotation = Quat.fromPitchYawRollDegrees(pitchInDegrees, yawInDegrees, rollInDegrees);//experimental - -// This is our butterfly object -function defineButterfly(entityID, targetPosition) { - this.entityID = entityID; - this.previousFlapOffset = 0; - this.targetPosition = targetPosition; - this.moving = false; -} - -// Array of butterflies -var butterflies = []; -var numButterflies = 20; -function addButterfly() { - // Decide the size of butterfly - var color = { red: 100, green: 100, blue: 100 }; - var size = 0; - - var which = Math.random(); - if (which < 0.2) { - size = 0.08; - } else if (which < 0.4) { - size = 0.09; - } else if (which < 0.6) { - size = 0.8; - } else if (which < 0.8) { - size = 0.8; - } else { - size = 0.8; - } - - flockPosition = Vec3.sum(MyAvatar.position,Vec3.sum( - Vec3.multiply(Quat.getFront(MyAvatar.orientation), DISTANCE_ABOVE_ME), - Vec3.multiply(Quat.getFront(MyAvatar.orientation), DISTANCE_IN_FRONT_OF_ME))); - - var properties = { - type: "Model", - lifetime: lifeTime, - position: Vec3.sum(randVector(-range, range), flockPosition), - velocity: { x: 0, y: 0.0, z: 0 }, - gravity: { x: 0, y: 1.0, z: 0 }, - damping: 0.1, - radius : size, - color: color, - rotation: rotation, - animationURL: "http://business.ozblog.me/objects/butterfly/newButterfly2.fbx", - animationIsPlaying: true, - modelURL: "http://business.ozblog.me/objects/butterfly/newButterfly2.fbx" - }; - properties.position.z = properties.position.z+1; - butterflies.push(new defineButterfly(Entities.addEntity(properties), properties.position)); -} - -// Generate the butterflies -for (var i = 0; i < numButterflies; i++) { - addButterfly(); -} - -// Main update function -function updateButterflies(deltaTime) { - // Check to see if we've been running long enough that our butterflies are dead - var nowTimeInSeconds = new Date().getTime() / 1000; - if ((nowTimeInSeconds - startTimeInSeconds) >= lifeTime) { - // print("our butterflies are dying, stop our script"); - Script.stop(); - return; - } - - frame++; - // Only update every third frame - if ((frame % 3) == 0) { - flockPosition = Vec3.sum(MyAvatar.position,Vec3.sum( - Vec3.multiply(Quat.getFront(MyAvatar.orientation), DISTANCE_ABOVE_ME), - Vec3.multiply(Quat.getFront(MyAvatar.orientation), DISTANCE_IN_FRONT_OF_ME))); - - // Update all the butterflies - for (var i = 0; i < numButterflies; i++) { - entityID = butterflies[i].entityID; - var properties = Entities.getEntityProperties(entityID); - - if (properties.position.y > flockPosition.y + getRandomFloat(0.0,0.3)){ //0.3 //ceiling - properties.gravity.y = - 3.0; - properties.damping.y = 1.0; - properties.velocity.y = 0; - properties.velocity.x = properties.velocity.x; - properties.velocity.z = properties.velocity.z; - if (properties.velocity.x < 0.5){ - butterflies[i].moving = false; - } - if (properties.velocity.z < 0.5){ - butterflies[i].moving = false; - } - } - - if (properties.velocity.y <= -0.2) { - properties.velocity.y = 0.22; - properties.velocity.x = properties.velocity.x; - properties.velocity.z = properties.velocity.z; - } - - if (properties.position.y < flockPosition.y - getRandomFloat(0.0,0.3)) { //-0.3 // floor - properties.velocity.y = 0.9; - properties.gravity.y = - 4.0; - properties.velocity.x = properties.velocity.x; - properties.velocity.z = properties.velocity.z; - if (properties.velocity.x < 0.5){ - butterflies[i].moving = false; - } - if (properties.velocity.z < 0.5){ - butterflies[i].moving = false; - } - } - - - // Begin movement by getting a target - if (butterflies[i].moving == false) { - if (Math.random() < CHANCE_OF_MOVING) { - var targetPosition = Vec3.sum(randVector(-range, range), flockPosition); - if (targetPosition.x < 0) { - targetPosition.x = 0; - } - if (targetPosition.y < 0) { - targetPosition.y = 0; - } - if (targetPosition.z < 0) { - targetPosition.z = 0; - } - if (targetPosition.x > TREE_SCALE) { - targetPosition.x = TREE_SCALE; - } - if (targetPosition.y > TREE_SCALE) { - targetPosition.y = TREE_SCALE; - } - if (targetPosition.z > TREE_SCALE) { - targetPosition.z = TREE_SCALE; - } - butterflies[i].targetPosition = targetPosition; - butterflies[i].moving = true; - } - } - - // If we are moving, move towards the target - if (butterflies[i].moving) { - - var holding = properties.velocity.y; - - var desiredVelocity = Vec3.subtract(butterflies[i].targetPosition, properties.position); - desiredVelocity = vScalarMult(Vec3.normalize(desiredVelocity), BUTTERFLY_VELOCITY); - - properties.velocity = vInterpolate(properties.velocity, desiredVelocity, 0.2); - properties.velocity.y = holding ; - - - // If we are near the target, we should get a new target - if (Vec3.length(Vec3.subtract(properties.position, butterflies[i].targetPosition)) < (properties.radius / 1.0)) { - butterflies[i].moving = false; - } - - var yawRads = Math.atan2(properties.velocity.z, properties.velocity.x); - yawRads = yawRads + Math.PI / 2.0; - var newOrientation = Quat.fromPitchYawRollRadians(pitchInRadians, yawRads, rollInRadians); - properties.rotation = newOrientation; - } - - // Use a cosine wave offset to make it look like its flapping. - var offset = Math.cos(nowTimeInSeconds * BUTTERFLY_FLAP_SPEED) * (properties.radius); - properties.position.y = properties.position.y + (offset - butterflies[i].previousFlapOffset); - // Change position relative to previous offset. - butterflies[i].previousFlapOffset = offset; - Entities.editEntity(entityID, properties); - } - } -} - -// register the call back so it fires before each data send -Script.update.connect(updateButterflies); \ No newline at end of file From 7b3d06a78335b6f862443b32c16b3cfa4c834549 Mon Sep 17 00:00:00 2001 From: Andrzej Kapolka Date: Wed, 10 Sep 2014 19:34:21 -0700 Subject: [PATCH 16/29] Add option to change Faceshift hostname. --- interface/src/Menu.cpp | 4 ++ interface/src/Menu.h | 3 ++ interface/src/devices/Faceshift.cpp | 2 +- interface/src/ui/PreferencesDialog.cpp | 5 ++ interface/ui/preferencesDialog.ui | 64 ++++++++++++++++++++++++++ 5 files changed, 77 insertions(+), 1 deletion(-) diff --git a/interface/src/Menu.cpp b/interface/src/Menu.cpp index d7679968ae..ff5e50d66c 100644 --- a/interface/src/Menu.cpp +++ b/interface/src/Menu.cpp @@ -70,6 +70,7 @@ Menu* Menu::getInstance() { const ViewFrustumOffset DEFAULT_FRUSTUM_OFFSET = {-135.0f, 0.0f, 0.0f, 25.0f, 0.0f}; const float DEFAULT_FACESHIFT_EYE_DEFLECTION = 0.25f; +const QString DEFAULT_FACESHIFT_HOSTNAME = "localhost"; const float DEFAULT_AVATAR_LOD_DISTANCE_MULTIPLIER = 1.0f; const int ONE_SECOND_OF_FRAMES = 60; const int FIVE_SECONDS_OF_FRAMES = 5 * ONE_SECOND_OF_FRAMES; @@ -87,6 +88,7 @@ Menu::Menu() : _fieldOfView(DEFAULT_FIELD_OF_VIEW_DEGREES), _realWorldFieldOfView(DEFAULT_REAL_WORLD_FIELD_OF_VIEW_DEGREES), _faceshiftEyeDeflection(DEFAULT_FACESHIFT_EYE_DEFLECTION), + _faceshiftHostname(DEFAULT_FACESHIFT_HOSTNAME), _frustumDrawMode(FRUSTUM_DRAW_MODE_ALL), _viewFrustumOffset(DEFAULT_FRUSTUM_OFFSET), _jsConsole(NULL), @@ -713,6 +715,7 @@ void Menu::loadSettings(QSettings* settings) { _fieldOfView = loadSetting(settings, "fieldOfView", DEFAULT_FIELD_OF_VIEW_DEGREES); _realWorldFieldOfView = loadSetting(settings, "realWorldFieldOfView", DEFAULT_REAL_WORLD_FIELD_OF_VIEW_DEGREES); _faceshiftEyeDeflection = loadSetting(settings, "faceshiftEyeDeflection", DEFAULT_FACESHIFT_EYE_DEFLECTION); + _faceshiftHostname = settings->value("faceshiftHostname", DEFAULT_FACESHIFT_HOSTNAME).toString(); _maxVoxels = loadSetting(settings, "maxVoxels", DEFAULT_MAX_VOXELS_PER_SYSTEM); _maxVoxelPacketsPerSecond = loadSetting(settings, "maxVoxelsPPS", DEFAULT_MAX_VOXEL_PPS); _voxelSizeScale = loadSetting(settings, "voxelSizeScale", DEFAULT_OCTREE_SIZE_SCALE); @@ -777,6 +780,7 @@ void Menu::saveSettings(QSettings* settings) { settings->setValue("fieldOfView", _fieldOfView); settings->setValue("faceshiftEyeDeflection", _faceshiftEyeDeflection); + settings->setValue("faceshiftHostname", _faceshiftHostname); settings->setValue("maxVoxels", _maxVoxels); settings->setValue("maxVoxelsPPS", _maxVoxelPacketsPerSecond); settings->setValue("voxelSizeScale", _voxelSizeScale); diff --git a/interface/src/Menu.h b/interface/src/Menu.h index 3b263add36..7ed963f473 100644 --- a/interface/src/Menu.h +++ b/interface/src/Menu.h @@ -104,6 +104,8 @@ public: float getFaceshiftEyeDeflection() const { return _faceshiftEyeDeflection; } void setFaceshiftEyeDeflection(float faceshiftEyeDeflection) { _faceshiftEyeDeflection = faceshiftEyeDeflection; bumpSettings(); } + const QString& getFaceshiftHostname() const { return _faceshiftHostname; } + void setFaceshiftHostname(const QString& hostname) { _faceshiftHostname = hostname; bumpSettings(); } QString getSnapshotsLocation() const; void setSnapshotsLocation(QString snapshotsLocation) { _snapshotsLocation = snapshotsLocation; bumpSettings(); } @@ -271,6 +273,7 @@ private: float _fieldOfView; /// in Degrees, doesn't apply to HMD like Oculus float _realWorldFieldOfView; // The actual FOV set by the user's monitor size and view distance float _faceshiftEyeDeflection; + QString _faceshiftHostname; FrustumDrawMode _frustumDrawMode; ViewFrustumOffset _viewFrustumOffset; QPointer _MetavoxelEditor; diff --git a/interface/src/devices/Faceshift.cpp b/interface/src/devices/Faceshift.cpp index 345e635045..74e36a98d1 100644 --- a/interface/src/devices/Faceshift.cpp +++ b/interface/src/devices/Faceshift.cpp @@ -151,7 +151,7 @@ void Faceshift::connectSocket() { qDebug("Faceshift: Connecting..."); } - _tcpSocket.connectToHost("localhost", FACESHIFT_PORT); + _tcpSocket.connectToHost(Menu::getInstance()->getFaceshiftHostname(), FACESHIFT_PORT); _tracking = false; } } diff --git a/interface/src/ui/PreferencesDialog.cpp b/interface/src/ui/PreferencesDialog.cpp index 47cb9bad88..a71e75e655 100644 --- a/interface/src/ui/PreferencesDialog.cpp +++ b/interface/src/ui/PreferencesDialog.cpp @@ -121,6 +121,8 @@ void PreferencesDialog::loadPreferences() { ui.faceshiftEyeDeflectionSider->setValue(menuInstance->getFaceshiftEyeDeflection() * ui.faceshiftEyeDeflectionSider->maximum()); + ui.faceshiftHostnameEdit->setText(menuInstance->getFaceshiftHostname()); + const InboundAudioStream::Settings& streamSettings = menuInstance->getReceivedAudioStreamSettings(); ui.dynamicJitterBuffersCheckBox->setChecked(streamSettings._dynamicJitterBuffers); @@ -211,6 +213,9 @@ void PreferencesDialog::savePreferences() { Menu::getInstance()->setFaceshiftEyeDeflection(ui.faceshiftEyeDeflectionSider->value() / (float)ui.faceshiftEyeDeflectionSider->maximum()); + + Menu::getInstance()->setFaceshiftHostname(ui.faceshiftHostnameEdit->text()); + Menu::getInstance()->setMaxVoxelPacketsPerSecond(ui.maxVoxelsPPSSpin->value()); Menu::getInstance()->setOculusUIAngularSize(ui.oculusUIAngularSizeSpin->value()); diff --git a/interface/ui/preferencesDialog.ui b/interface/ui/preferencesDialog.ui index 9b6e381602..0108437c1f 100644 --- a/interface/ui/preferencesDialog.ui +++ b/interface/ui/preferencesDialog.ui @@ -1726,6 +1726,70 @@ + + + + 0 + + + 7 + + + 0 + + + 7 + + + + + + Arial + + + + Faceshift hostname + + + 0 + + + faceshiftHostnameEdit + + + + + + + + Arial + + + + Qt::Horizontal + + + + + + + + Arial + + + + Qt::LeftToRight + + + + + + localhost + + + + + From b1cfafdbe7f8624290dd56a508fc9e3f090aeda8 Mon Sep 17 00:00:00 2001 From: Andrzej Kapolka Date: Wed, 10 Sep 2014 23:09:03 -0700 Subject: [PATCH 17/29] Missed a spot in the TextRenderer conversion. --- interface/src/devices/PrioVR.cpp | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/interface/src/devices/PrioVR.cpp b/interface/src/devices/PrioVR.cpp index d6c74e4a5d..fad80fda6f 100644 --- a/interface/src/devices/PrioVR.cpp +++ b/interface/src/devices/PrioVR.cpp @@ -207,10 +207,11 @@ void PrioVR::renderCalibrationCountdown() { Application::getInstance()->disconnect(this); return; } - static TextRenderer textRenderer(MONO_FONT_FAMILY, 18, QFont::Bold, false, TextRenderer::OUTLINE_EFFECT, 2); + static TextRenderer* textRenderer = TextRenderer::getInstance(MONO_FONT_FAMILY, 18, QFont::Bold, + false, TextRenderer::OUTLINE_EFFECT, 2); QByteArray text = "Assume T-Pose in " + QByteArray::number(secondsRemaining) + "..."; - textRenderer.draw((Application::getInstance()->getGLWidget()->width() - - textRenderer.computeWidth(text.constData())) / 2, Application::getInstance()->getGLWidget()->height() / 2, + textRenderer->draw((Application::getInstance()->getGLWidget()->width() - + textRenderer->computeWidth(text.constData())) / 2, Application::getInstance()->getGLWidget()->height() / 2, text); #endif } From 0d5f28c7df9e51e1c290e512d4f9ca40b6a2a946 Mon Sep 17 00:00:00 2001 From: Craig Hansen-Sturm Date: Thu, 11 Sep 2014 11:05:27 -0700 Subject: [PATCH 18/29] audio buffer framing issue / comments --- libraries/audio/src/AudioBuffer.h | 40 ++++++++++++++++++++++++------- 1 file changed, 31 insertions(+), 9 deletions(-) diff --git a/libraries/audio/src/AudioBuffer.h b/libraries/audio/src/AudioBuffer.h index 0c82339dfd..1e52f8aa21 100644 --- a/libraries/audio/src/AudioBuffer.h +++ b/libraries/audio/src/AudioBuffer.h @@ -111,19 +111,41 @@ public: return; } - if (channelCount >_channelCountMax || frameCount >_frameCountMax) { - qDebug() << "Audio framing error: _channelCount=" << _channelCount << "channelCountMax=" << _channelCountMax; - qDebug() << "Audio framing error: _frameCount=" << _frameCount << "frameCountMax=" << _frameCountMax; + if (channelCount <=_channelCountMax && frameCount <=_frameCountMax) { + // We always allow copying fewer frames than we have allocated + _frameCount = frameCount; + _channelCount = channelCount; + } + else { + // + // However we do not attempt to copy more frames than we've allocated ;-) This is a framing error caused by either + // a/ the platform audio driver not queuing and smoothing out device IO capture frames -or- + // b/ our IO processing thread (currently running on a Qt GUI thread) has been delayed/scheduled too late. + // + // The fix is not to make the problem worse by allocating more on this thread, rather, it is to handle dynamic + // re-sizing off the IO processing thread. While a/ is not iin our control, we will address the off thread + // re-sizing and Qt GUI IO thread issue in later releases. + // + // For now, we log this condition, and do our best to recover by copying as many frames as we have allocated. + // Unfortunately, this will result (temporarily), in a discontinuity. + // + // If you repeatedly receive this error, contact craig@highfidelity.io and send me what audio device you are using, + // what audio-stack you are using (pulse/alsa, core audio, ...), what OS, and what the reported frame/channel + // counts are. + qDebug() << "Audio framing error: _channelCount=" + << _channelCount + << "channelCountMax=" + << _channelCountMax + << "_frameCount=" + << _frameCount + << "frameCountMax=" + << _frameCountMax; + - // This condition should never happen; however, we do our best to recover here copying as many frames - // as we have allocated _channelCount = std::min(_channelCount,_channelCountMax); _frameCount = std::min(_frameCount,_frameCountMax); } - - _frameCount = frameCount; // we allow copying fewer frames than we've allocated - _channelCount = channelCount; // we allow copying fewer channels that we've allocated - + if (copyOut) { S* dst = frames; From 893d4686db1913b79c8cf2f609f0cb27d6dd7106 Mon Sep 17 00:00:00 2001 From: Craig Hansen-Sturm Date: Thu, 11 Sep 2014 11:18:05 -0700 Subject: [PATCH 19/29] comments --- libraries/audio/src/AudioBuffer.h | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/libraries/audio/src/AudioBuffer.h b/libraries/audio/src/AudioBuffer.h index 1e52f8aa21..863bbdf22a 100644 --- a/libraries/audio/src/AudioBuffer.h +++ b/libraries/audio/src/AudioBuffer.h @@ -119,19 +119,21 @@ public: else { // // However we do not attempt to copy more frames than we've allocated ;-) This is a framing error caused by either - // a/ the platform audio driver not queuing and smoothing out device IO capture frames -or- + // a/ the platform audio driver not correctly queuing and regularly smoothing device IO capture frames -or- // b/ our IO processing thread (currently running on a Qt GUI thread) has been delayed/scheduled too late. // - // The fix is not to make the problem worse by allocating more on this thread, rather, it is to handle dynamic - // re-sizing off the IO processing thread. While a/ is not iin our control, we will address the off thread - // re-sizing and Qt GUI IO thread issue in later releases. + // The fix is not to make the problem worse by allocating additional frames on this thread, rather, it is to handle + // dynamic re-sizing off the IO processing thread. While a/ is not in our control, we will address the off thread + // re-sizing,, as well as b/, in later releases. // // For now, we log this condition, and do our best to recover by copying as many frames as we have allocated. - // Unfortunately, this will result (temporarily), in a discontinuity. + // Unfortunately, this will result (temporarily), in an audible discontinuity. // // If you repeatedly receive this error, contact craig@highfidelity.io and send me what audio device you are using, // what audio-stack you are using (pulse/alsa, core audio, ...), what OS, and what the reported frame/channel - // counts are. + // counts are. In addition, any information about what you were doing at the time of the discontinuity, would be + // useful (e.g., accessing any client features/menus) + // qDebug() << "Audio framing error: _channelCount=" << _channelCount << "channelCountMax=" From de24842cf00db8da53f4e60d1af9e2a0b8a6ac1f Mon Sep 17 00:00:00 2001 From: Stephen Birarda Date: Thu, 11 Sep 2014 11:48:26 -0700 Subject: [PATCH 20/29] fix stuck drive keys for Avatar when modifier released --- interface/src/Application.cpp | 13 ++++++++++--- interface/src/avatar/MyAvatar.cpp | 6 ++++++ interface/src/avatar/MyAvatar.h | 1 + 3 files changed, 17 insertions(+), 3 deletions(-) diff --git a/interface/src/Application.cpp b/interface/src/Application.cpp index 273b66e4dc..7fad196cd0 100644 --- a/interface/src/Application.cpp +++ b/interface/src/Application.cpp @@ -905,7 +905,9 @@ void Application::keyPressEvent(QKeyEvent* event) { break; case Qt::Key_D: - _myAvatar->setDriveKeys(ROT_RIGHT, 1.f); + if (!isMeta) { + _myAvatar->setDriveKeys(ROT_RIGHT, 1.f); + } break; case Qt::Key_Return: @@ -1073,7 +1075,7 @@ void Application::keyReleaseEvent(QKeyEvent* event) { _keysPressed.remove(event->key()); _controllerScriptingInterface.emitKeyReleaseEvent(event); // send events to any registered scripts - + // if one of our scripts have asked to capture this event, then stop processing it if (_controllerScriptingInterface.isKeyCaptured(event)) { return; @@ -1125,7 +1127,12 @@ void Application::keyReleaseEvent(QKeyEvent* event) { _myAvatar->setDriveKeys(RIGHT, 0.f); _myAvatar->setDriveKeys(ROT_RIGHT, 0.f); break; - + case Qt::Key_Control: + case Qt::Key_Shift: + case Qt::Key_Meta: + case Qt::Key_Alt: + _myAvatar->clearDriveKeys(); + break; default: event->ignore(); break; diff --git a/interface/src/avatar/MyAvatar.cpp b/interface/src/avatar/MyAvatar.cpp index 6472ba2efa..241b39028f 100644 --- a/interface/src/avatar/MyAvatar.cpp +++ b/interface/src/avatar/MyAvatar.cpp @@ -1972,3 +1972,9 @@ glm::vec3 MyAvatar::getLaserPointerTipPosition(const PalmData* palm) { return palm->getPosition(); } + +void MyAvatar::clearDriveKeys() { + for (int i = 0; i < sizeof(_driveKeys); i++) { + _driveKeys[i] = 0.0f; + } +} diff --git a/interface/src/avatar/MyAvatar.h b/interface/src/avatar/MyAvatar.h index be828e0c91..35af0faee3 100644 --- a/interface/src/avatar/MyAvatar.h +++ b/interface/src/avatar/MyAvatar.h @@ -98,6 +98,7 @@ public: AttachmentData loadAttachmentData(const QUrl& modelURL, const QString& jointName = QString()) const; // Set what driving keys are being pressed to control thrust levels + void clearDriveKeys(); void setDriveKeys(int key, float val) { _driveKeys[key] = val; }; bool getDriveKeys(int key) { return _driveKeys[key] != 0.f; }; void jump() { _shouldJump = true; }; From 5c770402356f0dfc68c75514996ccb561729d6fe Mon Sep 17 00:00:00 2001 From: Philip Rosedale Date: Thu, 11 Sep 2014 12:15:02 -0700 Subject: [PATCH 21/29] remove debug print --- examples/headMove.js | 1 - 1 file changed, 1 deletion(-) diff --git a/examples/headMove.js b/examples/headMove.js index f2ff3e82a6..0a7686c569 100644 --- a/examples/headMove.js +++ b/examples/headMove.js @@ -101,7 +101,6 @@ function moveWithHead(deltaTime) { } if (isInRoom(position)) { - //print("In room!"); // Impose constraints to keep you in the space if (position.x < roomLimits.xMin) { thrust.x += (roomLimits.xMin - position.x) * WALL_BOUNCE * deltaTime; From f88970f8fec7dce9865e4864d23ac58dd8f3cc44 Mon Sep 17 00:00:00 2001 From: ZappoMan Date: Thu, 11 Sep 2014 12:12:25 -0700 Subject: [PATCH 22/29] moved Extents to shared --- libraries/fbx/src/FBXReader.cpp | 21 --------- libraries/fbx/src/FBXReader.h | 27 +----------- libraries/shared/src/Extents.cpp | 74 ++++++++++++++++++++++++++++++++ libraries/shared/src/Extents.h | 53 +++++++++++++++++++++++ 4 files changed, 129 insertions(+), 46 deletions(-) create mode 100644 libraries/shared/src/Extents.cpp create mode 100644 libraries/shared/src/Extents.h diff --git a/libraries/fbx/src/FBXReader.cpp b/libraries/fbx/src/FBXReader.cpp index 6f87bcf1f8..88888ac381 100644 --- a/libraries/fbx/src/FBXReader.cpp +++ b/libraries/fbx/src/FBXReader.cpp @@ -33,27 +33,6 @@ using namespace std; -void Extents::reset() { - minimum = glm::vec3(FLT_MAX); - maximum = glm::vec3(-FLT_MAX); -} - -bool Extents::containsPoint(const glm::vec3& point) const { - return (point.x >= minimum.x && point.x <= maximum.x - && point.y >= minimum.y && point.y <= maximum.y - && point.z >= minimum.z && point.z <= maximum.z); -} - -void Extents::addExtents(const Extents& extents) { - minimum = glm::min(minimum, extents.minimum); - maximum = glm::max(maximum, extents.maximum); -} - -void Extents::addPoint(const glm::vec3& point) { - minimum = glm::min(minimum, point); - maximum = glm::max(maximum, point); -} - bool FBXMesh::hasSpecularTexture() const { foreach (const FBXMeshPart& part, parts) { if (!part.specularTexture.filename.isEmpty()) { diff --git a/libraries/fbx/src/FBXReader.h b/libraries/fbx/src/FBXReader.h index d07a33f3d4..e54e218a5b 100644 --- a/libraries/fbx/src/FBXReader.h +++ b/libraries/fbx/src/FBXReader.h @@ -18,8 +18,10 @@ #include #include +#include #include + #include #include @@ -35,31 +37,6 @@ extern const int NUM_FACESHIFT_BLENDSHAPES; /// The names of the joints in the Maya HumanIK rig, terminated with an empty string. extern const char* HUMANIK_JOINTS[]; -class Extents { -public: - /// set minimum and maximum to FLT_MAX and -FLT_MAX respectively - void reset(); - - /// \param extents another intance of extents - /// expand current limits to contain other extents - void addExtents(const Extents& extents); - - /// \param point new point to compare against existing limits - /// compare point to current limits and expand them if necessary to contain point - void addPoint(const glm::vec3& point); - - /// \param point - /// \return true if point is within current limits - bool containsPoint(const glm::vec3& point) const; - - /// \return whether or not the extents are empty - bool isEmpty() const { return minimum == maximum; } - bool isValid() const { return !((minimum == glm::vec3(FLT_MAX)) && (maximum == glm::vec3(-FLT_MAX))); } - - glm::vec3 minimum; - glm::vec3 maximum; -}; - /// A node within an FBX document. class FBXNode { public: diff --git a/libraries/shared/src/Extents.cpp b/libraries/shared/src/Extents.cpp new file mode 100644 index 0000000000..02e09bfa3c --- /dev/null +++ b/libraries/shared/src/Extents.cpp @@ -0,0 +1,74 @@ +// +// Extents.cpp +// libraries/shared/src +// +// Created by Andrzej Kapolka on 9/18/13. +// Moved to shared by Brad Hefta-Gaub on 9/11/14 +// Copyright 2013-2104 High Fidelity, Inc. +// +// Distributed under the Apache License, Version 2.0. +// See the accompanying file LICENSE or http://www.apache.org/licenses/LICENSE-2.0.html +// + +#include +#include +#include + +#include "Extents.h" + +void Extents::reset() { + minimum = glm::vec3(FLT_MAX); + maximum = glm::vec3(-FLT_MAX); +} + +bool Extents::containsPoint(const glm::vec3& point) const { + return (point.x >= minimum.x && point.x <= maximum.x + && point.y >= minimum.y && point.y <= maximum.y + && point.z >= minimum.z && point.z <= maximum.z); +} + +void Extents::addExtents(const Extents& extents) { + minimum = glm::min(minimum, extents.minimum); + maximum = glm::max(maximum, extents.maximum); +} + +void Extents::addPoint(const glm::vec3& point) { + minimum = glm::min(minimum, point); + maximum = glm::max(maximum, point); +} + +void Extents::rotate(const glm::quat& rotation) { + glm::vec3 bottomLeftNear(minimum.x, minimum.y, minimum.z); + glm::vec3 bottomRightNear(maximum.x, minimum.y, minimum.z); + glm::vec3 bottomLeftFar(minimum.x, minimum.y, maximum.z); + glm::vec3 bottomRightFar(maximum.x, minimum.y, maximum.z); + glm::vec3 topLeftNear(minimum.x, maximum.y, minimum.z); + glm::vec3 topRightNear(maximum.x, maximum.y, minimum.z); + glm::vec3 topLeftFar(minimum.x, maximum.y, maximum.z); + glm::vec3 topRightFar(maximum.x, maximum.y, maximum.z); + + glm::vec3 bottomLeftNearRotated = rotation * bottomLeftNear; + glm::vec3 bottomRightNearRotated = rotation * bottomRightNear; + glm::vec3 bottomLeftFarRotated = rotation * bottomLeftFar; + glm::vec3 bottomRightFarRotated = rotation * bottomRightFar; + glm::vec3 topLeftNearRotated = rotation * topLeftNear; + glm::vec3 topRightNearRotated = rotation * topRightNear; + glm::vec3 topLeftFarRotated = rotation * topLeftFar; + glm::vec3 topRightFarRotated = rotation * topRightFar; + + minimum = glm::min(bottomLeftNearRotated, + glm::min(bottomRightNearRotated, + glm::min(bottomLeftFarRotated, + glm::min(bottomRightFarRotated, + glm::min(topLeftNearRotated, + glm::min(topRightNearRotated, + glm::min(topLeftFarRotated,topRightFarRotated))))))); + + maximum = glm::max(bottomLeftNearRotated, + glm::max(bottomRightNearRotated, + glm::max(bottomLeftFarRotated, + glm::max(bottomRightFarRotated, + glm::max(topLeftNearRotated, + glm::max(topRightNearRotated, + glm::max(topLeftFarRotated,topRightFarRotated))))))); +} diff --git a/libraries/shared/src/Extents.h b/libraries/shared/src/Extents.h new file mode 100644 index 0000000000..c0e68bd2b1 --- /dev/null +++ b/libraries/shared/src/Extents.h @@ -0,0 +1,53 @@ +// +// Extents.h +// libraries/shared/src +// +// Created by Andrzej Kapolka on 9/18/13. +// Moved to shared by Brad Hefta-Gaub on 9/11/14 +// Copyright 2013-2104 High Fidelity, Inc. +// +// Distributed under the Apache License, Version 2.0. +// See the accompanying file LICENSE or http://www.apache.org/licenses/LICENSE-2.0.html +// + +#ifndef hifi_Extents_h +#define hifi_Extents_h + +#include + +class Extents { +public: + /// set minimum and maximum to FLT_MAX and -FLT_MAX respectively + void reset(); + + /// \param extents another intance of extents + /// expand current limits to contain other extents + void addExtents(const Extents& extents); + + /// \param point new point to compare against existing limits + /// compare point to current limits and expand them if necessary to contain point + void addPoint(const glm::vec3& point); + + /// \param point + /// \return true if point is within current limits + bool containsPoint(const glm::vec3& point) const; + + /// \return whether or not the extents are empty + bool isEmpty() const { return minimum == maximum; } + bool isValid() const { return !((minimum == glm::vec3(FLT_MAX)) && (maximum == glm::vec3(-FLT_MAX))); } + + /// rotate the extents around orign by rotation + void rotate(const glm::quat& rotation); + + /// \return new Extents which is original rotated around orign by rotation + Extents getRotated(const glm::quat& rotation) const { + Extents temp = { minimum, maximum }; + temp.rotate(rotation); + return temp; + } + + glm::vec3 minimum; + glm::vec3 maximum; +}; + +#endif // hifi_Extents_h \ No newline at end of file From a022d4779284b33647fc8015da3f93bf6883a38a Mon Sep 17 00:00:00 2001 From: ZappoMan Date: Thu, 11 Sep 2014 12:13:34 -0700 Subject: [PATCH 23/29] improve constness for operators on PropertyFlags<> --- libraries/shared/src/PropertyFlags.h | 52 ++++++++++++++-------------- 1 file changed, 26 insertions(+), 26 deletions(-) diff --git a/libraries/shared/src/PropertyFlags.h b/libraries/shared/src/PropertyFlags.h index 9b21ff9f9f..846c4886b0 100644 --- a/libraries/shared/src/PropertyFlags.h +++ b/libraries/shared/src/PropertyFlags.h @@ -49,7 +49,7 @@ public: Enum lastFlag() const { return (Enum)_maxFlag; } void setHasProperty(Enum flag, bool value = true); - bool getHasProperty(Enum flag); + bool getHasProperty(Enum flag) const; QByteArray encode(); void decode(const QByteArray& fromEncoded); @@ -61,42 +61,42 @@ public: PropertyFlags& operator=(const PropertyFlags& other); - PropertyFlags& operator|=(PropertyFlags other); + PropertyFlags& operator|=(const PropertyFlags& other); PropertyFlags& operator|=(Enum flag); - PropertyFlags& operator&=(PropertyFlags other); + PropertyFlags& operator&=(const PropertyFlags& other); PropertyFlags& operator&=(Enum flag); - PropertyFlags& operator+=(PropertyFlags other); + PropertyFlags& operator+=(const PropertyFlags& other); PropertyFlags& operator+=(Enum flag); - PropertyFlags& operator-=(PropertyFlags other); + PropertyFlags& operator-=(const PropertyFlags& other); PropertyFlags& operator-=(Enum flag); - PropertyFlags& operator<<=(PropertyFlags other); + PropertyFlags& operator<<=(const PropertyFlags& other); PropertyFlags& operator<<=(Enum flag); - PropertyFlags operator|(PropertyFlags other) const; + PropertyFlags operator|(const PropertyFlags& other) const; PropertyFlags operator|(Enum flag) const; - PropertyFlags operator&(PropertyFlags other) const; + PropertyFlags operator&(const PropertyFlags& other) const; PropertyFlags operator&(Enum flag) const; - PropertyFlags operator+(PropertyFlags other) const; + PropertyFlags operator+(const PropertyFlags& other) const; PropertyFlags operator+(Enum flag) const; - PropertyFlags operator-(PropertyFlags other) const; + PropertyFlags operator-(const PropertyFlags& other) const; PropertyFlags operator-(Enum flag) const; - PropertyFlags operator<<(PropertyFlags other) const; + PropertyFlags operator<<(const PropertyFlags& other) const; PropertyFlags operator<<(Enum flag) const; // NOTE: due to the nature of the compact storage of these property flags, and the fact that the upper bound of the // enum is not know, these operators will only perform their bitwise operations on the set of properties that have // been previously set - PropertyFlags& operator^=(PropertyFlags other); + PropertyFlags& operator^=(const PropertyFlags& other); PropertyFlags& operator^=(Enum flag); - PropertyFlags operator^(PropertyFlags other) const; + PropertyFlags operator^(const PropertyFlags& other) const; PropertyFlags operator^(Enum flag) const; PropertyFlags operator~() const; @@ -146,7 +146,7 @@ template inline void PropertyFlags::setHasProperty(Enum fla } } -template inline bool PropertyFlags::getHasProperty(Enum flag) { +template inline bool PropertyFlags::getHasProperty(Enum flag) const { if (flag > _maxFlag) { return _trailingFlipped; // usually false } @@ -253,7 +253,7 @@ template inline PropertyFlags& PropertyFlags::operato return *this; } -template inline PropertyFlags& PropertyFlags::operator|=(PropertyFlags other) { +template inline PropertyFlags& PropertyFlags::operator|=(const PropertyFlags& other) { _flags |= other._flags; _maxFlag = std::max(_maxFlag, other._maxFlag); _minFlag = std::min(_minFlag, other._minFlag); @@ -268,7 +268,7 @@ template inline PropertyFlags& PropertyFlags::operato return *this; } -template inline PropertyFlags& PropertyFlags::operator&=(PropertyFlags other) { +template inline PropertyFlags& PropertyFlags::operator&=(const PropertyFlags& other) { _flags &= other._flags; shinkIfNeeded(); return *this; @@ -281,7 +281,7 @@ template inline PropertyFlags& PropertyFlags::operato return *this; } -template inline PropertyFlags& PropertyFlags::operator^=(PropertyFlags other) { +template inline PropertyFlags& PropertyFlags::operator^=(const PropertyFlags& other) { _flags ^= other._flags; shinkIfNeeded(); return *this; @@ -294,7 +294,7 @@ template inline PropertyFlags& PropertyFlags::operato return *this; } -template inline PropertyFlags& PropertyFlags::operator+=(PropertyFlags other) { +template inline PropertyFlags& PropertyFlags::operator+=(const PropertyFlags& other) { for(int flag = (int)other.firstFlag(); flag <= (int)other.lastFlag(); flag++) { if (other.getHasProperty((Enum)flag)) { setHasProperty((Enum)flag, true); @@ -308,7 +308,7 @@ template inline PropertyFlags& PropertyFlags::operato return *this; } -template inline PropertyFlags& PropertyFlags::operator-=(PropertyFlags other) { +template inline PropertyFlags& PropertyFlags::operator-=(const PropertyFlags& other) { for(int flag = (int)other.firstFlag(); flag <= (int)other.lastFlag(); flag++) { if (other.getHasProperty((Enum)flag)) { setHasProperty((Enum)flag, false); @@ -322,7 +322,7 @@ template inline PropertyFlags& PropertyFlags::operato return *this; } -template inline PropertyFlags& PropertyFlags::operator<<=(PropertyFlags other) { +template inline PropertyFlags& PropertyFlags::operator<<=(const PropertyFlags& other) { for(int flag = (int)other.firstFlag(); flag <= (int)other.lastFlag(); flag++) { if (other.getHasProperty((Enum)flag)) { setHasProperty((Enum)flag, true); @@ -336,7 +336,7 @@ template inline PropertyFlags& PropertyFlags::operato return *this; } -template inline PropertyFlags PropertyFlags::operator|(PropertyFlags other) const { +template inline PropertyFlags PropertyFlags::operator|(const PropertyFlags& other) const { PropertyFlags result(*this); result |= other; return result; @@ -349,7 +349,7 @@ template inline PropertyFlags PropertyFlags::operator return result; } -template inline PropertyFlags PropertyFlags::operator&(PropertyFlags other) const { +template inline PropertyFlags PropertyFlags::operator&(const PropertyFlags& other) const { PropertyFlags result(*this); result &= other; return result; @@ -362,7 +362,7 @@ template inline PropertyFlags PropertyFlags::operator return result; } -template inline PropertyFlags PropertyFlags::operator^(PropertyFlags other) const { +template inline PropertyFlags PropertyFlags::operator^(const PropertyFlags& other) const { PropertyFlags result(*this); result ^= other; return result; @@ -375,7 +375,7 @@ template inline PropertyFlags PropertyFlags::operator return result; } -template inline PropertyFlags PropertyFlags::operator+(PropertyFlags other) const { +template inline PropertyFlags PropertyFlags::operator+(const PropertyFlags& other) const { PropertyFlags result(*this); result += other; return result; @@ -387,7 +387,7 @@ template inline PropertyFlags PropertyFlags::operator return result; } -template inline PropertyFlags PropertyFlags::operator-(PropertyFlags other) const { +template inline PropertyFlags PropertyFlags::operator-(const PropertyFlags& other) const { PropertyFlags result(*this); result -= other; return result; @@ -399,7 +399,7 @@ template inline PropertyFlags PropertyFlags::operator return result; } -template inline PropertyFlags PropertyFlags::operator<<(PropertyFlags other) const { +template inline PropertyFlags PropertyFlags::operator<<(const PropertyFlags& other) const { PropertyFlags result(*this); result <<= other; return result; From ceb1740f381c3de55220d1b409c188e8e1a15472 Mon Sep 17 00:00:00 2001 From: ZappoMan Date: Thu, 11 Sep 2014 12:23:35 -0700 Subject: [PATCH 24/29] handy conversions between AABox, AACube, and Extents --- libraries/shared/src/AABox.cpp | 6 ++++++ libraries/shared/src/AABox.h | 2 ++ libraries/shared/src/AACube.cpp | 14 ++++++++++++++ libraries/shared/src/AACube.h | 5 ++++- 4 files changed, 26 insertions(+), 1 deletion(-) diff --git a/libraries/shared/src/AABox.cpp b/libraries/shared/src/AABox.cpp index 4c01801d5d..00e6db7d33 100644 --- a/libraries/shared/src/AABox.cpp +++ b/libraries/shared/src/AABox.cpp @@ -11,6 +11,7 @@ #include "AABox.h" #include "AACube.h" +#include "Extents.h" #include "GeometryUtil.h" #include "SharedUtil.h" @@ -19,6 +20,11 @@ AABox::AABox(const AACube& other) : _corner(other.getCorner()), _scale(other.getScale(), other.getScale(), other.getScale()) { } +AABox::AABox(const Extents& other) : + _corner(other.minimum), + _scale(other.maximum - other.minimum) { +} + AABox::AABox(const glm::vec3& corner, float size) : _corner(corner), _scale(size, size, size) { }; diff --git a/libraries/shared/src/AABox.h b/libraries/shared/src/AABox.h index 30ebc00afb..5e5cff4574 100644 --- a/libraries/shared/src/AABox.h +++ b/libraries/shared/src/AABox.h @@ -23,11 +23,13 @@ #include "StreamUtils.h" class AACube; +class Extents; class AABox { public: AABox(const AACube& other); + AABox(const Extents& other); AABox(const glm::vec3& corner, float size); AABox(const glm::vec3& corner, const glm::vec3& dimensions); AABox(); diff --git a/libraries/shared/src/AACube.cpp b/libraries/shared/src/AACube.cpp index bf8e972455..55940ba50b 100644 --- a/libraries/shared/src/AACube.cpp +++ b/libraries/shared/src/AACube.cpp @@ -9,11 +9,25 @@ // See the accompanying file LICENSE or http://www.apache.org/licenses/LICENSE-2.0.html // +#include + #include "AABox.h" #include "AACube.h" +#include "Extents.h" #include "GeometryUtil.h" #include "SharedUtil.h" +AACube::AACube(const AABox& other) : + _corner(other.getCorner()), _scale(other.getLargestDimension()) { +} + +AACube::AACube(const Extents& other) : + _corner(other.minimum) +{ + glm::vec3 dimensions = other.maximum - other.minimum; + _scale = glm::max(dimensions.x, dimensions.y, dimensions.z); +} + AACube::AACube(const glm::vec3& corner, float size) : _corner(corner), _scale(size) { }; diff --git a/libraries/shared/src/AACube.h b/libraries/shared/src/AACube.h index 705c025d74..f56f2dee2e 100644 --- a/libraries/shared/src/AACube.h +++ b/libraries/shared/src/AACube.h @@ -1,6 +1,6 @@ // // AACube.h -// libraries/octree/src +// libraries/shared/src // // Created by Brad Hefta-Gaub on 04/11/13. // Copyright 2013 High Fidelity, Inc. @@ -22,10 +22,13 @@ #include "BoxBase.h" class AABox; +class Extents; class AACube { public: + AACube(const AABox& other); + AACube(const Extents& other); AACube(const glm::vec3& corner, float size); AACube(); ~AACube() {}; From 7db2930d9128a8f1f4cffaed6c5b3009b061c2b8 Mon Sep 17 00:00:00 2001 From: ZappoMan Date: Thu, 11 Sep 2014 12:29:47 -0700 Subject: [PATCH 25/29] remove calls to calculateRotatedExtents() use Extents.rotate() instead --- .../entities/RenderableModelEntityItem.cpp | 2 +- interface/src/ui/overlays/ModelOverlay.cpp | 2 +- libraries/entities/src/EntityTreeElement.cpp | 2 +- libraries/fbx/src/FBXReader.cpp | 37 ------------------- libraries/fbx/src/FBXReader.h | 2 - 5 files changed, 3 insertions(+), 42 deletions(-) diff --git a/interface/src/entities/RenderableModelEntityItem.cpp b/interface/src/entities/RenderableModelEntityItem.cpp index e2a710123e..03812904b5 100644 --- a/interface/src/entities/RenderableModelEntityItem.cpp +++ b/interface/src/entities/RenderableModelEntityItem.cpp @@ -144,7 +144,7 @@ void RenderableModelEntityItem::render(RenderArgs* args) { float depth = unRotatedExtents.z; Extents rotatedExtents = _model->getUnscaledMeshExtents(); - calculateRotatedExtents(rotatedExtents, rotation); + rotatedExtents.rotate(rotation); glm::vec3 rotatedSize = rotatedExtents.maximum - rotatedExtents.minimum; diff --git a/interface/src/ui/overlays/ModelOverlay.cpp b/interface/src/ui/overlays/ModelOverlay.cpp index b1d55de12a..8d89fe28f0 100644 --- a/interface/src/ui/overlays/ModelOverlay.cpp +++ b/interface/src/ui/overlays/ModelOverlay.cpp @@ -58,7 +58,7 @@ void ModelOverlay::render() { float depth = unRotatedExtents.z; Extents rotatedExtents = _model.getUnscaledMeshExtents(); - calculateRotatedExtents(rotatedExtents, _rotation); + rotatedExtents.rotate(_rotation); glm::vec3 rotatedSize = rotatedExtents.maximum - rotatedExtents.minimum; diff --git a/libraries/entities/src/EntityTreeElement.cpp b/libraries/entities/src/EntityTreeElement.cpp index 8f223abf7e..4dea9b271c 100644 --- a/libraries/entities/src/EntityTreeElement.cpp +++ b/libraries/entities/src/EntityTreeElement.cpp @@ -509,7 +509,7 @@ bool EntityTreeElement::findDetailedRayIntersection(const glm::vec3& origin, con Extents rotatedExtents = extents; - calculateRotatedExtents(rotatedExtents, entity->getRotation()); + rotatedExtents.rotate(entity->getRotation()); rotatedExtents.minimum += entity->getPosition(); rotatedExtents.maximum += entity->getPosition(); diff --git a/libraries/fbx/src/FBXReader.cpp b/libraries/fbx/src/FBXReader.cpp index 88888ac381..d81e297b24 100644 --- a/libraries/fbx/src/FBXReader.cpp +++ b/libraries/fbx/src/FBXReader.cpp @@ -2111,40 +2111,3 @@ FBXGeometry readSVO(const QByteArray& model) { return geometry; } - -void calculateRotatedExtents(Extents& extents, const glm::quat& rotation) { - glm::vec3 bottomLeftNear(extents.minimum.x, extents.minimum.y, extents.minimum.z); - glm::vec3 bottomRightNear(extents.maximum.x, extents.minimum.y, extents.minimum.z); - glm::vec3 bottomLeftFar(extents.minimum.x, extents.minimum.y, extents.maximum.z); - glm::vec3 bottomRightFar(extents.maximum.x, extents.minimum.y, extents.maximum.z); - glm::vec3 topLeftNear(extents.minimum.x, extents.maximum.y, extents.minimum.z); - glm::vec3 topRightNear(extents.maximum.x, extents.maximum.y, extents.minimum.z); - glm::vec3 topLeftFar(extents.minimum.x, extents.maximum.y, extents.maximum.z); - glm::vec3 topRightFar(extents.maximum.x, extents.maximum.y, extents.maximum.z); - - glm::vec3 bottomLeftNearRotated = rotation * bottomLeftNear; - glm::vec3 bottomRightNearRotated = rotation * bottomRightNear; - glm::vec3 bottomLeftFarRotated = rotation * bottomLeftFar; - glm::vec3 bottomRightFarRotated = rotation * bottomRightFar; - glm::vec3 topLeftNearRotated = rotation * topLeftNear; - glm::vec3 topRightNearRotated = rotation * topRightNear; - glm::vec3 topLeftFarRotated = rotation * topLeftFar; - glm::vec3 topRightFarRotated = rotation * topRightFar; - - extents.minimum = glm::min(bottomLeftNearRotated, - glm::min(bottomRightNearRotated, - glm::min(bottomLeftFarRotated, - glm::min(bottomRightFarRotated, - glm::min(topLeftNearRotated, - glm::min(topRightNearRotated, - glm::min(topLeftFarRotated,topRightFarRotated))))))); - - extents.maximum = glm::max(bottomLeftNearRotated, - glm::max(bottomRightNearRotated, - glm::max(bottomLeftFarRotated, - glm::max(bottomRightFarRotated, - glm::max(topLeftNearRotated, - glm::max(topRightNearRotated, - glm::max(topLeftFarRotated,topRightFarRotated))))))); -} - diff --git a/libraries/fbx/src/FBXReader.h b/libraries/fbx/src/FBXReader.h index e54e218a5b..48ac4fc81f 100644 --- a/libraries/fbx/src/FBXReader.h +++ b/libraries/fbx/src/FBXReader.h @@ -231,6 +231,4 @@ FBXGeometry readFBX(const QByteArray& model, const QVariantHash& mapping); /// Reads SVO geometry from the supplied model data. FBXGeometry readSVO(const QByteArray& model); -void calculateRotatedExtents(Extents& extents, const glm::quat& rotation); - #endif // hifi_FBXReader_h From 81758c9df6ce5959f73f41f42c31146933d23f82 Mon Sep 17 00:00:00 2001 From: Stephen Birarda Date: Thu, 11 Sep 2014 14:12:23 -0700 Subject: [PATCH 26/29] fix for drive key clear enumeration --- interface/src/avatar/MyAvatar.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/interface/src/avatar/MyAvatar.cpp b/interface/src/avatar/MyAvatar.cpp index 241b39028f..ff4edaec94 100644 --- a/interface/src/avatar/MyAvatar.cpp +++ b/interface/src/avatar/MyAvatar.cpp @@ -1974,7 +1974,7 @@ glm::vec3 MyAvatar::getLaserPointerTipPosition(const PalmData* palm) { } void MyAvatar::clearDriveKeys() { - for (int i = 0; i < sizeof(_driveKeys); i++) { + for (int i = 0; i < MAX_DRIVE_KEYS; i++) { _driveKeys[i] = 0.0f; } } From 52176786d063323509ffd511eb53366aedc0d15c Mon Sep 17 00:00:00 2001 From: Stephen Birarda Date: Thu, 11 Sep 2014 14:13:39 -0700 Subject: [PATCH 27/29] use prefix and not postfix operator --- interface/src/avatar/MyAvatar.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/interface/src/avatar/MyAvatar.cpp b/interface/src/avatar/MyAvatar.cpp index ff4edaec94..9a040b7328 100644 --- a/interface/src/avatar/MyAvatar.cpp +++ b/interface/src/avatar/MyAvatar.cpp @@ -1974,7 +1974,7 @@ glm::vec3 MyAvatar::getLaserPointerTipPosition(const PalmData* palm) { } void MyAvatar::clearDriveKeys() { - for (int i = 0; i < MAX_DRIVE_KEYS; i++) { + for (int i = 0; i < MAX_DRIVE_KEYS; ++i) { _driveKeys[i] = 0.0f; } } From 1d0ba52445d2b750ac7626c8bd05d6563a576e14 Mon Sep 17 00:00:00 2001 From: Craig Hansen-Sturm Date: Thu, 11 Sep 2014 17:15:49 -0700 Subject: [PATCH 28/29] implemented new audio panning object which implements constant power sin^2+cos^2=1 law --- interface/src/Audio.h | 1 + libraries/audio/src/AudioPan.cpp | 23 +++++ libraries/audio/src/AudioPan.h | 141 +++++++++++++++++++++++++++++++ 3 files changed, 165 insertions(+) create mode 100644 libraries/audio/src/AudioPan.cpp create mode 100644 libraries/audio/src/AudioPan.h diff --git a/interface/src/Audio.h b/interface/src/Audio.h index f73e0331de..f100c04684 100644 --- a/interface/src/Audio.h +++ b/interface/src/Audio.h @@ -26,6 +26,7 @@ #include "AudioSourceTone.h" #include "AudioSourceNoise.h" #include "AudioGain.h" +#include "AudioPan.h" #include "AudioFilter.h" #include "AudioFilterBank.h" diff --git a/libraries/audio/src/AudioPan.cpp b/libraries/audio/src/AudioPan.cpp new file mode 100644 index 0000000000..8f9b568b6a --- /dev/null +++ b/libraries/audio/src/AudioPan.cpp @@ -0,0 +1,23 @@ +// +// AudioSourceTone.cpp +// hifi +// +// Created by Craig Hansen-Sturm on 8/10/14. +// Copyright 2014 High Fidelity, Inc. +// +// Distributed under the Apache License, Version 2.0. +// See the accompanying file LICENSE or http://www.apache.org/licenses/LICENSE-2.0.html +// + +#include +#include +#include +#include "AudioRingBuffer.h" +#include "AudioFormat.h" +#include "AudioBuffer.h" +#include "AudioPan.h" + +float32_t AudioPan::ONE_MINUS_EPSILON = 1.0f - EPSILON; +float32_t AudioPan::ZERO_PLUS_EPSILON = 0.0f + EPSILON; +float32_t AudioPan::ONE_HALF_MINUS_EPSILON = 0.5f - EPSILON; +float32_t AudioPan::ONE_HALF_PLUS_EPSILON = 0.5f + EPSILON; diff --git a/libraries/audio/src/AudioPan.h b/libraries/audio/src/AudioPan.h new file mode 100644 index 0000000000..85e739b255 --- /dev/null +++ b/libraries/audio/src/AudioPan.h @@ -0,0 +1,141 @@ +// +// AudioPan.h +// hifi +// +// Created by Craig Hansen-Sturm on 9/1/14. +// Copyright 2014 High Fidelity, Inc. +// +// Distributed under the Apache License, Version 2.0. +// See the accompanying file LICENSE or http://www.apache.org/licenses/LICENSE-2.0.html +// + +#ifndef hifi_AudioPan_h +#define hifi_AudioPan_h + +class AudioPan +{ + float32_t _pan; + float32_t _gainLeft; + float32_t _gainRight; + + static float32_t ONE_MINUS_EPSILON; + static float32_t ZERO_PLUS_EPSILON; + static float32_t ONE_HALF_MINUS_EPSILON; + static float32_t ONE_HALF_PLUS_EPSILON; + + void updateCoefficients() { + + // implement constant power sin^2 + cos^2 = 1 panning law + + if (_pan >= ONE_MINUS_EPSILON) { // full right + _gainLeft = 0.0f; + _gainRight = 1.0f; + } + else if (_pan <= ZERO_PLUS_EPSILON) { // full left + _gainLeft = 1.0f; + _gainRight = 0.0f; + } + else if ((_pan >= ONE_HALF_MINUS_EPSILON) && (_pan <= ONE_HALF_PLUS_EPSILON)) { // center + _gainLeft = 1.0f / SQUARE_ROOT_OF_2; + _gainRight = 1.0f / SQUARE_ROOT_OF_2; + } + else { // intermediate cases + _gainLeft = cosf( TWO_PI * _pan ); + _gainRight = sinf( TWO_PI * _pan ); + } + } + +public: + AudioPan() { + initialize(); + } + + ~AudioPan() { + finalize(); + } + + void initialize() { + setParameters(0.5f); + } + + void finalize() { + } + + void reset() { + initialize(); + } + + void setParameters(const float32_t pan) { + // pan ranges between 0.0 and 1.0f inclusive. 0.5f is midpoint between full left and full right + _pan = std::min(std::max(pan, 0.0f), 1.0f); + updateCoefficients(); + } + + void getParameters(float32_t& pan) { + pan = _pan; + } + + void render(AudioBufferFloat32& frameBuffer) { + + if (frameBuffer.getChannelCount() != 2) { + return; + } + + float32_t** samples = frameBuffer.getFrameData(); + + bool frameAlignment16 = (frameBuffer.getFrameCount() & 0x0F) == 0; + if (frameAlignment16) { + + if (frameBuffer.getChannelCount() == 2) { + + for (uint16_t i = 0; i < frameBuffer.getFrameCount(); i += 16) { + samples[0][i + 0] *= _gainLeft; + samples[0][i + 1] *= _gainLeft; + samples[0][i + 2] *= _gainLeft; + samples[0][i + 3] *= _gainLeft; + samples[0][i + 4] *= _gainLeft; + samples[0][i + 5] *= _gainLeft; + samples[0][i + 6] *= _gainLeft; + samples[0][i + 7] *= _gainLeft; + samples[0][i + 8] *= _gainLeft; + samples[0][i + 9] *= _gainLeft; + samples[0][i + 10] *= _gainLeft; + samples[0][i + 11] *= _gainLeft; + samples[0][i + 12] *= _gainLeft; + samples[0][i + 13] *= _gainLeft; + samples[0][i + 14] *= _gainLeft; + samples[0][i + 15] *= _gainLeft; + samples[1][i + 0] *= _gainRight; + samples[1][i + 1] *= _gainRight; + samples[1][i + 2] *= _gainRight; + samples[1][i + 3] *= _gainRight; + samples[1][i + 4] *= _gainRight; + samples[1][i + 5] *= _gainRight; + samples[1][i + 6] *= _gainRight; + samples[1][i + 7] *= _gainRight; + samples[1][i + 8] *= _gainRight; + samples[1][i + 9] *= _gainRight; + samples[1][i + 10] *= _gainRight; + samples[1][i + 11] *= _gainRight; + samples[1][i + 12] *= _gainRight; + samples[1][i + 13] *= _gainRight; + samples[1][i + 14] *= _gainRight; + samples[1][i + 15] *= _gainRight; + } + } + else { + assert("unsupported channel format"); + } + } + else { + for (uint16_t i = 0; i < frameBuffer.getFrameCount(); i += 1) { + samples[0][i] *= _gainLeft; + samples[1][i] *= _gainRight; + } + } + } +}; + +#endif // AudioPan_h + + From ecae9d5e85d998333fcd9e3c3366d1c3cc50ff7d Mon Sep 17 00:00:00 2001 From: Craig Hansen-Sturm Date: Thu, 11 Sep 2014 17:20:15 -0700 Subject: [PATCH 29/29] compiler warnings --- interface/src/Application.cpp | 2 +- interface/src/Audio.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/interface/src/Application.cpp b/interface/src/Application.cpp index 273b66e4dc..4261858668 100644 --- a/interface/src/Application.cpp +++ b/interface/src/Application.cpp @@ -3370,7 +3370,7 @@ void Application::updateWindowTitle(){ #ifndef WIN32 // crashes with vs2013/win32 qDebug("Application title set to: %s", title.toStdString().c_str()); -#endif !WIN32 +#endif //!WIN32 _window->setWindowTitle(title); } diff --git a/interface/src/Audio.cpp b/interface/src/Audio.cpp index 9427ec0525..885df74d2b 100644 --- a/interface/src/Audio.cpp +++ b/interface/src/Audio.cpp @@ -102,9 +102,9 @@ Audio::Audio(QObject* parent) : _scopeOutputOffset(0), _framesPerScope(DEFAULT_FRAMES_PER_SCOPE), _samplesPerScope(NETWORK_SAMPLES_PER_FRAME * _framesPerScope), - _peqEnabled(false), _noiseSourceEnabled(false), _toneSourceEnabled(true), + _peqEnabled(false), _scopeInput(0), _scopeOutputLeft(0), _scopeOutputRight(0),