Merge pull request #7143 from imgntn/webengine-new-windows

Add support for pop-up windows to Qt WebEngineView

interface/resources/qml/Browser.qml

@@ -14,7 +14,8 @@ Window {
     destroyOnInvisible: true
     width: 800
     height: 600
-
+    property alias webView: webview
+    
     Component.onCompleted: {
         visible = true
         addressBar.text = webview.url
@@ -28,6 +29,7 @@ Window {
     }
 
     Item {
+        id:item
         anchors.fill: parent
         Rectangle {
             anchors.left: parent.left
@@ -125,12 +127,10 @@ Window {
                 console.log("New icon: " + icon)
             }
             
-            profile: WebEngineProfile {
-                id: webviewProfile
-                storageName: "qmlUserBrowser"
-            }
-
+            profile: desktop.browserProfile
+    
         }
+
     } // item
     
     Keys.onPressed: {

interface/resources/qml/controls/WebView.qml

@@ -53,9 +53,12 @@ WebEngineView {
         }
     }
 
-    profile: WebEngineProfile {
-        id: webviewProfile
-        httpUserAgent: "Mozilla/5.0 (HighFidelityInterface)"
-        storageName: "qmlWebEngine"
+    onNewViewRequested:{
+            var component = Qt.createComponent("../Browser.qml");
+            var newWindow = component.createObject(desktop);
+            request.openIn(newWindow.webView)
     }
+
+
+    profile: desktop.browserProfile
 }

interface/resources/qml/hifi/Desktop.qml

@@ -9,7 +9,7 @@ Desktop {
     id: desktop
 
     Component.onCompleted: {
-        WebEngine.settings.javascriptCanOpenWindows = false;
+        WebEngine.settings.javascriptCanOpenWindows = true;
         WebEngine.settings.javascriptCanAccessClipboard = false;
         WebEngine.settings.spatialNavigationEnabled = true;
         WebEngine.settings.localContentCanAccessRemoteUrls = true;
@@ -19,6 +19,12 @@ Desktop {
     property alias toolWindow: toolWindow
     ToolWindow { id: toolWindow }
 
+    property var browserProfile: WebEngineProfile {
+        id: webviewProfile
+        httpUserAgent: "Chrome/48.0 (HighFidelityInterface)"
+        storageName: "qmlWebEngine"
+    }
+
     Action {
         text: "Open Browser"
         shortcut: "Ctrl+B"