From d410cb4fda5b90e171e0d882b2b316d1a0228b41 Mon Sep 17 00:00:00 2001
From: "Anthony J. Thibault" <tony@highfidelity.io>
Date: Sat, 24 Aug 2019 11:12:28 -0700
Subject: [PATCH 1/2] Added "shutdown" crash annotation and crash menu option

---
 interface/src/Application.cpp | 16 ++++++++++++++++
 interface/src/Application.h   |  5 +++++
 interface/src/Menu.cpp        |  2 ++
 interface/src/Menu.h          |  1 +
 4 files changed, 24 insertions(+)

diff --git a/interface/src/Application.cpp b/interface/src/Application.cpp
index 090cdd52b6..b957c7073c 100644
--- a/interface/src/Application.cpp
+++ b/interface/src/Application.cpp
@@ -167,6 +167,7 @@
 #include "avatar/MyCharacterController.h"
 #include "CrashRecoveryHandler.h"
 #include "CrashHandler.h"
+#include <CrashHelpers.h>
 #include "devices/DdeFaceTracker.h"
 #include "DiscoverabilityManager.h"
 #include "GLCanvas.h"
@@ -2675,6 +2676,8 @@ void Application::updateHeartbeat() const {
 }
 
 void Application::onAboutToQuit() {
+    setCrashAnnotation("shutdown", "1");
+
     // quickly save AvatarEntityData before the EntityTree is dismantled
     getMyAvatar()->saveAvatarEntityDataToSettings();
 
@@ -2713,6 +2716,11 @@ void Application::onAboutToQuit() {
 
     cleanupBeforeQuit();
 
+    if (_crashOnShutdown) {
+        // triggered by crash menu
+        crash::nullDeref();
+    }
+
     getRefreshRateManager().setRefreshRateRegime(RefreshRateManager::RefreshRateRegime::SHUTDOWN);
 }
 
@@ -9522,6 +9530,14 @@ void Application::showUrlHandler(const QUrl& url) {
         }
     });
 }
+
+// used to test "shutdown" crash annotation.
+void Application::crashOnShutdown() {
+    qDebug() << "crashOnShutdown(), ON PURPOSE!";
+    _crashOnShutdown = true;
+    quit();
+}
+
 void Application::overrideEntry(){
     _overrideEntry = true;
 }
diff --git a/interface/src/Application.h b/interface/src/Application.h
index 913671473d..20abbf2baf 100644
--- a/interface/src/Application.h
+++ b/interface/src/Application.h
@@ -497,6 +497,9 @@ public slots:
     bool gpuTextureMemSizeStable();
     void showUrlHandler(const QUrl& url);
 
+    // used to test "shutdown" crash annotation.
+    void crashOnShutdown();
+
 private slots:
     void onDesktopRootItemCreated(QQuickItem* qmlContext);
     void onDesktopRootContextCreated(QQmlContext* qmlContext);
@@ -844,5 +847,7 @@ private:
     bool _overrideEntry { false };
 
     VisionSqueeze _visionSqueeze;
+
+    bool _crashOnShutdown { false };
 };
 #endif // hifi_Application_h
diff --git a/interface/src/Menu.cpp b/interface/src/Menu.cpp
index 4cf78c23ee..8c6292681b 100644
--- a/interface/src/Menu.cpp
+++ b/interface/src/Menu.cpp
@@ -763,6 +763,8 @@ Menu::Menu() {
     action = addActionToQMenuAndActionHash(crashMenu, MenuOption::CrashNewFaultThreaded);
     connect(action, &QAction::triggered, qApp, []() { std::thread(crash::newFault).join(); });
 
+    addActionToQMenuAndActionHash(crashMenu, MenuOption::CrashOnShutdown, 0, qApp, SLOT(crashOnShutdown()));
+
     // Developer > Show Statistics
     addCheckableActionToQMenuAndActionHash(developerMenu, MenuOption::Stats, 0, true);
 
diff --git a/interface/src/Menu.h b/interface/src/Menu.h
index 70687786a9..7dff264adc 100644
--- a/interface/src/Menu.h
+++ b/interface/src/Menu.h
@@ -72,6 +72,7 @@ namespace MenuOption {
     const QString CrashNullDereferenceThreaded = "Null Dereference (threaded)";
     const QString CrashAbort = "Abort";
     const QString CrashAbortThreaded = "Abort (threaded)";
+    const QString CrashOnShutdown = "Crash During Shutdown";
     const QString CrashOutOfBoundsVectorAccess = "Out of Bounds Vector Access";
     const QString CrashOutOfBoundsVectorAccessThreaded = "Out of Bounds Vector Access (threaded)";
     const QString CrashNewFault = "New Fault";

From e98cdab2946b1d805f9ac838522b6893eaead1f6 Mon Sep 17 00:00:00 2001
From: "Anthony J. Thibault" <tony@highfidelity.io>
Date: Mon, 26 Aug 2019 17:05:08 -0700
Subject: [PATCH 2/2] Moved CrashHelper.h include to the appropriate place.

---
 interface/src/Application.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/interface/src/Application.cpp b/interface/src/Application.cpp
index b957c7073c..0fc273fa35 100644
--- a/interface/src/Application.cpp
+++ b/interface/src/Application.cpp
@@ -73,6 +73,7 @@
 #include <Midi.h>
 #include <AudioInjectorManager.h>
 #include <AvatarBookmarks.h>
+#include <CrashHelpers.h>
 #include <CursorManager.h>
 #include <VirtualPadManager.h>
 #include <DebugDraw.h>
@@ -167,7 +168,6 @@
 #include "avatar/MyCharacterController.h"
 #include "CrashRecoveryHandler.h"
 #include "CrashHandler.h"
-#include <CrashHelpers.h>
 #include "devices/DdeFaceTracker.h"
 #include "DiscoverabilityManager.h"
 #include "GLCanvas.h"