From 49fd4137226cf78a51036408e52d3e3f28f16b7a Mon Sep 17 00:00:00 2001 From: Stephen Birarda Date: Tue, 25 Mar 2014 11:50:25 -0700 Subject: [PATCH 1/4] fix for stats styling --- domain-server/resources/web/css/style.css | 4 ++++ domain-server/resources/web/stats/js/stats.js | 5 +++-- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/domain-server/resources/web/css/style.css b/domain-server/resources/web/css/style.css index fb295cffc3..ff33cc206b 100644 --- a/domain-server/resources/web/css/style.css +++ b/domain-server/resources/web/css/style.css @@ -40,6 +40,10 @@ span.port { color: #666666; } +.stats-key { + width: 400px; +} + .stale { color: red; } \ No newline at end of file diff --git a/domain-server/resources/web/stats/js/stats.js b/domain-server/resources/web/stats/js/stats.js index a7b0aecfcf..74d58c72c0 100644 --- a/domain-server/resources/web/stats/js/stats.js +++ b/domain-server/resources/web/stats/js/stats.js @@ -21,8 +21,9 @@ $(document).ready(function(){ $.each(json, function(key, value) { statsTableBody += ""; - statsTableBody += "" + key + ""; - statsTableBody += "" + value + ""; + statsTableBody += "" + key + ""; + var formattedValue = (typeof value == 'number' ? value.toLocaleString() : value); + statsTableBody += "" + formattedValue + ""; statsTableBody += ""; }); From 1fe01f3e61bb6168375313de27fe740b1fe69c17 Mon Sep 17 00:00:00 2001 From: Stephen Birarda Date: Tue, 25 Mar 2014 12:16:07 -0700 Subject: [PATCH 2/4] increment framesSinceCutoffEvent in mixers to enable recovery --- assignment-client/src/audio/AudioMixer.cpp | 4 ++++ assignment-client/src/avatars/AvatarMixer.cpp | 4 ++++ 2 files changed, 8 insertions(+) diff --git a/assignment-client/src/audio/AudioMixer.cpp b/assignment-client/src/audio/AudioMixer.cpp index 450b6e0ad9..82674e5141 100644 --- a/assignment-client/src/audio/AudioMixer.cpp +++ b/assignment-client/src/audio/AudioMixer.cpp @@ -455,6 +455,10 @@ void AudioMixer::run() { } } + if (!hasRatioChanged) { + ++framesSinceCutoffEvent; + } + foreach (const SharedNodePointer& node, nodeList->getNodeHash()) { if (node->getType() == NodeType::Agent && node->getActiveSocket() && node->getLinkedData() && ((AudioMixerClientData*) node->getLinkedData())->getAvatarAudioRingBuffer()) { diff --git a/assignment-client/src/avatars/AvatarMixer.cpp b/assignment-client/src/avatars/AvatarMixer.cpp index 54f1943930..f0a2b68050 100644 --- a/assignment-client/src/avatars/AvatarMixer.cpp +++ b/assignment-client/src/avatars/AvatarMixer.cpp @@ -306,6 +306,10 @@ void AvatarMixer::run() { } } + if (!hasRatioChanged) { + ++framesSinceCutoffEvent; + } + broadcastAvatarData(); QCoreApplication::processEvents(); From 9d6dac6a76fe7612fcc24fa51e8d46a6b763f75f Mon Sep 17 00:00:00 2001 From: Stephen Birarda Date: Tue, 25 Mar 2014 12:18:28 -0700 Subject: [PATCH 3/4] suppress sleep time debug in favour of stats in AvatarMixer --- assignment-client/src/avatars/AvatarMixer.cpp | 2 -- 1 file changed, 2 deletions(-) diff --git a/assignment-client/src/avatars/AvatarMixer.cpp b/assignment-client/src/avatars/AvatarMixer.cpp index f0a2b68050..65e0acd4a6 100644 --- a/assignment-client/src/avatars/AvatarMixer.cpp +++ b/assignment-client/src/avatars/AvatarMixer.cpp @@ -322,8 +322,6 @@ void AvatarMixer::run() { if (usecToSleep > 0) { usleep(usecToSleep); - } else { - qDebug() << "AvatarMixer loop took too" << -usecToSleep << "of extra time. Won't sleep."; } } } From bc1b7045cbd02ae56e2d5816689b57028dad9bd7 Mon Sep 17 00:00:00 2001 From: Stephen Birarda Date: Tue, 25 Mar 2014 12:30:06 -0700 Subject: [PATCH 4/4] output count of unreplied domain-server check ins --- libraries/shared/src/ThreadedAssignment.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libraries/shared/src/ThreadedAssignment.cpp b/libraries/shared/src/ThreadedAssignment.cpp index f4ea383399..642f471cc5 100644 --- a/libraries/shared/src/ThreadedAssignment.cpp +++ b/libraries/shared/src/ThreadedAssignment.cpp @@ -82,9 +82,9 @@ void ThreadedAssignment::sendStatsPacket() { void ThreadedAssignment::checkInWithDomainServerOrExit() { if (NodeList::getInstance()->getNumNoReplyDomainCheckIns() == MAX_SILENT_DOMAIN_SERVER_CHECK_INS) { - qDebug() << "NRDC:" << NodeList::getInstance()->getNumNoReplyDomainCheckIns(); setFinished(true); } else { + qDebug() << "Sending DS check in. There are" << NodeList::getInstance()->getNumNoReplyDomainCheckIns() << "unreplied."; NodeList::getInstance()->sendDomainServerCheckIn(); } }