Add proper message failure handling to Connection

libraries/networking/src/udt/Connection.cpp

@@ -49,6 +49,11 @@ Connection::Connection(Socket* parentSocket, HifiSockAddr destination, std::uniq
 
 Connection::~Connection() {
     stopSendQueue();
+
+    // Fail any pending received messages
+    for (auto& pendingMessage : _pendingReceivedMessages) {
+        _parentSocket->messageFailed(this, pendingMessage.first);
+    }
 }
 
 void Connection::stopSendQueue() {
@@ -805,6 +810,9 @@ void Connection::resetReceiveState() {
     _receivedControlProbeTail = false;
     
     // clear any pending received messages
+    for (auto& pendingMessage : _pendingReceivedMessages) {
+        _parentSocket->messageFailed(this, pendingMessage.first);
+    }
     _pendingReceivedMessages.clear();
 }
 

libraries/networking/src/udt/Connection.h

@@ -74,6 +74,8 @@ public:
     
     bool isActive() const { return _isActive; }
 
+    HifiSockAddr getDestination() const { return _destination; }
+
 signals:
     void packetSent();
     void connectionInactive(const HifiSockAddr& sockAddr);

libraries/networking/src/udt/Socket.cpp

@@ -218,6 +218,12 @@ void Socket::messageReceived(std::unique_ptr<Packet> packet) {
     }
 }
 
+void Socket::messageFailed(Connection* connection, Packet::MessageNumber messageNumber) {
+    if (_messageFailureHandler) {
+        _messageFailureHandler(connection->getDestination(), messageNumber);
+    }
+}
+
 void Socket::readPendingDatagrams() {
     int packetSizeWithHeader = -1;
     while ((packetSizeWithHeader = _udpSocket.pendingDatagramSize()) != -1) {

libraries/networking/src/udt/Socket.h

@@ -74,6 +74,7 @@ public:
     void setCongestionControlFactory(std::unique_ptr<CongestionControlVirtualFactory> ccFactory);
 
     void messageReceived(std::unique_ptr<Packet> packet);
+    void messageFailed(Connection* connection, Packet::MessageNumber messageNumber);
     
     StatsVector sampleStatsForAllConnections();