code review comments

This commit is contained in:
Stephen Birarda 2013-09-09 10:02:30 -07:00
parent 4905032090
commit 2fd043b55c

View file

@ -85,11 +85,14 @@ int main(int argc, const char* argv[]) {
timeval lastStatSendTime = {}; timeval lastStatSendTime = {};
const char ASSIGNMENT_POOL_OPTION = "-p";
const char ASSIGNMENT_SERVER_OPTION = "-a";
// set our assignment pool from argv, if it exists // set our assignment pool from argv, if it exists
const char* assignmentPool = getCmdOption(argc, argv, "-p"); const char* assignmentPool = getCmdOption(argc, argv, ASSIGNMENT_POOL_OPTION);
// grab the overriden assignment-server hostname from argv, if it exists // grab the overriden assignment-server hostname from argv, if it exists
const char* customAssignmentServer = getCmdOption(argc, argv, "-a"); const char* customAssignmentServer = getCmdOption(argc, argv, ASSIGNMENT_SERVER_OPTION);
if (customAssignmentServer) { if (customAssignmentServer) {
sockaddr_in customAssignmentSocket = socketForHostnameAndHostOrderPort(customAssignmentServer, ASSIGNMENT_SERVER_PORT); sockaddr_in customAssignmentSocket = socketForHostnameAndHostOrderPort(customAssignmentServer, ASSIGNMENT_SERVER_PORT);
nodeList->setAssignmentServerSocket((sockaddr*) &customAssignmentSocket); nodeList->setAssignmentServerSocket((sockaddr*) &customAssignmentSocket);