Mirrors/overte
3
0
Fork 0
mirror of https://github.com/overte-org/overte.git synced 2025-08-08 23:36:44 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

Add an extra sanity check when calling fetchMetaSubItems when the subItems is not allocated yet

Browse source
This commit is contained in:
samcake 2018-03-28 16:17:55 -07:00
parent d59a721f16
commit 2ee0af03c8
1 changed files with 9 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
libraries/render/src/render/Item.cpp
View file

@ -118,9 +118,15 @@ uint32_t Item::fetchMetaSubItemBounds(ItemBounds& subItemBounds, Scene& scene) c
auto numSubs = fetchMetaSubItems(subItems); auto numSubs = fetchMetaSubItems(subItems);
for (auto id : subItems) { for (auto id : subItems) {
auto& item = scene.getItem(id); // TODO: Adding an extra check here even thought we shouldn't have too.
if (item.exist()) { // We have cases when the id returned by fetchMetaSubItems is not allocated
subItemBounds.emplace_back(id, item.getBound()); if (scene.isAllocatedID(id)) {
auto& item = scene.getItem(id);
if (item.exist()) {
subItemBounds.emplace_back(id, item.getBound());
} else {
numSubs--;
}
} else { } else {
numSubs--; numSubs--;
} }