From 2dc2757ecabf501ed5c92f4c1d069b028d172b50 Mon Sep 17 00:00:00 2001
From: Seth Alves <seth@highfidelity.io>
Date: Tue, 18 Aug 2015 13:03:54 -0700
Subject: [PATCH] code review

---
 .../src/RenderablePolyVoxEntityItem.cpp            | 14 +++++++-------
 .../src/RenderablePolyVoxEntityItem.h              |  8 ++++----
 libraries/entities/src/PolyVoxEntityItem.h         |  8 ++++----
 3 files changed, 15 insertions(+), 15 deletions(-)

diff --git a/libraries/entities-renderer/src/RenderablePolyVoxEntityItem.cpp b/libraries/entities-renderer/src/RenderablePolyVoxEntityItem.cpp
index 5c0a7888e5..5d139a719a 100644
--- a/libraries/entities-renderer/src/RenderablePolyVoxEntityItem.cpp
+++ b/libraries/entities-renderer/src/RenderablePolyVoxEntityItem.cpp
@@ -659,9 +659,9 @@ void RenderablePolyVoxEntityItem::computeShapeInfo(ShapeInfo& info) {
             uint32_t p1Index = *(it++);
             uint32_t p2Index = *(it++);
 
-            const glm::vec3 p0 = vertexBufferView.get<const glm::vec3>(p0Index);
-            const glm::vec3 p1 = vertexBufferView.get<const glm::vec3>(p1Index);
-            const glm::vec3 p2 = vertexBufferView.get<const glm::vec3>(p2Index);
+            const glm::vec3& p0 = vertexBufferView.get<const glm::vec3>(p0Index);
+            const glm::vec3& p1 = vertexBufferView.get<const glm::vec3>(p1Index);
+            const glm::vec3& p2 = vertexBufferView.get<const glm::vec3>(p2Index);
 
             glm::vec3 av = (p0 + p1 + p2) / 3.0f; // center of the triangular face
             glm::vec3 normal = glm::normalize(glm::cross(p1 - p0, p2 - p0));
@@ -959,18 +959,18 @@ namespace render {
     }
 }
 
-glm::vec3 RenderablePolyVoxEntityItem::voxelCoordsToWorldCoords(glm::vec3 voxelCoords) {
+glm::vec3 RenderablePolyVoxEntityItem::voxelCoordsToWorldCoords(glm::vec3& voxelCoords) const {
     return glm::vec3(voxelToWorldMatrix() * glm::vec4(voxelCoords, 1.0f));
 }
 
-glm::vec3 RenderablePolyVoxEntityItem::worldCoordsToVoxelCoords(glm::vec3 worldCoords) {
+glm::vec3 RenderablePolyVoxEntityItem::worldCoordsToVoxelCoords(glm::vec3& worldCoords) const {
     return glm::vec3(worldToVoxelMatrix() * glm::vec4(worldCoords, 1.0f));
 }
 
-glm::vec3 RenderablePolyVoxEntityItem::voxelCoordsToLocalCoords(glm::vec3 voxelCoords) {
+glm::vec3 RenderablePolyVoxEntityItem::voxelCoordsToLocalCoords(glm::vec3& voxelCoords) const {
     return glm::vec3(voxelToLocalMatrix() * glm::vec4(voxelCoords, 0.0f));
 }
 
-glm::vec3 RenderablePolyVoxEntityItem::localCoordsToVoxelCoords(glm::vec3 localCoords) {
+glm::vec3 RenderablePolyVoxEntityItem::localCoordsToVoxelCoords(glm::vec3& localCoords) const {
     return glm::vec3(localToVoxelMatrix() * glm::vec4(localCoords, 0.0f));
 }
diff --git a/libraries/entities-renderer/src/RenderablePolyVoxEntityItem.h b/libraries/entities-renderer/src/RenderablePolyVoxEntityItem.h
index ffc45beb22..e2fcdedc31 100644
--- a/libraries/entities-renderer/src/RenderablePolyVoxEntityItem.h
+++ b/libraries/entities-renderer/src/RenderablePolyVoxEntityItem.h
@@ -79,10 +79,10 @@ public:
     virtual bool isReadyToComputeShape();
     virtual void computeShapeInfo(ShapeInfo& info);
 
-    virtual glm::vec3 voxelCoordsToWorldCoords(glm::vec3 voxelCoords);
-    virtual glm::vec3 worldCoordsToVoxelCoords(glm::vec3 worldCoords);
-    virtual glm::vec3 voxelCoordsToLocalCoords(glm::vec3 voxelCoords);
-    virtual glm::vec3 localCoordsToVoxelCoords(glm::vec3 localCoords);
+    virtual glm::vec3 voxelCoordsToWorldCoords(glm::vec3& voxelCoords) const;
+    virtual glm::vec3 worldCoordsToVoxelCoords(glm::vec3& worldCoords) const;
+    virtual glm::vec3 voxelCoordsToLocalCoords(glm::vec3& voxelCoords) const;
+    virtual glm::vec3 localCoordsToVoxelCoords(glm::vec3& localCoords) const;
 
     // coords are in voxel-volume space
     virtual bool setSphereInVolume(glm::vec3 center, float radius, uint8_t toValue);
diff --git a/libraries/entities/src/PolyVoxEntityItem.h b/libraries/entities/src/PolyVoxEntityItem.h
index 2ba57f85de..9fbaade407 100644
--- a/libraries/entities/src/PolyVoxEntityItem.h
+++ b/libraries/entities/src/PolyVoxEntityItem.h
@@ -77,10 +77,10 @@ class PolyVoxEntityItem : public EntityItem {
     virtual bool setSphereInVolume(glm::vec3 center, float radius, uint8_t toValue) { return false; }
     virtual bool setVoxelInVolume(glm::vec3 position, uint8_t toValue) { return false; }
 
-    virtual glm::vec3 voxelCoordsToWorldCoords(glm::vec3 voxelCoords) { return glm::vec3(0.0f); }
-    virtual glm::vec3 worldCoordsToVoxelCoords(glm::vec3 worldCoords) { return glm::vec3(0.0f); }
-    virtual glm::vec3 voxelCoordsToLocalCoords(glm::vec3 voxelCoords) { return glm::vec3(0.0f); }
-    virtual glm::vec3 localCoordsToVoxelCoords(glm::vec3 localCoords) { return glm::vec3(0.0f); }
+    virtual glm::vec3 voxelCoordsToWorldCoords(glm::vec3& voxelCoords) const { return glm::vec3(0.0f); }
+    virtual glm::vec3 worldCoordsToVoxelCoords(glm::vec3& worldCoords) const { return glm::vec3(0.0f); }
+    virtual glm::vec3 voxelCoordsToLocalCoords(glm::vec3& voxelCoords) const { return glm::vec3(0.0f); }
+    virtual glm::vec3 localCoordsToVoxelCoords(glm::vec3& localCoords) const { return glm::vec3(0.0f); }
 
     // coords are in world-space
     virtual bool setSphere(glm::vec3 center, float radius, uint8_t toValue) { return false; }