Mirrors/overte
3
0
Fork 0
mirror of https://github.com/overte-org/overte.git synced 2025-04-14 07:27:04 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

change AO default to HBAO, remove from create

Browse source
This commit is contained in:
HifiExperiments 2024-07-26 18:23:23 -07:00
parent c72f22e4ee
commit 2c148ca97d
2 changed files with 10 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
libraries/entities/src/AmbientOcclusionPropertyGroup.h
View file

@ -91,7 +91,9 @@ public:
EntityPropertyFlags& propertyFlags, bool overwriteLocalData, EntityPropertyFlags& propertyFlags, bool overwriteLocalData,
bool& somethingChanged) override; bool& somethingChanged) override;
DEFINE_PROPERTY_REF_ENUM(PROP_AMBIENT_OCCLUSION_TECHNIQUE, Technique, technique, AmbientOcclusionTechnique, AmbientOcclusionTechnique::SSAO); // FIXME: On some machines, SSAO seems to be causing performance problems. Let's default to HBAO for now and maybe
// revisit when we have Vulkan
DEFINE_PROPERTY_REF_ENUM(PROP_AMBIENT_OCCLUSION_TECHNIQUE, Technique, technique, AmbientOcclusionTechnique, AmbientOcclusionTechnique::HBAO);
DEFINE_PROPERTY(PROP_AMBIENT_OCCLUSION_JITTER, Jitter, jitter, bool, false); DEFINE_PROPERTY(PROP_AMBIENT_OCCLUSION_JITTER, Jitter, jitter, bool, false);
DEFINE_PROPERTY(PROP_AMBIENT_OCCLUSION_RESOLUTION_LEVEL, ResolutionLevel, resolutionLevel, uint8_t, 2); DEFINE_PROPERTY(PROP_AMBIENT_OCCLUSION_RESOLUTION_LEVEL, ResolutionLevel, resolutionLevel, uint8_t, 2);
DEFINE_PROPERTY(PROP_AMBIENT_OCCLUSION_EDGE_SHARPNESS, EdgeSharpness, edgeSharpness, float, 1.0f); DEFINE_PROPERTY(PROP_AMBIENT_OCCLUSION_EDGE_SHARPNESS, EdgeSharpness, edgeSharpness, float, 1.0f);

14
scripts/system/create/entityProperties/html/js/entityProperties.js
View file

@ -657,13 +657,13 @@ const GROUPS = [
options: { inherit: "Inherit", disabled: "Off", enabled: "On" }, options: { inherit: "Inherit", disabled: "Off", enabled: "On" },
propertyID: "ambientOcclusionMode", propertyID: "ambientOcclusionMode",
}, },
{ //{
label: "Technique", // label: "Technique",
type: "dropdown", // type: "dropdown",
options: { ssao: "SSAO", hbao: "HBAO" }, // options: { ssao: "SSAO", hbao: "HBAO" },
propertyID: "ambientOcclusion.technique", // propertyID: "ambientOcclusion.technique",
showPropertyRule: { "ambientOcclusionMode": "enabled" }, // showPropertyRule: { "ambientOcclusionMode": "enabled" },
}, //},
{ {
label: "Jitter", label: "Jitter",
type: "bool", type: "bool",