From 2b40ad42754300b044c73e133c564a723aa66514 Mon Sep 17 00:00:00 2001 From: Zach Pomerantz Date: Sun, 28 May 2017 17:41:35 -0400 Subject: [PATCH] mv Audio... to Settings as dialog --- .../resources/qml/hifi/dialogs/Audio.qml | 11 ++++++++ interface/src/Menu.cpp | 25 +++++++------------ 2 files changed, 20 insertions(+), 16 deletions(-) create mode 100644 interface/resources/qml/hifi/dialogs/Audio.qml diff --git a/interface/resources/qml/hifi/dialogs/Audio.qml b/interface/resources/qml/hifi/dialogs/Audio.qml new file mode 100644 index 0000000000..20f6601288 --- /dev/null +++ b/interface/resources/qml/hifi/dialogs/Audio.qml @@ -0,0 +1,11 @@ +// +// Audio.qml +// +// Created by Zach Pomerantz on 28/5/2017 +// Copyright 2017 High Fidelity, Inc. +// +// Distributed under the Apache License, Version 2.0. +// See the accompanying file LICENSE or http://www.apache.org/licenses/LICENSE-2.0.html +// + +// TODO diff --git a/interface/src/Menu.cpp b/interface/src/Menu.cpp index 85c2b0f1db..baeae1a633 100644 --- a/interface/src/Menu.cpp +++ b/interface/src/Menu.cpp @@ -148,28 +148,13 @@ Menu::Menu() { addActionToQMenuAndActionHash(editMenu, MenuOption::ReloadContent, 0, qApp, SLOT(reloadResourceCaches()), QAction::NoRole, UNSPECIFIED_POSITION, "Advanced"); - - // Audio menu ---------------------------------- - MenuWrapper* audioMenu = addMenu("Audio"); - auto audioIO = DependencyManager::get(); - - // Audio > Mute - addCheckableActionToQMenuAndActionHash(audioMenu, MenuOption::MuteAudio, Qt::CTRL | Qt::Key_M, false, - audioIO.data(), SLOT(toggleMute())); - - // Audio > Show Level Meter - addCheckableActionToQMenuAndActionHash(audioMenu, MenuOption::AudioTools, 0, false); - - addCheckableActionToQMenuAndActionHash(audioMenu, MenuOption::AudioNoiseReduction, 0, true, - audioIO.data(), SLOT(toggleAudioNoiseReduction())); - // Avatar menu ---------------------------------- MenuWrapper* avatarMenu = addMenu("Avatar"); auto avatarManager = DependencyManager::get(); auto avatar = avatarManager->getMyAvatar(); // Avatar > Attachments... - auto action = addActionToQMenuAndActionHash(avatarMenu, MenuOption::Attachments); + action = addActionToQMenuAndActionHash(avatarMenu, MenuOption::Attachments); connect(action, &QAction::triggered, [] { qApp->showDialog(QString("hifi/dialogs/AttachmentsDialog.qml"), QString("../../hifi/tablet/TabletAttachmentsDialog.qml"), "AttachmentsDialog"); @@ -302,6 +287,14 @@ Menu::Menu() { QString("../../hifi/tablet/TabletGeneralPreferences.qml"), "GeneralPreferencesDialog"); }); + action = addActionToQMenuAndActionHash(settingsMenu, "Audio..."); + connect(action, &QAction::triggered, [] { + static const QUrl widgetUrl("hifi/dialogs/Audio.qml"); + static const QUrl tabletUrl("../../hifi/dialogs/Audio.qml"); + static const QString name("Audio"); + qApp->showDialog(widgetUrl, tabletUrl, name); + }); + // Settings > Avatar... action = addActionToQMenuAndActionHash(settingsMenu, "Avatar..."); connect(action, &QAction::triggered, [] {