Merge pull request #3408 from ey6es/master

Slight fix for Blender fix.
This commit is contained in:
AndrewMeadows 2014-09-12 16:00:53 -07:00
commit 27b8d7076b
3 changed files with 14 additions and 12 deletions

View file

@ -298,8 +298,8 @@ QSharedPointer<NetworkGeometry> GeometryCache::getGeometry(const QUrl& url, cons
void GeometryCache::setBlendedVertices(const QPointer<Model>& model, const QWeakPointer<NetworkGeometry>& geometry, void GeometryCache::setBlendedVertices(const QPointer<Model>& model, const QWeakPointer<NetworkGeometry>& geometry,
const QVector<glm::vec3>& vertices, const QVector<glm::vec3>& normals) { const QVector<glm::vec3>& vertices, const QVector<glm::vec3>& normals) {
if (!model.isNull() && model->getGeometry() == geometry) { if (!model.isNull()) {
model->setBlendedVertices(vertices, normals); model->setBlendedVertices(geometry, vertices, normals);
} }
} }

View file

@ -848,8 +848,8 @@ Blender::Blender(Model* model, const QWeakPointer<NetworkGeometry>& geometry,
} }
void Blender::run() { void Blender::run() {
// make sure the model/geometry still exists // make sure the model still exists
if (_model.isNull() || _geometry.isNull()) { if (_model.isNull()) {
return; return;
} }
QVector<glm::vec3> vertices, normals; QVector<glm::vec3> vertices, normals;
@ -1272,24 +1272,25 @@ void Model::renderJointCollisionShapes(float alpha) {
// implement this when we have shapes for regular models // implement this when we have shapes for regular models
} }
void Model::setBlendedVertices(const QVector<glm::vec3>& vertices, const QVector<glm::vec3>& normals) { void Model::setBlendedVertices(const QWeakPointer<NetworkGeometry>& geometry, const QVector<glm::vec3>& vertices,
const QVector<glm::vec3>& normals) {
_blenderPending = false; _blenderPending = false;
// start the next blender if required // start the next blender if required
const FBXGeometry& geometry = _geometry->getFBXGeometry(); const FBXGeometry& fbxGeometry = _geometry->getFBXGeometry();
if (_blendRequired) { if (_blendRequired) {
_blendRequired = false; _blendRequired = false;
if (geometry.hasBlendedMeshes()) { if (fbxGeometry.hasBlendedMeshes()) {
_blenderPending = true; _blenderPending = true;
QThreadPool::globalInstance()->start(new Blender(this, _geometry, geometry.meshes, _blendshapeCoefficients)); QThreadPool::globalInstance()->start(new Blender(this, _geometry, fbxGeometry.meshes, _blendshapeCoefficients));
} }
} }
if (_blendedVertexBuffers.isEmpty()) { if (_geometry != geometry || _blendedVertexBuffers.isEmpty()) {
return; return;
} }
int index = 0; int index = 0;
for (int i = 0; i < geometry.meshes.size(); i++) { for (int i = 0; i < fbxGeometry.meshes.size(); i++) {
const FBXMesh& mesh = geometry.meshes.at(i); const FBXMesh& mesh = fbxGeometry.meshes.at(i);
if (mesh.blendshapes.isEmpty()) { if (mesh.blendshapes.isEmpty()) {
continue; continue;
} }

View file

@ -166,7 +166,8 @@ public:
virtual void renderJointCollisionShapes(float alpha); virtual void renderJointCollisionShapes(float alpha);
/// Sets blended vertices computed in a separate thread. /// Sets blended vertices computed in a separate thread.
void setBlendedVertices(const QVector<glm::vec3>& vertices, const QVector<glm::vec3>& normals); void setBlendedVertices(const QWeakPointer<NetworkGeometry>& geometry, const QVector<glm::vec3>& vertices,
const QVector<glm::vec3>& normals);
class LocalLight { class LocalLight {
public: public: