From 25b3a8c75c78b36c8162567158abb99a58b54657 Mon Sep 17 00:00:00 2001 From: NissimHadar Date: Tue, 9 Oct 2018 12:02:42 -0700 Subject: [PATCH] Fixed gcc warnings. --- tools/auto-tester/src/TestRunner.cpp | 14 +++++--------- tools/auto-tester/src/TestRunner.h | 2 +- 2 files changed, 6 insertions(+), 10 deletions(-) diff --git a/tools/auto-tester/src/TestRunner.cpp b/tools/auto-tester/src/TestRunner.cpp index 756923828f..72e5e8f997 100644 --- a/tools/auto-tester/src/TestRunner.cpp +++ b/tools/auto-tester/src/TestRunner.cpp @@ -463,13 +463,8 @@ void TestRunner::checkTime() { // Check the time bool timeToRun{ false }; QTime time = now.time(); - int h = time.hour(); - int m = time.minute(); - for (int i = 0; i < std::min(_timeEditCheckboxes.size(), _timeEdits.size()); ++i) { - bool is = _timeEditCheckboxes[i]->isChecked(); - int hh = _timeEdits[i]->time().hour(); - int mm = _timeEdits[i]->time().minute(); + for (size_t i = 0; i < std::min(_timeEditCheckboxes.size(), _timeEdits.size()); ++i) { if (_timeEditCheckboxes[i]->isChecked() && (_timeEdits[i]->time().hour() == now.time().hour()) && (_timeEdits[i]->time().minute() == now.time().minute())) { timeToRun = true; @@ -543,7 +538,7 @@ void TestRunner::parseBuildInformation() { QString platformOfInterest; #ifdef Q_OS_WIN platformOfInterest = "windows"; -#else if Q_OS_MAC +#elif Q_OS_MAC platformOfInterest = "mac"; #endif QDomElement element = domDocument.documentElement(); @@ -611,7 +606,8 @@ void Worker::setCommandLine(const QString& commandLine) { _commandLine = commandLine; } -void Worker::runCommand() { - system(_commandLine.toStdString().c_str()); +int Worker::runCommand() { + int result = system(_commandLine.toStdString().c_str()); emit commandComplete(); + return result; } \ No newline at end of file diff --git a/tools/auto-tester/src/TestRunner.h b/tools/auto-tester/src/TestRunner.h index dfa93b7b1c..925ff6077a 100644 --- a/tools/auto-tester/src/TestRunner.h +++ b/tools/auto-tester/src/TestRunner.h @@ -138,7 +138,7 @@ public: void setCommandLine(const QString& commandLine); public slots: - void runCommand(); + int runCommand(); signals: void commandComplete();