Mirrors/overte
3
0
Fork 0
mirror of https://github.com/overte-org/overte.git synced 2025-08-10 01:00:44 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Merge pull request #5309 from sethalves/quiet-compiler

Browse source 
quiet compiler
This commit is contained in:
Clément Brisset 2015-07-13 15:55:35 -07:00
commit 24eb4c8263
7 changed files with 34 additions and 27 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
interface/src/ui/overlays/Rectangle3DOverlay.cpp
View file

@ -42,7 +42,6 @@ void Rectangle3DOverlay::render(RenderArgs* args) {
glm::vec4 rectangleColor(color.red / MAX_COLOR, color.green / MAX_COLOR, color.blue / MAX_COLOR, alpha); glm::vec4 rectangleColor(color.red / MAX_COLOR, color.green / MAX_COLOR, color.blue / MAX_COLOR, alpha);
glm::vec3 position = getPosition(); glm::vec3 position = getPosition();
glm::vec3 center = getCenter();
glm::vec2 dimensions = getDimensions(); glm::vec2 dimensions = getDimensions();
glm::vec2 halfDimensions = dimensions * 0.5f; glm::vec2 halfDimensions = dimensions * 0.5f;
glm::quat rotation = getRotation(); glm::quat rotation = getRotation();

14
libraries/entities/src/EntityItem.cpp
View file

@ -385,7 +385,7 @@ int EntityItem::readEntityDataFromBuffer(const unsigned char* data, int bytesLef
dataAt += encodedID.size(); dataAt += encodedID.size();
bytesRead += encodedID.size(); bytesRead += encodedID.size();
Q_ASSERT(id == _id); Q_ASSERT(id == _id);
Q_ASSERT(parser.offset() == bytesRead); Q_ASSERT(parser.offset() == (unsigned int) bytesRead);
} }
#endif #endif
@ -400,7 +400,7 @@ int EntityItem::readEntityDataFromBuffer(const unsigned char* data, int bytesLef
quint32 type = typeCoder; quint32 type = typeCoder;
EntityTypes::EntityType oldType = (EntityTypes::EntityType)type; EntityTypes::EntityType oldType = (EntityTypes::EntityType)type;
Q_ASSERT(oldType == _type); Q_ASSERT(oldType == _type);
Q_ASSERT(parser.offset() == bytesRead); Q_ASSERT(parser.offset() == (unsigned int) bytesRead);
#endif #endif
bool overwriteLocalData = true; // assume the new content overwrites our local data bool overwriteLocalData = true; // assume the new content overwrites our local data
@ -417,7 +417,7 @@ int EntityItem::readEntityDataFromBuffer(const unsigned char* data, int bytesLef
dataAt += sizeof(createdFromBuffer2); dataAt += sizeof(createdFromBuffer2);
bytesRead += sizeof(createdFromBuffer2); bytesRead += sizeof(createdFromBuffer2);
Q_ASSERT(createdFromBuffer2 == createdFromBuffer); Q_ASSERT(createdFromBuffer2 == createdFromBuffer);
Q_ASSERT(parser.offset() == bytesRead); Q_ASSERT(parser.offset() == (unsigned int) bytesRead);
} }
#endif #endif
if (_created == UNKNOWN_CREATED_TIME) { if (_created == UNKNOWN_CREATED_TIME) {
@ -458,7 +458,7 @@ int EntityItem::readEntityDataFromBuffer(const unsigned char* data, int bytesLef
dataAt += sizeof(lastEditedFromBuffer2); dataAt += sizeof(lastEditedFromBuffer2);
bytesRead += sizeof(lastEditedFromBuffer2); bytesRead += sizeof(lastEditedFromBuffer2);
Q_ASSERT(lastEditedFromBuffer2 == lastEditedFromBuffer); Q_ASSERT(lastEditedFromBuffer2 == lastEditedFromBuffer);
Q_ASSERT(parser.offset() == bytesRead); Q_ASSERT(parser.offset() == (unsigned int) bytesRead);
} }
#endif #endif
quint64 lastEditedFromBufferAdjusted = lastEditedFromBuffer - clockSkew; quint64 lastEditedFromBufferAdjusted = lastEditedFromBuffer - clockSkew;
@ -534,7 +534,7 @@ int EntityItem::readEntityDataFromBuffer(const unsigned char* data, int bytesLef
encodedUpdateDelta = updateDeltaCoder; // determine true length encodedUpdateDelta = updateDeltaCoder; // determine true length
dataAt += encodedUpdateDelta.size(); dataAt += encodedUpdateDelta.size();
bytesRead += encodedUpdateDelta.size(); bytesRead += encodedUpdateDelta.size();
Q_ASSERT(parser.offset() == bytesRead); Q_ASSERT(parser.offset() == (unsigned int) bytesRead);
} }
#endif #endif
@ -562,7 +562,7 @@ int EntityItem::readEntityDataFromBuffer(const unsigned char* data, int bytesLef
encodedSimulatedDelta = simulatedDeltaCoder; // determine true length encodedSimulatedDelta = simulatedDeltaCoder; // determine true length
dataAt += encodedSimulatedDelta.size(); dataAt += encodedSimulatedDelta.size();
bytesRead += encodedSimulatedDelta.size(); bytesRead += encodedSimulatedDelta.size();
Q_ASSERT(parser.offset() == bytesRead); Q_ASSERT(parser.offset() == (unsigned int) bytesRead);
} }
#endif #endif
@ -599,7 +599,7 @@ int EntityItem::readEntityDataFromBuffer(const unsigned char* data, int bytesLef
dataAt += propertyFlags.getEncodedLength(); dataAt += propertyFlags.getEncodedLength();
bytesRead += propertyFlags.getEncodedLength(); bytesRead += propertyFlags.getEncodedLength();
Q_ASSERT(propertyFlags2 == propertyFlags); Q_ASSERT(propertyFlags2 == propertyFlags);
Q_ASSERT(parser.offset() == bytesRead); Q_ASSERT(parser.offset() == (unsigned int)bytesRead);
} }
#endif #endif

3
libraries/gpu/src/gpu/GLBackend.cpp
View file

@ -204,7 +204,6 @@ void GLBackend::do_drawInstanced(Batch& batch, uint32 paramOffset) {
GLenum mode = _primitiveToGLmode[primitiveType]; GLenum mode = _primitiveToGLmode[primitiveType];
uint32 numVertices = batch._params[paramOffset + 2]._uint; uint32 numVertices = batch._params[paramOffset + 2]._uint;
uint32 startVertex = batch._params[paramOffset + 1]._uint; uint32 startVertex = batch._params[paramOffset + 1]._uint;
uint32 startInstance = batch._params[paramOffset + 0]._uint;
glDrawArraysInstancedARB(mode, startVertex, numVertices, numInstances); glDrawArraysInstancedARB(mode, startVertex, numVertices, numInstances);
(void) CHECK_GL_ERROR(); (void) CHECK_GL_ERROR();
@ -238,7 +237,7 @@ void GLBackend::do_clearFramebuffer(Batch& batch, uint32 paramOffset) {
std::vector<GLenum> drawBuffers; std::vector<GLenum> drawBuffers;
if (masks & Framebuffer::BUFFER_COLORS) { if (masks & Framebuffer::BUFFER_COLORS) {
for (int i = 0; i < Framebuffer::MAX_NUM_RENDER_BUFFERS; i++) { for (unsigned int i = 0; i < Framebuffer::MAX_NUM_RENDER_BUFFERS; i++) {
if (masks & (1 << i)) { if (masks & (1 << i)) {
drawBuffers.push_back(GL_COLOR_ATTACHMENT0 + i); drawBuffers.push_back(GL_COLOR_ATTACHMENT0 + i);
} }

5
libraries/render-utils/src/DeferredLightingEffect.cpp
View file

@ -479,12 +479,13 @@ void DeferredLightingEffect::render(RenderArgs* args) {
auto eyeHalfPlaneDistance = glm::dot(eyeLightPos, light->getDirection()); auto eyeHalfPlaneDistance = glm::dot(eyeLightPos, light->getDirection());
const float TANGENT_LENGTH_SCALE = 0.666f; const float TANGENT_LENGTH_SCALE = 0.666f;
glm::vec4 coneParam(light->getSpotAngleCosSin(), TANGENT_LENGTH_SCALE * tan(0.5 * light->getSpotAngle()), 1.0f); glm::vec4 coneParam(light->getSpotAngleCosSin(), TANGENT_LENGTH_SCALE * tanf(0.5f * light->getSpotAngle()), 1.0f);
float expandedRadius = light->getMaximumRadius() * (1.0f + SCALE_EXPANSION); float expandedRadius = light->getMaximumRadius() * (1.0f + SCALE_EXPANSION);
// TODO: We shouldn;t have to do that test and use a different volume geometry for when inside the vlight volume, // TODO: We shouldn;t have to do that test and use a different volume geometry for when inside the vlight volume,
// we should be able to draw thre same geometry use DepthClamp but for unknown reason it's s not working... // we should be able to draw thre same geometry use DepthClamp but for unknown reason it's s not working...
if ((eyeHalfPlaneDistance > -nearRadius) && (glm::distance(eyePoint, glm::vec3(light->getPosition())) < expandedRadius + nearRadius)) { if ((eyeHalfPlaneDistance > -nearRadius) &&
(glm::distance(eyePoint, glm::vec3(light->getPosition())) < expandedRadius + nearRadius)) {
coneParam.w = 0.0f; coneParam.w = 0.0f;
batch._glUniform4fv(_spotLightLocations.coneParam, 1, reinterpret_cast< const GLfloat* >(&coneParam)); batch._glUniform4fv(_spotLightLocations.coneParam, 1, reinterpret_cast< const GLfloat* >(&coneParam));

2
libraries/render/src/render/Scene.cpp
View file

@ -76,7 +76,7 @@ void Item::Status::Value::setColor(float hue) {
} }
void Item::Status::getPackedValues(glm::ivec4& values) const { void Item::Status::getPackedValues(glm::ivec4& values) const {
for (unsigned int i = 0; i < values.length(); i++) { for (unsigned int i = 0; i < (unsigned int)values.length(); i++) {
if (i < _values.size()) { if (i < _values.size()) {
values[i] = _values[i]().getPackedData(); values[i] = _values[i]().getPackedData();
} else { } else {

2
libraries/shared/src/PropertyFlags.h
View file

@ -208,7 +208,7 @@ inline size_t PropertyFlags<Enum>::decode(const uint8_t* data, size_t size) {
int bitAt = 0; int bitAt = 0;
int expectedBitCount; // unknown at this point int expectedBitCount; // unknown at this point
int lastValueBit; int lastValueBit;
for (int byte = 0; byte < size; byte++) { for (unsigned int byte = 0; byte < size; byte++) {
char originalByte = data[byte]; char originalByte = data[byte];
bytesConsumed++; bytesConsumed++;
unsigned char maskBit = 0x80; // LEFT MOST BIT set unsigned char maskBit = 0x80; // LEFT MOST BIT set

14
tests/entities/src/main.cpp
View file

@ -73,15 +73,19 @@ template <typename T>
void testByteCountCodedStable(const T& value) { void testByteCountCodedStable(const T& value) {
ByteCountCoded<T> coder((T)value); ByteCountCoded<T> coder((T)value);
auto encoded = coder.encode(); auto encoded = coder.encode();
#ifndef QT_NO_DEBUG
auto originalEncodedSize = encoded.size(); auto originalEncodedSize = encoded.size();
#endif
for (int i = 0; i < 10; ++i) { for (int i = 0; i < 10; ++i) {
encoded.append(qrand()); encoded.append(qrand());
} }
ByteCountCoded<T> decoder; ByteCountCoded<T> decoder;
decoder.decode(encoded); decoder.decode(encoded);
Q_ASSERT(decoder.data == coder.data); Q_ASSERT(decoder.data == coder.data);
#ifndef QT_NO_DEBUG
auto consumed = decoder.decode(encoded.data(), encoded.size()); auto consumed = decoder.decode(encoded.data(), encoded.size());
Q_ASSERT(consumed == originalEncodedSize); #endif
Q_ASSERT(consumed == (unsigned int)originalEncodedSize);
} }
@ -100,12 +104,14 @@ void testPropertyFlags(uint32_t value) {
EntityPropertyFlags original; EntityPropertyFlags original;
original.clear(); original.clear();
auto enumSize = sizeof(EntityPropertyList); auto enumSize = sizeof(EntityPropertyList);
for (size_t i = 0; i < sizeof(EntityPropertyList) * 8; ++i) { for (size_t i = 0; i < enumSize * 8; ++i) {
original.setHasProperty((EntityPropertyList)i); original.setHasProperty((EntityPropertyList)i);
} }
QByteArray encoded = original.encode(); QByteArray encoded = original.encode();
#ifndef QT_NO_DEBUG
auto originalSize = encoded.size(); auto originalSize = encoded.size();
for (size_t i = 0; i < sizeof(EntityPropertyList); ++i) { #endif
for (size_t i = 0; i < enumSize; ++i) {
encoded.append(qrand()); encoded.append(qrand());
} }
@ -116,7 +122,9 @@ void testPropertyFlags(uint32_t value) {
} }
{ {
#ifndef QT_NO_DEBUG
auto decodeSize = decodeNew.decode((const uint8_t*)encoded.data(), encoded.size()); auto decodeSize = decodeNew.decode((const uint8_t*)encoded.data(), encoded.size());
#endif
Q_ASSERT(originalSize == decodeSize); Q_ASSERT(originalSize == decodeSize);
Q_ASSERT(decodeNew == original); Q_ASSERT(decodeNew == original);
} }