Apply suggestions from code review

Co-authored-by: David Rowe <david@ctrlaltstudio.com>
This commit is contained in:
Kalila 2021-07-15 22:19:58 -04:00 committed by GitHub
parent 88b9b7468e
commit 241c54919d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 2 deletions

View file

@ -193,7 +193,7 @@ void AssignmentClient::sendAssignmentRequest() {
auto nodeList = DependencyManager::get<NodeList>();
if (_assignmentServerHostname == "localhost" && _disableDomainPortAutoDiscovery == false) {
if (_assignmentServerHostname == "localhost" && !_disableDomainPortAutoDiscovery) {
// we want to check again for the local domain-server port in case the DS has restarted
quint16 localAssignmentServerPort;
if (nodeList->getLocalServerPortFromSharedMemory(DOMAIN_SERVER_LOCAL_PORT_SMEM_KEY, localAssignmentServerPort)) {

View file

@ -201,7 +201,7 @@ void AssignmentClientMonitor::spawnChildClient() {
_childArguments.append("--" + ASSIGNMENT_TYPE_OVERRIDE_OPTION);
_childArguments.append(QString::number(_requestAssignmentType));
}
if (_disableDomainPortAutoDiscovery != false) {
if (_disableDomainPortAutoDiscovery) {
_childArguments.append("--" + ASSIGNMENT_DISABLE_DOMAIN_AUTO_PORT_DISCOVERY);
}