wire up new zone properties, fix bug in group proprties decode

examples/html/entityProperties.html

@@ -33,6 +33,21 @@
                 );
             };
         }
+        function createEmitGroupNumberPropertyUpdateFunction(group, propertyName) {
+            return function() {
+                var properties = {};
+                properties[group] = {};
+                properties[group][propertyName] = this.value;
+                EventBridge.emitWebEvent(
+                    JSON.stringify({
+                        type: "update",
+                        properties: properties,
+                    })
+                );
+            };
+        }
+
+
         function createEmitTextPropertyUpdateFunction(propertyName) {
             return function() {
                 var properties = {};
@@ -46,6 +61,20 @@
             };
         }
 
+        function createEmitGroupTextPropertyUpdateFunction(group,propertyName) {
+            return function() {
+                var properties = {};
+                properties[group] = {};
+                properties[group][propertyName] = this.value;
+                EventBridge.emitWebEvent(
+                    JSON.stringify({
+                        type: "update",
+                        properties: properties,
+                    })
+                );
+            };
+        }
+
         function createEmitVec3PropertyUpdateFunction(property, elX, elY, elZ) {
             return function() {
                 var data = {
@@ -62,6 +91,23 @@
             }
         };
 
+        function createEmitGroupVec3PropertyUpdateFunction(group, property, elX, elY, elZ) {
+            return function() {
+                var data = {
+                     type: "update",
+                     properties: {
+                     }
+                };
+                data.properties[group] = { };
+                data.properties[group][property] = {
+                     x: elX.value,
+                     y: elY.value,
+                     z: elZ.value,
+                };
+                EventBridge.emitWebEvent(JSON.stringify(data));
+            }
+        };
+
         function createEmitVec3PropertyUpdateFunctionWithMultiplier(property, elX, elY, elZ, multiplier) {
             return function() {
                 var data = {
@@ -94,6 +140,24 @@
             }
         };
 
+        function createEmitGroupColorPropertyUpdateFunction(group, property, elRed, elGreen, elBlue) {
+            return function() {
+                var data = {
+                     type: "update",
+                     properties: {
+                     }
+                };
+                data.properties[group] = { };
+
+                data.properties[group][property] = {
+                     red: elRed.value,
+                     green: elGreen.value,
+                     blue: elBlue.value,
+                };
+                EventBridge.emitWebEvent(JSON.stringify(data));
+            }
+        };
+
         function loaded() {
             var allSections = [];
             var elID = document.getElementById("property-id");
@@ -559,20 +623,33 @@
             elZoneStageDay.addEventListener('change', createEmitNumberPropertyUpdateFunction('stageDay'));
             elZoneStageHour.addEventListener('change', createEmitNumberPropertyUpdateFunction('stageHour'));
 
-            elZoneBackgroundMode.addEventListener('change', createEmitTextPropertyUpdateFunction('backgroundMode'));
-            var zoneSkyboxColorChangeFunction = createEmitColorPropertyUpdateFunction(
-                'skybox.color', elZoneSkyboxColorRed, elZoneSkyboxColorGreen, elZoneSkyboxColorBlue);
-            elZoneSkyboxURL.addEventListener('change', createEmitTextPropertyUpdateFunction('skybox.url'));
 
-            var zoneAtmosphereCenterChangeFunction = createEmitVec3PropertyUpdateFunction(
+            elZoneBackgroundMode.addEventListener('change', createEmitTextPropertyUpdateFunction('backgroundMode'));
-                'atmosphere.center', elZoneAtmosphereCenterX, elZoneAtmosphereCenterY, elZoneAtmosphereCenterZ);
+            var zoneSkyboxColorChangeFunction = createEmitGroupColorPropertyUpdateFunction('skybox','color',
-            elZoneAtmosphereInnerRadius.addEventListener('change', createEmitNumberPropertyUpdateFunction('atmosphere.innerRadius'));
+                elZoneSkyboxColorRed, elZoneSkyboxColorGreen, elZoneSkyboxColorBlue);
-            elZoneAtmosphereOuterRadius.addEventListener('change', createEmitNumberPropertyUpdateFunction('atmosphere.outerRadius'));
+            elZoneSkyboxColorRed.addEventListener('change', zoneSkyboxColorChangeFunction);
-            elZoneAtmosphereMieScattering.addEventListener('change', createEmitNumberPropertyUpdateFunction('atmosphere.mieScattering'));
+            elZoneSkyboxColorGreen.addEventListener('change', zoneSkyboxColorChangeFunction);
-            elZoneAtmosphereRayleighScattering.addEventListener('change', createEmitNumberPropertyUpdateFunction('atmosphere.rayleighScattering'));
+            elZoneSkyboxColorBlue.addEventListener('change', zoneSkyboxColorChangeFunction);
-            var zoneAtmosphereCenterChangeFunction = createEmitVec3PropertyUpdateFunction(
+                
-                'atmosphere.scatteringWavelengths', elZoneAtmosphereScatteringWavelengthsX, 
+            elZoneSkyboxURL.addEventListener('change', createEmitGroupTextPropertyUpdateFunction('skybox','url'));
+
+            var zoneAtmosphereCenterChangeFunction = createEmitGroupVec3PropertyUpdateFunction(
+                'atmosphere','center', elZoneAtmosphereCenterX, elZoneAtmosphereCenterY, elZoneAtmosphereCenterZ);
+            elZoneAtmosphereCenterX.addEventListener('change', zoneAtmosphereCenterChangeFunction);
+            elZoneAtmosphereCenterY.addEventListener('change', zoneAtmosphereCenterChangeFunction);
+            elZoneAtmosphereCenterZ.addEventListener('change', zoneAtmosphereCenterChangeFunction);
+                
+                
+            elZoneAtmosphereInnerRadius.addEventListener('change', createEmitGroupNumberPropertyUpdateFunction('atmosphere','innerRadius'));
+            elZoneAtmosphereOuterRadius.addEventListener('change', createEmitGroupNumberPropertyUpdateFunction('atmosphere','outerRadius'));
+            elZoneAtmosphereMieScattering.addEventListener('change', createEmitGroupNumberPropertyUpdateFunction('atmosphere','mieScattering'));
+            elZoneAtmosphereRayleighScattering.addEventListener('change', createEmitGroupNumberPropertyUpdateFunction('atmosphere','rayleighScattering'));
+            var zoneAtmosphereScatterWavelengthsChangeFunction = createEmitGroupVec3PropertyUpdateFunction(
+                'atmosphere','scatteringWavelengths', elZoneAtmosphereScatteringWavelengthsX, 
                 elZoneAtmosphereScatteringWavelengthsY, elZoneAtmosphereScatteringWavelengthsZ);
+            elZoneAtmosphereScatteringWavelengthsX.addEventListener('change', zoneAtmosphereScatterWavelengthsChangeFunction);
+            elZoneAtmosphereScatteringWavelengthsY.addEventListener('change', zoneAtmosphereScatterWavelengthsChangeFunction);
+            elZoneAtmosphereScatteringWavelengthsZ.addEventListener('change', zoneAtmosphereScatterWavelengthsChangeFunction);
 
             elMoveSelectionToGrid.addEventListener("click", function() {
                 EventBridge.emitWebEvent(JSON.stringify({
@@ -1059,21 +1136,21 @@
         <div class="zone-section property">
             <div class="label">Atmosphere Mie Scattering</div>
             <div class="value">
-                <input class="coord" type='number' id="property-zone-atmosphere-mie-scattering" min="0" max="0.5" step="0.01"></input>
+                <input class="coord" type='number' id="property-zone-atmosphere-mie-scattering" min="0" max="0.5" step="0.001"></input>
             </div>
         </div>
         <div class="zone-section property">
             <div class="label">Atmosphere Rayleigh Scattering</div>
             <div class="value">
-                <input class="coord" type='number' id="property-zone-atmosphere-rayleigh-scattering" min="0" max="0.5" step="0.01"></input>
+                <input class="coord" type='number' id="property-zone-atmosphere-rayleigh-scattering" min="0" max="0.5" step="0.001"></input>
             </div>
         </div>
         <div class="zone-section property">
             <div class="label">Atmosphere Scattering Wavelenghts</div>
             <div class="value">
-                <div class="input-area">X <br><input class="coord" type='number' id="property-zone-atmosphere-scattering-wavelengths-x" min="0" max="1" step="0.01"></input></div>
+                <div class="input-area">X <br><input class="coord" type='number' id="property-zone-atmosphere-scattering-wavelengths-x" min="0" max="1" step="0.001"></input></div>
-                <div class="input-area">Y <br><input class="coord" type='number' id="property-zone-atmosphere-scattering-wavelengths-y" min="0" max="1" step="0.01"></input></div>
+                <div class="input-area">Y <br><input class="coord" type='number' id="property-zone-atmosphere-scattering-wavelengths-y" min="0" max="1" step="0.001"></input></div>
-                <div class="input-area">Z <br><input class="coord" type='number' id="property-zone-atmosphere-scattering-wavelengths-z" min="0" max="1" step="0.01"></input></div>
+                <div class="input-area">Z <br><input class="coord" type='number' id="property-zone-atmosphere-scattering-wavelengths-z" min="0" max="1" step="0.001"></input></div>
             </div>
         </div>
 

libraries/entities/src/AtmospherePropertyGroup.cpp

@@ -89,6 +89,14 @@ bool AtmospherePropertyGroup::decodeFromEditPacket(EntityPropertyFlags& property
     READ_ENTITY_PROPERTY(PROP_ATMOSPHERE_RAYLEIGH_SCATTERING, float, _rayleighScattering);
     READ_ENTITY_PROPERTY(PROP_ATMOSPHERE_SCATTERING_WAVELENGTHS, glm::vec3, _scatteringWavelengths);
     READ_ENTITY_PROPERTY(PROP_ATMOSPHERE_HAS_STARS, bool, _hasStars);
+
+    DECODE_GROUP_PROPERTY_HAS_CHANGED(PROP_ATMOSPHERE_CENTER, Center);
+    DECODE_GROUP_PROPERTY_HAS_CHANGED(PROP_ATMOSPHERE_INNER_RADIUS, InnerRadius);
+    DECODE_GROUP_PROPERTY_HAS_CHANGED(PROP_ATMOSPHERE_OUTER_RADIUS, OuterRadius);
+    DECODE_GROUP_PROPERTY_HAS_CHANGED(PROP_ATMOSPHERE_MIE_SCATTERING, MieScattering);
+    DECODE_GROUP_PROPERTY_HAS_CHANGED(PROP_ATMOSPHERE_RAYLEIGH_SCATTERING, RayleighScattering);
+    DECODE_GROUP_PROPERTY_HAS_CHANGED(PROP_ATMOSPHERE_SCATTERING_WAVELENGTHS, ScatteringWavelengths);
+    DECODE_GROUP_PROPERTY_HAS_CHANGED(PROP_ATMOSPHERE_HAS_STARS, HasStars);
     
     processedBytes += bytesRead;
 

libraries/entities/src/EntityItemProperties.cpp

@@ -181,6 +181,10 @@ void EntityItemProperties::debugDump() const {
     qCDebug(entities) << "   _dimensions=" << getDimensions();
     qCDebug(entities) << "   _modelURL=" << _modelURL;
     qCDebug(entities) << "   _compoundShapeURL=" << _compoundShapeURL;
+
+    getAtmosphere().debugDump();
+    getSkybox().debugDump();
+
     qCDebug(entities) << "   changed properties...";
     EntityPropertyFlags props = getChangedProperties();
     props.debugDumpBits();

libraries/entities/src/EntityItemProperties.h

@@ -279,6 +279,9 @@ inline QDebug operator<<(QDebug debug, const EntityItemProperties& properties) {
     DEBUG_PROPERTY_IF_CHANGED(debug, properties, ParticleRadius, particleRadius, "");
     DEBUG_PROPERTY_IF_CHANGED(debug, properties, MarketplaceID, marketplaceID, "");
     DEBUG_PROPERTY_IF_CHANGED(debug, properties, BackgroundMode, backgroundMode, "");
+    
+    properties.getAtmosphere().debugDump();
+    properties.getSkybox().debugDump();
 
     debug << "  last edited:" << properties.getLastEdited() << "\n";
     debug << "  edited ago:" << properties.getEditedAgo() << "\n";

libraries/entities/src/EntityItemPropertiesMacros.h

@@ -107,6 +107,11 @@
             }                                               \
         }
 
+#define DECODE_GROUP_PROPERTY_HAS_CHANGED(P,N) \
+        if (propertyFlags.getHasProperty(P)) {  \
+            set##N##Changed(true); \
+        }
+
 #define READ_ENTITY_PROPERTY_COLOR(P,M)         \
         if (propertyFlags.getHasProperty(P)) {  \
             if (overwriteLocalData) {           \

libraries/entities/src/SkyboxPropertyGroup.cpp

@@ -59,7 +59,10 @@ bool SkyboxPropertyGroup::decodeFromEditPacket(EntityPropertyFlags& propertyFlag
 
     READ_ENTITY_PROPERTY_XCOLOR(PROP_SKYBOX_COLOR, _color);
     READ_ENTITY_PROPERTY_STRING(PROP_SKYBOX_URL, setURL);
-    
+
+    DECODE_GROUP_PROPERTY_HAS_CHANGED(PROP_SKYBOX_COLOR, Color);
+    DECODE_GROUP_PROPERTY_HAS_CHANGED(PROP_SKYBOX_URL, URL);
+
     processedBytes += bytesRead;
 
     return true;