From 1ef5f048a3460cb61469842662e795f31ea0b10f Mon Sep 17 00:00:00 2001
From: David Rowe <david@ctrlaltstudio.com>
Date: Fri, 7 Apr 2017 18:53:20 +1200
Subject: [PATCH] Inform user if recording failed to start

---
 scripts/system/record.js | 22 ++++++++++++++++------
 1 file changed, 16 insertions(+), 6 deletions(-)

diff --git a/scripts/system/record.js b/scripts/system/record.js
index 65ff83c718..604b64ac0a 100644
--- a/scripts/system/record.js
+++ b/scripts/system/record.js
@@ -178,7 +178,7 @@
             log("Recording mapped to " + mappingPath);
             log("Request play recording");
 
-            play(mappingPath);
+            play("atp:" + mappingPath);
         }
 
         function saveRecordingToAssetCallback(url) {
@@ -295,7 +295,8 @@
             UPDATE_INTERVAL = 5000;  // Must be > player's HEARTBEAT_INTERVAL. TODO: Final value.
 
         function updatePlayers() {
-            var now = Date.now();
+            var now = Date.now(),
+                i;
 
             // Remove players that haven't sent a heartbeat for a while.
             for (i = playerTimestamps.length - 1; i >= 0; i -= 1) {
@@ -308,23 +309,32 @@
             }
         }
 
-        function playRecording(mapping) {
+        function playRecording(recording) {
             var index,
-                error;
+                CHECK_PLAYING_TIMEOUT = 5000;
 
             index = playerIsPlaying.indexOf(false);
             if (index === -1) {
-                error("No assignment client player available to play recording " + mapping + "!");
+                error("No assignment client player available to play recording "
+                    + recording.slice(4) + "!");  // Remove leading "atp:" from recording.
                 return;
             }
 
             Messages.sendMessage(HIFI_PLAYER_CHANNEL, JSON.stringify({
                 player: playerIDs[index],
                 command: PLAYER_COMMAND_PLAY,
-                recording: "atp:" + mapping,
+                recording: recording,
                 position: MyAvatar.position,
                 orientation: MyAvatar.orientation
             }));
+
+            Script.setTimeout(function () {
+                if (playerRecordings.indexOf(recording) === -1) {
+                    error("Didn't start playing recording "
+                        + recording.slice(4) + "!");  // Remove leading "atp:" from recording.
+                }
+            }, CHECK_PLAYING_TIMEOUT)
+
         }
 
         function onMessageReceived(channel, message, sender) {