From 1b635d8c5e363fe569234231f81840f341ad8db8 Mon Sep 17 00:00:00 2001 From: David Rowe Date: Wed, 26 Apr 2017 13:29:51 +1200 Subject: [PATCH] Replace FIXMEs with proper code --- interface/src/Application.cpp | 10 ---------- libraries/audio-client/src/AudioClient.h | 1 - 2 files changed, 11 deletions(-) diff --git a/interface/src/Application.cpp b/interface/src/Application.cpp index 947083fcab..f51c3d2b46 100644 --- a/interface/src/Application.cpp +++ b/interface/src/Application.cpp @@ -747,8 +747,6 @@ Application::Application(int& argc, char** argv, QElapsedTimer& startupTimer, bo audioIO->handleRecordedAudioInput(frame->data); }); - // FIXME: Recorder::recordFrame() doesn't handle data in the following format. - /* connect(audioIO.data(), &AudioClient::inputReceived, [](const QByteArray& audio){ static auto recorder = DependencyManager::get(); if (recorder->isRecording()) { @@ -756,14 +754,6 @@ Application::Application(int& argc, char** argv, QElapsedTimer& startupTimer, bo recorder->recordFrame(AUDIO_FRAME_TYPE, audio); } }); - */ - connect(audioIO.data(), &AudioClient::inputReceivedBuffer, [](const QByteArray& audio){ - static auto recorder = DependencyManager::get(); - if (recorder->isRecording()) { - static const recording::FrameType AUDIO_FRAME_TYPE = recording::Frame::registerFrameType(AudioConstants::getAudioFrameName()); - recorder->recordFrame(AUDIO_FRAME_TYPE, audio); - } - }); auto audioScriptingInterface = DependencyManager::set(); connect(audioThread, &QThread::started, audioIO.data(), &AudioClient::start); diff --git a/libraries/audio-client/src/AudioClient.h b/libraries/audio-client/src/AudioClient.h index 91143eec3b..139749e8e8 100644 --- a/libraries/audio-client/src/AudioClient.h +++ b/libraries/audio-client/src/AudioClient.h @@ -225,7 +225,6 @@ signals: bool muteToggled(); void mutedByMixer(); void inputReceived(const QByteArray& inputSamples); - void inputReceivedBuffer(const QByteArray& inputSamples); // FIXME: Almost a duplicate of inputReceived(). void outputBytesToNetwork(int numBytes); void inputBytesFromNetwork(int numBytes); void noiseGateOpened();