From ab227f210da939193713c7bb3583c6308d9972b4 Mon Sep 17 00:00:00 2001 From: NissimHadar Date: Tue, 5 Mar 2019 16:21:32 -0800 Subject: [PATCH 1/3] Increased threshold to 0.990 --- tools/nitpick/src/Nitpick.cpp | 2 +- tools/nitpick/src/Test.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/nitpick/src/Nitpick.cpp b/tools/nitpick/src/Nitpick.cpp index 39800c6bc6..b50205df7f 100644 --- a/tools/nitpick/src/Nitpick.cpp +++ b/tools/nitpick/src/Nitpick.cpp @@ -40,7 +40,7 @@ Nitpick::Nitpick(QWidget* parent) : QMainWindow(parent) { _ui.plainTextEdit->setReadOnly(true); - setWindowTitle("Nitpick - v3.0.0"); + setWindowTitle("Nitpick - v3.1.2"); clientProfiles << "VR-High" << "Desktop-High" << "Desktop-Low" << "Mobile-Touch" << "VR-Standalone"; _ui.clientProfileComboBox->insertItems(0, clientProfiles); diff --git a/tools/nitpick/src/Test.h b/tools/nitpick/src/Test.h index 23011d0c31..00ba07b051 100644 --- a/tools/nitpick/src/Test.h +++ b/tools/nitpick/src/Test.h @@ -116,7 +116,7 @@ private: const QString TEST_RESULTS_FOLDER { "TestResults" }; const QString TEST_RESULTS_FILENAME { "TestResults.txt" }; - const double THRESHOLD{ 0.935 }; + const double THRESHOLD{ 0.990 }; QDir _imageDirectory; From 8acec5c9e94264ea2e13936b0bfe99c954e0e333 Mon Sep 17 00:00:00 2001 From: NissimHadar Date: Thu, 7 Mar 2019 12:21:40 -0800 Subject: [PATCH 2/3] Increased threshold to 0.9999 --- tools/nitpick/src/TestCreator.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/nitpick/src/TestCreator.h b/tools/nitpick/src/TestCreator.h index e17bc1dd03..7cd38b42d4 100644 --- a/tools/nitpick/src/TestCreator.h +++ b/tools/nitpick/src/TestCreator.h @@ -121,7 +121,7 @@ private: const QString TEST_RESULTS_FOLDER { "TestResults" }; const QString TEST_RESULTS_FILENAME { "TestResults.txt" }; - const double THRESHOLD{ 0.995 }; + const double THRESHOLD{ 0.9999 }; QDir _imageDirectory; From 684f9929a9e6552a89128570c0eb59df9b617eb5 Mon Sep 17 00:00:00 2001 From: NissimHadar Date: Thu, 7 Mar 2019 12:22:07 -0800 Subject: [PATCH 3/3] Improved error message. --- tools/nitpick/src/TestCreator.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tools/nitpick/src/TestCreator.cpp b/tools/nitpick/src/TestCreator.cpp index c548a63a83..089e84904a 100644 --- a/tools/nitpick/src/TestCreator.cpp +++ b/tools/nitpick/src/TestCreator.cpp @@ -340,8 +340,10 @@ void TestCreator::finishTestsEvaluation() { if (!_isRunningFromCommandLine && !_isRunningInAutomaticTestRun) { if (numberOfFailures == 0) { QMessageBox::information(0, "Success", "All images are as expected"); + } else if (numberOfFailures == 1) { + QMessageBox::information(0, "Failure", "One image is not as expected"); } else { - QMessageBox::information(0, "Failure", "One or more images are not as expected"); + QMessageBox::information(0, "Failure", QString::number(numberOfFailures) + " images are not as expected"); } }