Mirrors/overte
3
0
Fork 0
mirror of https://github.com/overte-org/overte.git synced 2025-08-06 10:43:45 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

Don't unbusubscribe from possibly shared channel

Browse source
This commit is contained in:
David Rowe 2017-10-06 13:27:08 +13:00
parent 28c7ef2e97
commit 105457b388
2 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
scripts/shapes/shapes.js
View file

@ -1988,8 +1988,8 @@
Entities.canRezChanged.disconnect(onCanRezChanged); Entities.canRezChanged.disconnect(onCanRezChanged);
Entities.canRezTmpChanged.disconnect(onCanRezChanged); Entities.canRezTmpChanged.disconnect(onCanRezChanged);
Messages.messageReceived.disconnect(onMessageReceived); Messages.messageReceived.disconnect(onMessageReceived);
// Messages.unsubscribe(DOMAIN_CHANGED_MESSAGE); Do NOT unsubscribe because edit.js also subscribes and // Messages.unsubscribe(DOMAIN_CHANGED_MESSAGE); Do not unsubscribe because edit.js also subscribes and
// Messages.subscribe works client-wide. // Messages.subscribe works script engine-wide which would mess things up if they're both run in the same engine.
MyAvatar.dominantHandChanged.disconnect(onDominantHandChanged); MyAvatar.dominantHandChanged.disconnect(onDominantHandChanged);
MyAvatar.skeletonChanged.disconnect(onSkeletonChanged); MyAvatar.skeletonChanged.disconnect(onSkeletonChanged);

3
scripts/system/edit.js
View file

@ -1234,7 +1234,8 @@ Script.scriptEnding.connect(function () {
Messages.messageReceived.disconnect(handleMessagesReceived); Messages.messageReceived.disconnect(handleMessagesReceived);
Messages.unsubscribe("entityToolUpdates"); Messages.unsubscribe("entityToolUpdates");
Messages.unsubscribe("Toolbar-DomainChanged"); // Messages.unsubscribe("Toolbar-DomainChanged"); // Do not unsubscribe because the shapes.js app also subscribes and
// Messages.subscribe works script engine-wide which would mess things up if they're both run in the same engine.
createButton = null; createButton = null;
}); });