From 0ea901fd721081dcfcd969bdd928da007666b3f6 Mon Sep 17 00:00:00 2001 From: Brad Hefta-Gaub Date: Tue, 10 Nov 2015 08:34:58 -0800 Subject: [PATCH] fix various warnings --- .../src/RenderableParticleEffectEntityItem.cpp | 1 - libraries/recording/src/recording/Deck.cpp | 5 ++++- libraries/recording/src/recording/Frame.cpp | 1 + 3 files changed, 5 insertions(+), 2 deletions(-) diff --git a/libraries/entities-renderer/src/RenderableParticleEffectEntityItem.cpp b/libraries/entities-renderer/src/RenderableParticleEffectEntityItem.cpp index 6f3b40eb1e..41cf3b9bbf 100644 --- a/libraries/entities-renderer/src/RenderableParticleEffectEntityItem.cpp +++ b/libraries/entities-renderer/src/RenderableParticleEffectEntityItem.cpp @@ -218,7 +218,6 @@ void RenderableParticleEffectEntityItem::updateRenderItem() { _vertices.clear(); // build vertices from particle positions and radiuses - glm::vec3 frustumPosition = frustum->getPosition(); glm::vec3 dir = frustum->getDirection(); for (auto&& particle : particleDetails) { glm::vec3 right = glm::normalize(glm::cross(glm::vec3(0.0f, 1.0f, 0.0f), dir)); diff --git a/libraries/recording/src/recording/Deck.cpp b/libraries/recording/src/recording/Deck.cpp index a80fc43204..f0db37078b 100644 --- a/libraries/recording/src/recording/Deck.cpp +++ b/libraries/recording/src/recording/Deck.cpp @@ -6,4 +6,7 @@ // See the accompanying file LICENSE or http://www.apache.org/licenses/LICENSE-2.0.html // -#include "Deck.h" + +// FIXME -- DO NOT include headers in empty CPP files, it produces warnings. Once we define new symbols +// and some actual code here, we can uncomment this include. +//#include "Deck.h" diff --git a/libraries/recording/src/recording/Frame.cpp b/libraries/recording/src/recording/Frame.cpp index 211f192c0a..aac8a4d9c3 100644 --- a/libraries/recording/src/recording/Frame.cpp +++ b/libraries/recording/src/recording/Frame.cpp @@ -80,6 +80,7 @@ FrameType Frame::registerFrameType(const QString& frameTypeName) { std::call_once(once, [&] { auto headerType = frameTypes.registerValue("com.highfidelity.recording.Header"); Q_ASSERT(headerType == Frame::TYPE_HEADER); + Q_UNUSED(headerType); // FIXME - build system on unix still not upgraded to Qt 5.5.1 so Q_ASSERT still produces warnings }); return frameTypes.registerValue(frameTypeName); }