From 4caa00d6cc0707dec74c4b5edb384b4569c6c372 Mon Sep 17 00:00:00 2001 From: Zach Fox Date: Wed, 10 Jul 2019 16:42:48 -0700 Subject: [PATCH 1/6] Start BUGZ-814: Start working on a new Graphics dialog for Metaverse version of Interface --- .../dialogs/graphics/GraphicsSettings.qml | 158 ++++++++++++++++++ interface/src/Menu.cpp | 9 +- 2 files changed, 165 insertions(+), 2 deletions(-) create mode 100644 interface/resources/qml/hifi/dialogs/graphics/GraphicsSettings.qml diff --git a/interface/resources/qml/hifi/dialogs/graphics/GraphicsSettings.qml b/interface/resources/qml/hifi/dialogs/graphics/GraphicsSettings.qml new file mode 100644 index 0000000000..530b125ffc --- /dev/null +++ b/interface/resources/qml/hifi/dialogs/graphics/GraphicsSettings.qml @@ -0,0 +1,158 @@ +// +// GraphicsSettings.qml +// qml\hifi\dialogs\graphics +// +// Created by Zach Fox on 2019-07-10 +// Copyright 2019 High Fidelity, Inc. +// +// Distributed under the Apache License, Version 2.0. +// See the accompanying file LICENSE or http://www.apache.org/licenses/LICENSE-2.0.html +// + +import Hifi 1.0 as Hifi +import QtQuick 2.10 +import QtQuick.Controls 2.3 +import QtQuick.Layouts 1.12 +import stylesUit 1.0 as HifiStylesUit +import controlsUit 1.0 as HifiControlsUit +import "qrc:////qml//controls" as HifiControls + +Flickable { + HifiStylesUit.HifiConstants { id: hifi; } + + id: root; + contentWidth: parent.width + contentHeight: graphicsSettingsColumnLayout.height + clip: true + + ColumnLayout { + id: graphicsSettingsColumnLayout + anchors.left: parent.left + anchors.leftMargin: 26 + anchors.right: parent.right + anchors.rightMargin: 26 + anchors.top: parent.top + spacing: 8 + + ColumnLayout { + id: avatarNameTagsContainer + Layout.preferredWidth: parent.width + Layout.topMargin: 38 + spacing: 0 + + HifiStylesUit.RalewayRegular { + text: "GRAPHICS SETTINGS" + Layout.maximumWidth: parent.width + height: paintedHeight + size: 16 + color: "#FFFFFF" + } + + ColumnLayout { + Layout.topMargin: 10 + Layout.preferredWidth: parent.width + spacing: 0 + + HifiControlsUit.RadioButton { + id: performanceLow + colorScheme: hifi.colorSchemes.dark + fontSize: 16 + leftPadding: 0 + text: "Low" + checked: Performance.getPerformancePreset() === PerformanceEnums.LOW + onClicked: { + Performance.setPerformancePreset(PerformanceEnums.LOW); + } + } + + HifiControlsUit.RadioButton { + id: performanceMedium + colorScheme: hifi.colorSchemes.dark + fontSize: 16 + leftPadding: 0 + text: "Medium" + checked: Performance.getPerformancePreset() === PerformanceEnums.MID + onClicked: { + Performance.setPerformancePreset(PerformanceEnums.MID); + } + } + + HifiControlsUit.RadioButton { + id: performanceHigh + colorScheme: hifi.colorSchemes.dark + fontSize: 16 + leftPadding: 0 + text: "High" + checked: Performance.getPerformancePreset() === PerformanceEnums.HIGH + onClicked: { + Performance.setPerformancePreset(PerformanceEnums.HIGH); + } + } + + HifiControlsUit.RadioButton { + id: performanceCustom + colorScheme: hifi.colorSchemes.dark + fontSize: 16 + leftPadding: 0 + text: "Custom" + checked: !(performanceLow.checked || performanceMedium.checked || performanceHigh.checked) + onClicked: { + + } + } + } + + ColumnLayout { + Layout.topMargin: 10 + Layout.preferredWidth: parent.width + spacing: 0 + + Item { + Layout.preferredWidth: parent.width + + HifiStylesUit.RalewayRegular { + id: resolutionHeader + text: "Resolution Scale (" + Number.parseFloat(Render.viewportResolutionScale).toPrecision(3) + ")" + anchors.left: parent.left + anchors.top: parent.top + width: 130 + height: paintedHeight + size: 16 + color: "#FFFFFF" + } + + HifiControlsUit.Slider { + id: resolutionScaleSlider + enabled: performanceCustom.checked + anchors.left: resolutionHeader.right + anchors.leftMargin: 57 + anchors.top: parent.top + width: 150 + height: resolutionHeader.height + colorScheme: hifi.colorSchemes.dark + minimumValue: 0.25 + maximumValue: 1.5 + stepSize: 0.02 + value: Render.viewportResolutionScale + live: true + + function updateResolutionScale(sliderValue) { + if (Render.viewportResolutionScale !== sliderValue) { + Render.viewportResolutionScale = sliderValue; + } + } + + onValueChanged: { + updateResolutionScale(value); + } + onPressedChanged: { + if (!pressed) { + updateResolutionScale(value); + } + } + } + } + } + } + } +} diff --git a/interface/src/Menu.cpp b/interface/src/Menu.cpp index 8bee8de8c3..4cf78c23ee 100644 --- a/interface/src/Menu.cpp +++ b/interface/src/Menu.cpp @@ -266,8 +266,13 @@ Menu::Menu() { // Settings > Graphics... action = addActionToQMenuAndActionHash(settingsMenu, "Graphics..."); connect(action, &QAction::triggered, [] { - qApp->showDialog(QString("hifi/dialogs/GraphicsPreferencesDialog.qml"), - QString("hifi/tablet/TabletGraphicsPreferences.qml"), "GraphicsPreferencesDialog"); + auto tablet = DependencyManager::get()->getTablet("com.highfidelity.interface.tablet.system"); + auto hmd = DependencyManager::get(); + tablet->pushOntoStack("hifi/dialogs/graphics/GraphicsSettings.qml"); + + if (!hmd->getShouldShowTablet()) { + hmd->toggleShouldShowTablet(); + } }); // Settings > Security... From ce2b7e5baa07cdb51781125b389ac07892867864 Mon Sep 17 00:00:00 2001 From: Zach Fox Date: Thu, 11 Jul 2019 12:05:13 -0700 Subject: [PATCH 2/6] Finish all of the logic and most of the layout --- .../resources/qml/controlsUit/ComboBox.qml | 1 + .../dialogs/graphics/GraphicsSettings.qml | 228 +++++++++++++++++- interface/src/PerformanceManager.cpp | 4 +- .../PlatformInfoScriptingInterface.cpp | 4 +- .../PlatformInfoScriptingInterface.h | 7 +- 5 files changed, 235 insertions(+), 9 deletions(-) diff --git a/interface/resources/qml/controlsUit/ComboBox.qml b/interface/resources/qml/controlsUit/ComboBox.qml index 8d1d7a5262..1a904df89d 100644 --- a/interface/resources/qml/controlsUit/ComboBox.qml +++ b/interface/resources/qml/controlsUit/ComboBox.qml @@ -22,6 +22,7 @@ FocusScope { property alias editable: comboBox.editable property alias comboBox: comboBox readonly property alias currentText: comboBox.currentText; + property alias displayText: comboBox.displayText; property alias currentIndex: comboBox.currentIndex; property int currentHighLightedIndex: comboBox.currentIndex; diff --git a/interface/resources/qml/hifi/dialogs/graphics/GraphicsSettings.qml b/interface/resources/qml/hifi/dialogs/graphics/GraphicsSettings.qml index 530b125ffc..34f1caa737 100644 --- a/interface/resources/qml/hifi/dialogs/graphics/GraphicsSettings.qml +++ b/interface/resources/qml/hifi/dialogs/graphics/GraphicsSettings.qml @@ -16,6 +16,7 @@ import QtQuick.Layouts 1.12 import stylesUit 1.0 as HifiStylesUit import controlsUit 1.0 as HifiControlsUit import "qrc:////qml//controls" as HifiControls +import PerformanceEnums 1.0 Flickable { HifiStylesUit.HifiConstants { id: hifi; } @@ -51,6 +52,7 @@ Flickable { ColumnLayout { Layout.topMargin: 10 Layout.preferredWidth: parent.width + Layout.preferredHeight: contentItem.height spacing: 0 HifiControlsUit.RadioButton { @@ -62,6 +64,7 @@ Flickable { checked: Performance.getPerformancePreset() === PerformanceEnums.LOW onClicked: { Performance.setPerformancePreset(PerformanceEnums.LOW); + root.refreshAllDropdowns(); } } @@ -74,6 +77,7 @@ Flickable { checked: Performance.getPerformancePreset() === PerformanceEnums.MID onClicked: { Performance.setPerformancePreset(PerformanceEnums.MID); + root.refreshAllDropdowns(); } } @@ -86,6 +90,7 @@ Flickable { checked: Performance.getPerformancePreset() === PerformanceEnums.HIGH onClicked: { Performance.setPerformancePreset(PerformanceEnums.HIGH); + root.refreshAllDropdowns(); } } @@ -95,9 +100,9 @@ Flickable { fontSize: 16 leftPadding: 0 text: "Custom" - checked: !(performanceLow.checked || performanceMedium.checked || performanceHigh.checked) + checked: Performance.getPerformancePreset() === PerformanceEnums.UNKNOWN onClicked: { - + Performance.setPerformancePreset(PerformanceEnums.UNKNOWN); } } } @@ -105,10 +110,12 @@ Flickable { ColumnLayout { Layout.topMargin: 10 Layout.preferredWidth: parent.width - spacing: 0 + Layout.preferredHeight: contentItem.height + spacing: 30 Item { Layout.preferredWidth: parent.width + Layout.preferredHeight: 35 HifiStylesUit.RalewayRegular { id: resolutionHeader @@ -116,7 +123,7 @@ Flickable { anchors.left: parent.left anchors.top: parent.top width: 130 - height: paintedHeight + height: parent.height size: 16 color: "#FFFFFF" } @@ -128,7 +135,7 @@ Flickable { anchors.leftMargin: 57 anchors.top: parent.top width: 150 - height: resolutionHeader.height + height: parent.height colorScheme: hifi.colorSchemes.dark minimumValue: 0.25 maximumValue: 1.5 @@ -152,7 +159,218 @@ Flickable { } } } + + Item { + Layout.preferredWidth: parent.width + Layout.preferredHeight: 35 + + HifiStylesUit.RalewayRegular { + id: worldDetailHeader + text: "World Detail" + anchors.left: parent.left + anchors.top: parent.top + width: 130 + height: parent.height + size: 16 + color: "#FFFFFF" + } + + ListModel { + id: worldDetailModel + + ListElement { + text: "Low World Detail" + worldDetailQualityValue: 0.25 + } + ListElement { + text: "Medium World Detail" + worldDetailQualityValue: 0.5 + } + ListElement { + text: "Full World Detail" + worldDetailQualityValue: 0.75 + } + } + + HifiControlsUit.ComboBox { + id: worldDetailDropdown + enabled: performanceCustom.checked + anchors.left: worldDetailHeader.right + anchors.leftMargin: 20 + anchors.top: parent.top + width: 280 + height: parent.height + colorScheme: hifi.colorSchemes.dark + model: worldDetailModel + currentIndex: -1 + + function refreshWorldDetailDropdown() { + var currentWorldDetailQuality = LODManager.worldDetailQuality; + if (currentWorldDetailQuality <= 0.25) { + worldDetailDropdown.currentIndex = 0; + } else if (currentWorldDetailQuality <= 0.5) { + worldDetailDropdown.currentIndex = 1; + } else { + worldDetailDropdown.currentIndex = 2; + } + } + + Component.onCompleted: { + worldDetailDropdown.refreshWorldDetailDropdown(); + } + + onCurrentIndexChanged: { + LODManager.worldDetailQuality = model.get(currentIndex).worldDetailQualityValue; + worldDetailDropdown.displayText = model.get(currentIndex).text; + } + } + } + + Item { + Layout.preferredWidth: parent.width + Layout.preferredHeight: 35 + + HifiStylesUit.RalewayRegular { + id: renderingEffectsHeader + text: "Rendering Effects" + anchors.left: parent.left + anchors.top: parent.top + width: 130 + height: parent.height + size: 16 + color: "#FFFFFF" + } + + ListModel { + id: renderingEffectsModel + + ListElement { + text: "No Rendering Effects" + preferredRenderMethod: 1 // "FORWARD" + shadowsEnabled: false + } + ListElement { + text: "Local Lights, Fog, Bloom" + preferredRenderMethod: 0 // "DEFERRED" + shadowsEnabled: false + } + ListElement { + text: "Local Lights, Fog, Bloom, Shadows" + preferredRenderMethod: 0 // "DEFERRED" + shadowsEnabled: true + } + } + + HifiControlsUit.ComboBox { + id: renderingEffectsDropdown + enabled: performanceCustom.checked + anchors.left: renderingEffectsHeader.right + anchors.leftMargin: 20 + anchors.top: parent.top + width: 280 + height: parent.height + colorScheme: hifi.colorSchemes.dark + model: renderingEffectsModel + currentIndex: -1 + + function refreshRenderingEffectsDropdownDisplay() { + if (Render.shadowsEnabled) { + renderingEffectsDropdown.currentIndex = 2; + } else if (Render.renderMethod === 0) { + renderingEffectsDropdown.currentIndex = 1; + } else { + renderingEffectsDropdown.currentIndex = 0; + } + } + + Component.onCompleted: { + renderingEffectsDropdown.refreshRenderingEffectsDropdownDisplay(); + } + + onCurrentIndexChanged: { + var renderMethodToSet = 1; + if (model.get(currentIndex).preferredRenderMethod === 0 && + PlatformInfo.isRenderMethodDeferredCapable()) { + renderMethodToSet = 0; + } + Render.renderMethod = model.get(currentIndex).preferredRenderMethod; + Render.shadowsEnabled = model.get(currentIndex).shadowsEnabled; + renderingEffectsDropdown.displayText = model.get(currentIndex).text; + } + } + } + + Item { + Layout.preferredWidth: parent.width + Layout.preferredHeight: 35 + + HifiStylesUit.RalewayRegular { + id: refreshRateHeader + text: "Refresh Rate" + anchors.left: parent.left + anchors.top: parent.top + width: 130 + height: parent.height + size: 16 + color: "#FFFFFF" + } + + ListModel { + id: refreshRateModel + + ListElement { + text: "Economical" + refreshRatePreset: 0 // RefreshRateProfile::ECO + } + ListElement { + text: "Interactive" + refreshRatePreset: 1 // RefreshRateProfile::INTERACTIVE + } + ListElement { + text: "Real-Time" + refreshRatePreset: 2 // RefreshRateProfile::REALTIME + } + } + + HifiControlsUit.ComboBox { + id: refreshRateDropdown + enabled: performanceCustom.checked + anchors.left: refreshRateHeader.right + anchors.leftMargin: 20 + anchors.top: parent.top + width: 280 + height: parent.height + colorScheme: hifi.colorSchemes.dark + model: refreshRateModel + currentIndex: -1 + + function refreshRefreshRateDropdownDisplay() { + if (Performance.getRefreshRateProfile() === 0) { + refreshRateDropdown.currentIndex = 0; + } else if (Performance.getRefreshRateProfile() === 1) { + refreshRateDropdown.currentIndex = 1; + } else { + refreshRateDropdown.currentIndex = 2; + } + } + + Component.onCompleted: { + refreshRateDropdown.refreshRefreshRateDropdownDisplay(); + } + + onCurrentIndexChanged: { + Performance.setRefreshRateProfile(model.get(currentIndex).refreshRatePreset); + refreshRateDropdown.displayText = model.get(currentIndex).text; + } + } + } } } } + + function refreshAllDropdowns() { + worldDetailDropdown.refreshWorldDetailDropdown(); + renderingEffectsDropdown.refreshRenderingEffectsDropdownDisplay(); + refreshRateDropdown.refreshRefreshRateDropdownDisplay(); + } } diff --git a/interface/src/PerformanceManager.cpp b/interface/src/PerformanceManager.cpp index ec12ab0404..80c09e3fec 100644 --- a/interface/src/PerformanceManager.cpp +++ b/interface/src/PerformanceManager.cpp @@ -92,7 +92,7 @@ void PerformanceManager::applyPerformancePreset(PerformanceManager::PerformanceP RenderScriptingInterface::getInstance()->setShadowsEnabled(true); qApp->getRefreshRateManager().setRefreshRateProfile(RefreshRateManager::RefreshRateProfile::REALTIME); - DependencyManager::get()->setWorldDetailQuality(0.5f); + DependencyManager::get()->setWorldDetailQuality(0.75f); break; case PerformancePreset::MID: @@ -114,7 +114,7 @@ void PerformanceManager::applyPerformancePreset(PerformanceManager::PerformanceP RenderScriptingInterface::getInstance()->setViewportResolutionScale(recommandedPpiScale); - DependencyManager::get()->setWorldDetailQuality(0.75f); + DependencyManager::get()->setWorldDetailQuality(0.25f); break; case PerformancePreset::UNKNOWN: diff --git a/interface/src/scripting/PlatformInfoScriptingInterface.cpp b/interface/src/scripting/PlatformInfoScriptingInterface.cpp index cbd94b3dd5..9adf514718 100644 --- a/interface/src/scripting/PlatformInfoScriptingInterface.cpp +++ b/interface/src/scripting/PlatformInfoScriptingInterface.cpp @@ -221,4 +221,6 @@ QStringList PlatformInfoScriptingInterface::getPlatformTierNames() { return platformTierNames; } - +bool PlatformInfoScriptingInterface::isRenderMethodDeferredCapable() { + return platform::Profiler::isRenderMethodDeferredCapable(); +} diff --git a/interface/src/scripting/PlatformInfoScriptingInterface.h b/interface/src/scripting/PlatformInfoScriptingInterface.h index 9ac67ec0bd..f59d476f0c 100644 --- a/interface/src/scripting/PlatformInfoScriptingInterface.h +++ b/interface/src/scripting/PlatformInfoScriptingInterface.h @@ -245,7 +245,12 @@ public slots: */ QStringList getPlatformTierNames(); - + /**jsdoc + * Gets whether the current hardware can render using the Deferred method. + * @function PlatformInfo.isRenderMethodDeferredCapable + * @returns {bool} true if the current hardware can render using the Deferred method; false otherwise. + */ + bool isRenderMethodDeferredCapable(); }; #endif // hifi_PlatformInfoScriptingInterface_h From 4c7d0fc6f423b01fb5ae8fafe79d3a08e70df97d Mon Sep 17 00:00:00 2001 From: Zach Fox Date: Thu, 11 Jul 2019 14:46:05 -0700 Subject: [PATCH 3/6] Updated layout --- .../dialogs/graphics/GraphicsSettings.qml | 115 +++++++++--------- 1 file changed, 59 insertions(+), 56 deletions(-) diff --git a/interface/resources/qml/hifi/dialogs/graphics/GraphicsSettings.qml b/interface/resources/qml/hifi/dialogs/graphics/GraphicsSettings.qml index 34f1caa737..d82ac47eb3 100644 --- a/interface/resources/qml/hifi/dialogs/graphics/GraphicsSettings.qml +++ b/interface/resources/qml/hifi/dialogs/graphics/GraphicsSettings.qml @@ -18,13 +18,11 @@ import controlsUit 1.0 as HifiControlsUit import "qrc:////qml//controls" as HifiControls import PerformanceEnums 1.0 -Flickable { +Item { HifiStylesUit.HifiConstants { id: hifi; } id: root; - contentWidth: parent.width - contentHeight: graphicsSettingsColumnLayout.height - clip: true + anchors.fill: parent ColumnLayout { id: graphicsSettingsColumnLayout @@ -38,13 +36,13 @@ Flickable { ColumnLayout { id: avatarNameTagsContainer Layout.preferredWidth: parent.width - Layout.topMargin: 38 + Layout.topMargin: 18 spacing: 0 HifiStylesUit.RalewayRegular { text: "GRAPHICS SETTINGS" Layout.maximumWidth: parent.width - height: paintedHeight + height: 30 size: 16 color: "#FFFFFF" } @@ -52,12 +50,12 @@ Flickable { ColumnLayout { Layout.topMargin: 10 Layout.preferredWidth: parent.width - Layout.preferredHeight: contentItem.height spacing: 0 HifiControlsUit.RadioButton { id: performanceLow colorScheme: hifi.colorSchemes.dark + height: 18 fontSize: 16 leftPadding: 0 text: "Low" @@ -71,6 +69,7 @@ Flickable { HifiControlsUit.RadioButton { id: performanceMedium colorScheme: hifi.colorSchemes.dark + height: 18 fontSize: 16 leftPadding: 0 text: "Medium" @@ -84,6 +83,7 @@ Flickable { HifiControlsUit.RadioButton { id: performanceHigh colorScheme: hifi.colorSchemes.dark + height: 18 fontSize: 16 leftPadding: 0 text: "High" @@ -97,6 +97,7 @@ Flickable { HifiControlsUit.RadioButton { id: performanceCustom colorScheme: hifi.colorSchemes.dark + height: 18 fontSize: 16 leftPadding: 0 text: "Custom" @@ -110,55 +111,7 @@ Flickable { ColumnLayout { Layout.topMargin: 10 Layout.preferredWidth: parent.width - Layout.preferredHeight: contentItem.height - spacing: 30 - - Item { - Layout.preferredWidth: parent.width - Layout.preferredHeight: 35 - - HifiStylesUit.RalewayRegular { - id: resolutionHeader - text: "Resolution Scale (" + Number.parseFloat(Render.viewportResolutionScale).toPrecision(3) + ")" - anchors.left: parent.left - anchors.top: parent.top - width: 130 - height: parent.height - size: 16 - color: "#FFFFFF" - } - - HifiControlsUit.Slider { - id: resolutionScaleSlider - enabled: performanceCustom.checked - anchors.left: resolutionHeader.right - anchors.leftMargin: 57 - anchors.top: parent.top - width: 150 - height: parent.height - colorScheme: hifi.colorSchemes.dark - minimumValue: 0.25 - maximumValue: 1.5 - stepSize: 0.02 - value: Render.viewportResolutionScale - live: true - - function updateResolutionScale(sliderValue) { - if (Render.viewportResolutionScale !== sliderValue) { - Render.viewportResolutionScale = sliderValue; - } - } - - onValueChanged: { - updateResolutionScale(value); - } - onPressedChanged: { - if (!pressed) { - updateResolutionScale(value); - } - } - } - } + spacing: 0 Item { Layout.preferredWidth: parent.width @@ -229,6 +182,7 @@ Flickable { Item { Layout.preferredWidth: parent.width Layout.preferredHeight: 35 + Layout.topMargin: 20 HifiStylesUit.RalewayRegular { id: renderingEffectsHeader @@ -303,6 +257,7 @@ Flickable { Item { Layout.preferredWidth: parent.width Layout.preferredHeight: 35 + Layout.topMargin: 20 HifiStylesUit.RalewayRegular { id: refreshRateHeader @@ -364,6 +319,54 @@ Flickable { } } } + + Item { + Layout.preferredWidth: parent.width + Layout.preferredHeight: 35 + Layout.topMargin: 16 + + HifiStylesUit.RalewayRegular { + id: resolutionHeader + text: "Resolution Scale (" + Number.parseFloat(Render.viewportResolutionScale).toPrecision(3) + ")" + anchors.left: parent.left + anchors.top: parent.top + width: 130 + height: parent.height + size: 16 + color: "#FFFFFF" + } + + HifiControlsUit.Slider { + id: resolutionScaleSlider + enabled: performanceCustom.checked + anchors.left: resolutionHeader.right + anchors.leftMargin: 57 + anchors.top: parent.top + width: 150 + height: parent.height + colorScheme: hifi.colorSchemes.dark + minimumValue: 0.25 + maximumValue: 1.5 + stepSize: 0.02 + value: Render.viewportResolutionScale + live: true + + function updateResolutionScale(sliderValue) { + if (Render.viewportResolutionScale !== sliderValue) { + Render.viewportResolutionScale = sliderValue; + } + } + + onValueChanged: { + updateResolutionScale(value); + } + onPressedChanged: { + if (!pressed) { + updateResolutionScale(value); + } + } + } + } } } } From 56a55efbb3fc8e920eebaa94065027ef48088e33 Mon Sep 17 00:00:00 2001 From: Zach Fox Date: Thu, 11 Jul 2019 16:12:40 -0700 Subject: [PATCH 4/6] Fix a quick renderer bug --- .../resources/qml/hifi/dialogs/graphics/GraphicsSettings.qml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/interface/resources/qml/hifi/dialogs/graphics/GraphicsSettings.qml b/interface/resources/qml/hifi/dialogs/graphics/GraphicsSettings.qml index d82ac47eb3..88709c8be7 100644 --- a/interface/resources/qml/hifi/dialogs/graphics/GraphicsSettings.qml +++ b/interface/resources/qml/hifi/dialogs/graphics/GraphicsSettings.qml @@ -247,7 +247,7 @@ Item { PlatformInfo.isRenderMethodDeferredCapable()) { renderMethodToSet = 0; } - Render.renderMethod = model.get(currentIndex).preferredRenderMethod; + Render.renderMethod = renderMethodToSet; Render.shadowsEnabled = model.get(currentIndex).shadowsEnabled; renderingEffectsDropdown.displayText = model.get(currentIndex).text; } From e0392642f71110f515b92c454ee0add656854282 Mon Sep 17 00:00:00 2001 From: Zach Fox Date: Fri, 12 Jul 2019 11:18:34 -0700 Subject: [PATCH 5/6] Don't enable supersampling from graphics settings --- .../resources/qml/hifi/dialogs/graphics/GraphicsSettings.qml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/interface/resources/qml/hifi/dialogs/graphics/GraphicsSettings.qml b/interface/resources/qml/hifi/dialogs/graphics/GraphicsSettings.qml index 88709c8be7..65e74768c1 100644 --- a/interface/resources/qml/hifi/dialogs/graphics/GraphicsSettings.qml +++ b/interface/resources/qml/hifi/dialogs/graphics/GraphicsSettings.qml @@ -346,7 +346,7 @@ Item { height: parent.height colorScheme: hifi.colorSchemes.dark minimumValue: 0.25 - maximumValue: 1.5 + maximumValue: 1.0 stepSize: 0.02 value: Render.viewportResolutionScale live: true From 5828f46c6b3928081608c94ddeedc4a802ce542a Mon Sep 17 00:00:00 2001 From: Zach Fox Date: Fri, 12 Jul 2019 12:27:55 -0700 Subject: [PATCH 6/6] Incorrect ID fixed - thanks Milad --- .../resources/qml/hifi/dialogs/graphics/GraphicsSettings.qml | 1 - 1 file changed, 1 deletion(-) diff --git a/interface/resources/qml/hifi/dialogs/graphics/GraphicsSettings.qml b/interface/resources/qml/hifi/dialogs/graphics/GraphicsSettings.qml index 65e74768c1..f7c82c90a1 100644 --- a/interface/resources/qml/hifi/dialogs/graphics/GraphicsSettings.qml +++ b/interface/resources/qml/hifi/dialogs/graphics/GraphicsSettings.qml @@ -34,7 +34,6 @@ Item { spacing: 8 ColumnLayout { - id: avatarNameTagsContainer Layout.preferredWidth: parent.width Layout.topMargin: 18 spacing: 0