mirror of
https://github.com/overte-org/overte.git
synced 2025-08-10 22:13:12 +02:00
code review feedback
This commit is contained in:
parent
809e986738
commit
0873b88347
2 changed files with 2 additions and 2 deletions
|
@ -6676,7 +6676,7 @@ void Application::addAssetToWorldCheckModelSize() {
|
||||||
if (dimensions != DEFAULT_DIMENSIONS) {
|
if (dimensions != DEFAULT_DIMENSIONS) {
|
||||||
|
|
||||||
// Scale model so that its maximum is exactly specific size.
|
// Scale model so that its maximum is exactly specific size.
|
||||||
const float MAXIMUM_DIMENSION = 1.0f * getMyAvatar()->getSensorToWorldScale();
|
const float MAXIMUM_DIMENSION = getMyAvatar()->getSensorToWorldScale();
|
||||||
auto previousDimensions = dimensions;
|
auto previousDimensions = dimensions;
|
||||||
auto scale = std::min(MAXIMUM_DIMENSION / dimensions.x, std::min(MAXIMUM_DIMENSION / dimensions.y,
|
auto scale = std::min(MAXIMUM_DIMENSION / dimensions.x, std::min(MAXIMUM_DIMENSION / dimensions.y,
|
||||||
MAXIMUM_DIMENSION / dimensions.z));
|
MAXIMUM_DIMENSION / dimensions.z));
|
||||||
|
|
|
@ -249,7 +249,7 @@
|
||||||
noticeWidth = notice.width * NOTIFICATION_3D_SCALE + NOTIFICATION_3D_BUTTON_WIDTH;
|
noticeWidth = notice.width * NOTIFICATION_3D_SCALE + NOTIFICATION_3D_BUTTON_WIDTH;
|
||||||
noticeHeight = notice.height * NOTIFICATION_3D_SCALE;
|
noticeHeight = notice.height * NOTIFICATION_3D_SCALE;
|
||||||
|
|
||||||
notice.size = { x: noticeWidth, y: noticeHeight};
|
notice.size = { x: noticeWidth, y: noticeHeight };
|
||||||
|
|
||||||
positions = calculate3DOverlayPositions(noticeWidth, noticeHeight, notice.y);
|
positions = calculate3DOverlayPositions(noticeWidth, noticeHeight, notice.y);
|
||||||
|
|
||||||
|
|
Loading…
Reference in a new issue