Mirrors/overte
3
0
Fork 0
mirror of https://github.com/overte-org/overte.git synced 2025-08-10 03:40:20 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge pull request #12717 from sethalves/workaround-dialog-crash

Browse source 
fix -- work around asset-upload dialog crash
This commit is contained in:
John Conklin II 2018-03-27 13:35:50 -07:00 committed by GitHub
commit 0862f345fe
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 12 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
interface/resources/qml/dialogs/CustomQueryDialog.qml
View file

@ -270,7 +270,9 @@ ModalWindow {
onTriggered: { onTriggered: {
root.result = null; root.result = null;
root.canceled(); root.canceled();
root.destroy(); // FIXME we are leaking memory to avoid a crash
// root.destroy();
visible = false;
} }
} }
@ -292,7 +294,9 @@ ModalWindow {
} }
root.result = JSON.stringify(result); root.result = JSON.stringify(result);
root.selected(root.result); root.selected(root.result);
root.destroy(); // FIXME we are leaking memory to avoid a crash
// root.destroy();
visible = false;
} }
} }
} }

8
interface/resources/qml/dialogs/QueryDialog.qml
View file

@ -169,7 +169,9 @@ ModalWindow {
shortcut: Qt.Key_Escape shortcut: Qt.Key_Escape
onTriggered: { onTriggered: {
root.canceled(); root.canceled();
root.destroy(); // FIXME we are leaking memory to avoid a crash
// root.destroy();
visible = false;
} }
} }
Action { Action {
@ -179,7 +181,9 @@ ModalWindow {
onTriggered: { onTriggered: {
root.result = items ? comboBox.currentText : textResult.text root.result = items ? comboBox.currentText : textResult.text
root.selected(root.result); root.selected(root.result);
root.destroy(); // FIXME we are leaking memory to avoid a crash
// root.destroy();
visible = false;
} }
} }
} }