From d6c0defd98a8fb1fa9a95999cec3af32fb2e7035 Mon Sep 17 00:00:00 2001 From: Stephen Birarda Date: Wed, 30 Jul 2014 14:05:20 -0700 Subject: [PATCH 01/16] check in VS2010 subdir to see oculus 0.4.0 library --- cmake/modules/FindLibOVR.cmake | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cmake/modules/FindLibOVR.cmake b/cmake/modules/FindLibOVR.cmake index 786a24a06b..74095cbf77 100644 --- a/cmake/modules/FindLibOVR.cmake +++ b/cmake/modules/FindLibOVR.cmake @@ -49,8 +49,8 @@ elseif (UNIX) select_library_configurations(XINERAMA) elseif (WIN32) - find_library(LIBOVR_LIBRARY_DEBUG "Lib/Win32/libovrd.lib" HINTS ${OCULUS_SEARCH_DIRS}) - find_library(LIBOVR_LIBRARY_RELEASE "Lib/Win32/libovr.lib" HINTS ${OCULUS_SEARCH_DIRS}) + find_library(LIBOVR_LIBRARY_DEBUG NAME ovrd PATH_SUFFIXES Lib/Win32 Lib/Win32/VS2010 HINTS ${OCULUS_SEARCH_DIRS}) + find_library(LIBOVR_LIBRARY_RELEASE NAME ovr PATH_SUFFIXES Lib/Win32 Lib/Win32/VS2010 HINTS ${OCULUS_SEARCH_DIRS}) endif () select_library_configurations(LIBOVR) From 4d3aafa5df285a9957b314ac3491408b1d9ebad0 Mon Sep 17 00:00:00 2001 From: Stephen Birarda Date: Wed, 30 Jul 2014 14:07:40 -0700 Subject: [PATCH 02/16] use path suffixes instead of full path in name --- cmake/modules/FindLibOVR.cmake | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/cmake/modules/FindLibOVR.cmake b/cmake/modules/FindLibOVR.cmake index 74095cbf77..7c9e876345 100644 --- a/cmake/modules/FindLibOVR.cmake +++ b/cmake/modules/FindLibOVR.cmake @@ -30,8 +30,8 @@ set(LIBOVR_INCLUDE_DIRS "${LIBOVR_INCLUDE_DIRS}" "${LIBOVR_UTIL_INCLUDE_DIR}") include(SelectLibraryConfigurations) if (APPLE) - find_library(LIBOVR_LIBRARY_DEBUG "Lib/MacOS/Debug/libovr.a" HINTS ${OCULUS_SEARCH_DIRS}) - find_library(LIBOVR_LIBRARY_RELEASE "Lib/MacOS/Release/libovr.a" HINTS ${OCULUS_SEARCH_DIRS}) + find_library(LIBOVR_LIBRARY_DEBUG ovr PATH_SUFFIXES Lib/MacOS/Debug HINTS ${OCULUS_SEARCH_DIRS}) + find_library(LIBOVR_LIBRARY_RELEASE ovr PATH_SUFFIXES Lib/MacOS/Release HINTS ${OCULUS_SEARCH_DIRS}) elseif (UNIX) find_library(UDEV_LIBRARY_RELEASE udev /usr/lib/x86_64-linux-gnu/) find_library(XINERAMA_LIBRARY_RELEASE Xinerama /usr/lib/x86_64-linux-gnu/) @@ -42,15 +42,15 @@ elseif (UNIX) set(LINUX_ARCH_DIR "x86_64") endif() - find_library(LIBOVR_LIBRARY_DEBUG "Lib/Linux/Debug/${LINUX_ARCH_DIR}/libovr.a" HINTS ${OCULUS_SEARCH_DIRS}) - find_library(LIBOVR_LIBRARY_RELEASE "Lib/Linux/Release/${LINUX_ARCH_DIR}/libovr.a" HINTS ${OCULUS_SEARCH_DIRS}) + find_library(LIBOVR_LIBRARY_DEBUG ovr PATH_SUFFIXES Lib/Linux/Debug/${LINUX_ARCH_DIR} HINTS ${OCULUS_SEARCH_DIRS}) + find_library(LIBOVR_LIBRARY_RELEASE ovr PATH_SUFFIXES Lib/Linux/Release/${LINUX_ARCH_DIR}/ HINTS ${OCULUS_SEARCH_DIRS}) select_library_configurations(UDEV) select_library_configurations(XINERAMA) elseif (WIN32) - find_library(LIBOVR_LIBRARY_DEBUG NAME ovrd PATH_SUFFIXES Lib/Win32 Lib/Win32/VS2010 HINTS ${OCULUS_SEARCH_DIRS}) - find_library(LIBOVR_LIBRARY_RELEASE NAME ovr PATH_SUFFIXES Lib/Win32 Lib/Win32/VS2010 HINTS ${OCULUS_SEARCH_DIRS}) + find_library(LIBOVR_LIBRARY_DEBUG ovrd PATH_SUFFIXES Lib/Win32 Lib/Win32/VS2010 HINTS ${OCULUS_SEARCH_DIRS}) + find_library(LIBOVR_LIBRARY_RELEASE ovr PATH_SUFFIXES Lib/Win32 Lib/Win32/VS2010 HINTS ${OCULUS_SEARCH_DIRS}) endif () select_library_configurations(LIBOVR) From 4be8a92e52ac772883eb92768beae8f144eec9ce Mon Sep 17 00:00:00 2001 From: Stephen Birarda Date: Wed, 30 Jul 2014 14:15:14 -0700 Subject: [PATCH 03/16] remove explicit requirement of LibOVR source file in OculusManager --- cmake/modules/FindLibOVR.cmake | 9 +++------ interface/src/devices/OculusManager.h | 1 - 2 files changed, 3 insertions(+), 7 deletions(-) diff --git a/cmake/modules/FindLibOVR.cmake b/cmake/modules/FindLibOVR.cmake index 7c9e876345..abec6c5e7f 100644 --- a/cmake/modules/FindLibOVR.cmake +++ b/cmake/modules/FindLibOVR.cmake @@ -22,10 +22,7 @@ include("${MACRO_DIR}/HifiLibrarySearchHints.cmake") hifi_library_search_hints("oculus") find_path(LIBOVR_INCLUDE_DIRS OVR.h PATH_SUFFIXES Include HINTS ${OCULUS_SEARCH_DIRS}) -find_path(LIBOVR_UTIL_INCLUDE_DIR Util_Render_Stereo.h PATH_SUFFIXES Src/Util HINTS ${OCULUS_SEARCH_DIRS}) - -# add the util include dir to the general include dirs -set(LIBOVR_INCLUDE_DIRS "${LIBOVR_INCLUDE_DIRS}" "${LIBOVR_UTIL_INCLUDE_DIR}") +find_path(LIBOVR_SRC_DIR Util_Render_Stereo.h PATH_SUFFIXES Src/Util HINTS ${OCULUS_SEARCH_DIRS}) include(SelectLibraryConfigurations) @@ -59,9 +56,9 @@ set(LIBOVR_LIBRARIES "${LIBOVR_LIBRARIES}" "${UDEV_LIBRARY}" "${XINERAMA_LIBRARY include(FindPackageHandleStandardArgs) if (UNIX) - find_package_handle_standard_args(LIBOVR DEFAULT_MSG LIBOVR_INCLUDE_DIRS LIBOVR_UTIL_INCLUDE_DIR LIBOVR_LIBRARIES) + find_package_handle_standard_args(LIBOVR DEFAULT_MSG LIBOVR_INCLUDE_DIRS LIBOVR_SRC_DIR LIBOVR_LIBRARIES) elseif () - find_package_handle_standard_args(LIBOVR DEFAULT_MSG LIBOVR_INCLUDE_DIRS LIBOVR_UTIL_INCLUDE_DIR LIBOVR_LIBRARIES UDEV_LIBRARY XINERAMA_LIBRARY) + find_package_handle_standard_args(LIBOVR DEFAULT_MSG LIBOVR_INCLUDE_DIRS LIBOVR_SRC_DIR LIBOVR_LIBRARIES UDEV_LIBRARY XINERAMA_LIBRARY) endif () mark_as_advanced(LIBOVR_INCLUDE_DIRS LIBOVR_LIBRARIES OCULUS_SEARCH_DIRS) diff --git a/interface/src/devices/OculusManager.h b/interface/src/devices/OculusManager.h index 466b8c893a..8c929bb50a 100644 --- a/interface/src/devices/OculusManager.h +++ b/interface/src/devices/OculusManager.h @@ -15,7 +15,6 @@ #ifdef HAVE_LIBOVR #include -#include #endif #include "renderer/ProgramObject.h" From 7302af4fec8e82ab02dc3f17477b76b31e1e8e82 Mon Sep 17 00:00:00 2001 From: Stephen Birarda Date: Wed, 30 Jul 2014 14:52:58 -0700 Subject: [PATCH 04/16] fix bad conditional in LibOVR find module --- cmake/modules/FindLibOVR.cmake | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/cmake/modules/FindLibOVR.cmake b/cmake/modules/FindLibOVR.cmake index abec6c5e7f..805f673682 100644 --- a/cmake/modules/FindLibOVR.cmake +++ b/cmake/modules/FindLibOVR.cmake @@ -55,10 +55,10 @@ select_library_configurations(LIBOVR) set(LIBOVR_LIBRARIES "${LIBOVR_LIBRARIES}" "${UDEV_LIBRARY}" "${XINERAMA_LIBRARY}") include(FindPackageHandleStandardArgs) -if (UNIX) - find_package_handle_standard_args(LIBOVR DEFAULT_MSG LIBOVR_INCLUDE_DIRS LIBOVR_SRC_DIR LIBOVR_LIBRARIES) -elseif () +if (UNIX AND NOT APPLE) find_package_handle_standard_args(LIBOVR DEFAULT_MSG LIBOVR_INCLUDE_DIRS LIBOVR_SRC_DIR LIBOVR_LIBRARIES UDEV_LIBRARY XINERAMA_LIBRARY) +else () + find_package_handle_standard_args(LIBOVR DEFAULT_MSG LIBOVR_INCLUDE_DIRS LIBOVR_SRC_DIR LIBOVR_LIBRARIES) endif () mark_as_advanced(LIBOVR_INCLUDE_DIRS LIBOVR_LIBRARIES OCULUS_SEARCH_DIRS) From 2796f714198c07324b43d95696f63af114557cd3 Mon Sep 17 00:00:00 2001 From: Stephen Birarda Date: Wed, 30 Jul 2014 15:06:15 -0700 Subject: [PATCH 05/16] library cleanup to suppress warnings on cmake 3.0 --- CMakeLists.txt | 7 +++++-- animation-server/CMakeLists.txt | 2 -- assignment-client/CMakeLists.txt | 6 ------ cmake/macros/SetupHifiProject.cmake | 6 +++--- domain-server/CMakeLists.txt | 2 -- interface/CMakeLists.txt | 6 ------ libraries/animation/CMakeLists.txt | 6 ------ libraries/audio/CMakeLists.txt | 6 ------ libraries/avatars/CMakeLists.txt | 6 ------ libraries/embedded-webserver/CMakeLists.txt | 6 ------ libraries/fbx/CMakeLists.txt | 6 ------ libraries/metavoxels/CMakeLists.txt | 6 ------ libraries/models/CMakeLists.txt | 6 ------ libraries/networking/CMakeLists.txt | 6 ------ libraries/octree/CMakeLists.txt | 6 ------ libraries/particles/CMakeLists.txt | 6 ------ libraries/script-engine/CMakeLists.txt | 6 ------ libraries/shared/CMakeLists.txt | 6 ------ libraries/voxels/CMakeLists.txt | 7 ------- tests/CMakeLists.txt | 5 +---- tests/audio/CMakeLists.txt | 6 ------ tests/metavoxels/CMakeLists.txt | 6 ------ tests/networking/CMakeLists.txt | 6 ------ tests/octree/CMakeLists.txt | 6 ------ tests/physics/CMakeLists.txt | 6 ------ tests/shared/CMakeLists.txt | 6 ------ tools/CMakeLists.txt | 1 - tools/bitstream2json/CMakeLists.txt | 6 ------ tools/json2bitstream/CMakeLists.txt | 6 ------ tools/mtc/CMakeLists.txt | 10 +--------- voxel-edit/CMakeLists.txt | 6 ------ 31 files changed, 10 insertions(+), 168 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index b7c55740a0..91290c6a96 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -1,9 +1,12 @@ -cmake_minimum_required(VERSION 2.8) +cmake_minimum_required(VERSION 2.8.12.2) if (WIN32) - cmake_policy (SET CMP0020 NEW) + cmake_policy(SET CMP0020 NEW) endif (WIN32) +cmake_policy(SET CMP0028 OLD) +cmake_policy(SET CMP0043 OLD) + project(hifi) add_definitions(-DGLM_FORCE_RADIANS) diff --git a/animation-server/CMakeLists.txt b/animation-server/CMakeLists.txt index 31ed5d98df..116ee0e942 100644 --- a/animation-server/CMakeLists.txt +++ b/animation-server/CMakeLists.txt @@ -1,5 +1,3 @@ -cmake_minimum_required(VERSION 2.8) - if (WIN32) cmake_policy (SET CMP0020 NEW) endif (WIN32) diff --git a/assignment-client/CMakeLists.txt b/assignment-client/CMakeLists.txt index 873ae761ca..5ca021b175 100644 --- a/assignment-client/CMakeLists.txt +++ b/assignment-client/CMakeLists.txt @@ -1,9 +1,3 @@ -cmake_minimum_required(VERSION 2.8) - -if (WIN32) - cmake_policy (SET CMP0020 NEW) -endif (WIN32) - set(TARGET_NAME assignment-client) set(ROOT_DIR ..) diff --git a/cmake/macros/SetupHifiProject.cmake b/cmake/macros/SetupHifiProject.cmake index 50cd3a4150..15c70cc2a4 100644 --- a/cmake/macros/SetupHifiProject.cmake +++ b/cmake/macros/SetupHifiProject.cmake @@ -7,7 +7,7 @@ # See the accompanying file LICENSE or http://www.apache.org/licenses/LICENSE-2.0.html # -macro(SETUP_HIFI_PROJECT TARGET INCLUDE_QT) +macro(SETUP_HIFI_PROJECT TARGET INCLUDE_QT) project(${TARGET}) # grab the implemenation and header files @@ -25,10 +25,10 @@ macro(SETUP_HIFI_PROJECT TARGET INCLUDE_QT) # add the executable, include additional optional sources add_executable(${TARGET} ${TARGET_SRCS} ${ARGN}) - if (${INCLUDE_QT}) + if (INCLUDE_QT) find_package(Qt5Core REQUIRED) qt5_use_modules(${TARGET} Core) endif () - + target_link_libraries(${TARGET} ${QT_LIBRARIES}) endmacro() \ No newline at end of file diff --git a/domain-server/CMakeLists.txt b/domain-server/CMakeLists.txt index f9bbeb31fc..6ee794f7c6 100644 --- a/domain-server/CMakeLists.txt +++ b/domain-server/CMakeLists.txt @@ -1,5 +1,3 @@ -cmake_minimum_required(VERSION 2.8) - if (WIN32) cmake_policy (SET CMP0020 NEW) endif (WIN32) diff --git a/interface/CMakeLists.txt b/interface/CMakeLists.txt index c549440334..7336b55852 100644 --- a/interface/CMakeLists.txt +++ b/interface/CMakeLists.txt @@ -1,9 +1,3 @@ -cmake_minimum_required(VERSION 2.8) - -if (WIN32) - cmake_policy (SET CMP0020 NEW) -endif (WIN32) - set(ROOT_DIR ..) set(MACRO_DIR "${ROOT_DIR}/cmake/macros") diff --git a/libraries/animation/CMakeLists.txt b/libraries/animation/CMakeLists.txt index 1e33f50659..b1dc59fff8 100644 --- a/libraries/animation/CMakeLists.txt +++ b/libraries/animation/CMakeLists.txt @@ -1,9 +1,3 @@ -cmake_minimum_required(VERSION 2.8) - -if (WIN32) - cmake_policy (SET CMP0020 NEW) -endif (WIN32) - set(ROOT_DIR ../..) set(MACRO_DIR "${ROOT_DIR}/cmake/macros") diff --git a/libraries/audio/CMakeLists.txt b/libraries/audio/CMakeLists.txt index fafdfc7e6c..2ad8a4b0bc 100644 --- a/libraries/audio/CMakeLists.txt +++ b/libraries/audio/CMakeLists.txt @@ -1,9 +1,3 @@ -cmake_minimum_required(VERSION 2.8) - -if (WIN32) - cmake_policy (SET CMP0020 NEW) -endif (WIN32) - set(ROOT_DIR ../..) set(MACRO_DIR "${ROOT_DIR}/cmake/macros") diff --git a/libraries/avatars/CMakeLists.txt b/libraries/avatars/CMakeLists.txt index fc398fc33d..ca4a2630b4 100644 --- a/libraries/avatars/CMakeLists.txt +++ b/libraries/avatars/CMakeLists.txt @@ -1,9 +1,3 @@ -cmake_minimum_required(VERSION 2.8) - -if (WIN32) - cmake_policy (SET CMP0020 NEW) -endif (WIN32) - set(ROOT_DIR ../..) set(MACRO_DIR "${ROOT_DIR}/cmake/macros") diff --git a/libraries/embedded-webserver/CMakeLists.txt b/libraries/embedded-webserver/CMakeLists.txt index 3dc9074332..1386bcc392 100644 --- a/libraries/embedded-webserver/CMakeLists.txt +++ b/libraries/embedded-webserver/CMakeLists.txt @@ -1,9 +1,3 @@ -cmake_minimum_required(VERSION 2.8) - -if (WIN32) - cmake_policy (SET CMP0020 NEW) -endif (WIN32) - set(ROOT_DIR ../..) set(MACRO_DIR "${ROOT_DIR}/cmake/macros") diff --git a/libraries/fbx/CMakeLists.txt b/libraries/fbx/CMakeLists.txt index bc5ac3b3c4..45d1051dc6 100644 --- a/libraries/fbx/CMakeLists.txt +++ b/libraries/fbx/CMakeLists.txt @@ -1,9 +1,3 @@ -cmake_minimum_required(VERSION 2.8) - -if (WIN32) - cmake_policy (SET CMP0020 NEW) -endif (WIN32) - set(ROOT_DIR ../..) set(MACRO_DIR "${ROOT_DIR}/cmake/macros") diff --git a/libraries/metavoxels/CMakeLists.txt b/libraries/metavoxels/CMakeLists.txt index 79c07c6c47..c79631ce06 100644 --- a/libraries/metavoxels/CMakeLists.txt +++ b/libraries/metavoxels/CMakeLists.txt @@ -1,9 +1,3 @@ -cmake_minimum_required(VERSION 2.8) - -if (WIN32) - cmake_policy (SET CMP0020 NEW) -endif (WIN32) - set(ROOT_DIR ../..) set(MACRO_DIR "${ROOT_DIR}/cmake/macros") diff --git a/libraries/models/CMakeLists.txt b/libraries/models/CMakeLists.txt index 06578371cc..8056d215da 100644 --- a/libraries/models/CMakeLists.txt +++ b/libraries/models/CMakeLists.txt @@ -1,9 +1,3 @@ -cmake_minimum_required(VERSION 2.8) - -if (WIN32) - cmake_policy (SET CMP0020 NEW) -endif (WIN32) - set(ROOT_DIR ../..) set(MACRO_DIR "${ROOT_DIR}/cmake/macros") diff --git a/libraries/networking/CMakeLists.txt b/libraries/networking/CMakeLists.txt index fdd2d5830a..9a13374a4f 100644 --- a/libraries/networking/CMakeLists.txt +++ b/libraries/networking/CMakeLists.txt @@ -1,9 +1,3 @@ -cmake_minimum_required(VERSION 2.8) - -if (WIN32) - cmake_policy (SET CMP0020 NEW) -endif (WIN32) - set(ROOT_DIR ../..) set(MACRO_DIR "${ROOT_DIR}/cmake/macros") diff --git a/libraries/octree/CMakeLists.txt b/libraries/octree/CMakeLists.txt index 5988b4b058..031f7ef69a 100644 --- a/libraries/octree/CMakeLists.txt +++ b/libraries/octree/CMakeLists.txt @@ -1,9 +1,3 @@ -cmake_minimum_required(VERSION 2.8) - -if (WIN32) - cmake_policy (SET CMP0020 NEW) -endif (WIN32) - set(ROOT_DIR ../..) set(MACRO_DIR "${ROOT_DIR}/cmake/macros") diff --git a/libraries/particles/CMakeLists.txt b/libraries/particles/CMakeLists.txt index dbf2995293..76b3373466 100644 --- a/libraries/particles/CMakeLists.txt +++ b/libraries/particles/CMakeLists.txt @@ -1,9 +1,3 @@ -cmake_minimum_required(VERSION 2.8) - -if (WIN32) - cmake_policy (SET CMP0020 NEW) -endif (WIN32) - set(ROOT_DIR ../..) set(MACRO_DIR "${ROOT_DIR}/cmake/macros") diff --git a/libraries/script-engine/CMakeLists.txt b/libraries/script-engine/CMakeLists.txt index d0d05df286..2dd40c7ece 100644 --- a/libraries/script-engine/CMakeLists.txt +++ b/libraries/script-engine/CMakeLists.txt @@ -1,9 +1,3 @@ -cmake_minimum_required(VERSION 2.8) - -if (WIN32) - cmake_policy (SET CMP0020 NEW) -endif (WIN32) - set(ROOT_DIR ../..) set(MACRO_DIR "${ROOT_DIR}/cmake/macros") diff --git a/libraries/shared/CMakeLists.txt b/libraries/shared/CMakeLists.txt index 560546473c..f099f424e9 100644 --- a/libraries/shared/CMakeLists.txt +++ b/libraries/shared/CMakeLists.txt @@ -1,9 +1,3 @@ -cmake_minimum_required(VERSION 2.8) - -if (WIN32) - cmake_policy (SET CMP0020 NEW) -endif (WIN32) - set(ROOT_DIR ../..) set(MACRO_DIR "${ROOT_DIR}/cmake/macros") diff --git a/libraries/voxels/CMakeLists.txt b/libraries/voxels/CMakeLists.txt index 51b83bb650..2ae35da2c0 100644 --- a/libraries/voxels/CMakeLists.txt +++ b/libraries/voxels/CMakeLists.txt @@ -1,10 +1,3 @@ -cmake_minimum_required(VERSION 2.8) - -if (WIN32) - cmake_policy (SET CMP0020 NEW) -endif (WIN32) - - set(ROOT_DIR ../..) set(MACRO_DIR "${ROOT_DIR}/cmake/macros") diff --git a/tests/CMakeLists.txt b/tests/CMakeLists.txt index 2f56d337fa..dd2e6e396e 100644 --- a/tests/CMakeLists.txt +++ b/tests/CMakeLists.txt @@ -1,10 +1,7 @@ -cmake_minimum_required(VERSION 2.8) - # add the test directories file(GLOB TEST_SUBDIRS RELATIVE "${CMAKE_CURRENT_SOURCE_DIR}" "${CMAKE_CURRENT_SOURCE_DIR}/*") foreach(DIR ${TEST_SUBDIRS}) if(IS_DIRECTORY "${CMAKE_CURRENT_SOURCE_DIR}/${DIR}") add_subdirectory(${DIR}) endif() -endforeach() - +endforeach() \ No newline at end of file diff --git a/tests/audio/CMakeLists.txt b/tests/audio/CMakeLists.txt index 5c5178cb71..b7375a0086 100644 --- a/tests/audio/CMakeLists.txt +++ b/tests/audio/CMakeLists.txt @@ -1,9 +1,3 @@ -cmake_minimum_required(VERSION 2.8) - -if (WIN32) - cmake_policy (SET CMP0020 NEW) -endif (WIN32) - set(TARGET_NAME audio-tests) set(ROOT_DIR ../..) diff --git a/tests/metavoxels/CMakeLists.txt b/tests/metavoxels/CMakeLists.txt index ca141c5137..f4c0695362 100644 --- a/tests/metavoxels/CMakeLists.txt +++ b/tests/metavoxels/CMakeLists.txt @@ -1,9 +1,3 @@ -cmake_minimum_required(VERSION 2.8) - -if (WIN32) - cmake_policy (SET CMP0020 NEW) -endif (WIN32) - set(TARGET_NAME metavoxel-tests) set(ROOT_DIR ../..) diff --git a/tests/networking/CMakeLists.txt b/tests/networking/CMakeLists.txt index 2e094d2ce7..64b5f273d1 100644 --- a/tests/networking/CMakeLists.txt +++ b/tests/networking/CMakeLists.txt @@ -1,9 +1,3 @@ -cmake_minimum_required(VERSION 2.8) - -if (WIN32) - cmake_policy (SET CMP0020 NEW) -endif (WIN32) - set(TARGET_NAME networking-tests) set(ROOT_DIR ../..) diff --git a/tests/octree/CMakeLists.txt b/tests/octree/CMakeLists.txt index 9c5e031d74..c7a6500b6d 100644 --- a/tests/octree/CMakeLists.txt +++ b/tests/octree/CMakeLists.txt @@ -1,9 +1,3 @@ -cmake_minimum_required(VERSION 2.8) - -if (WIN32) - cmake_policy (SET CMP0020 NEW) -endif (WIN32) - set(TARGET_NAME octree-tests) set(ROOT_DIR ../..) diff --git a/tests/physics/CMakeLists.txt b/tests/physics/CMakeLists.txt index 9b336523f1..643d318f7d 100644 --- a/tests/physics/CMakeLists.txt +++ b/tests/physics/CMakeLists.txt @@ -1,9 +1,3 @@ -cmake_minimum_required(VERSION 2.8) - -if (WIN32) - cmake_policy (SET CMP0020 NEW) -endif (WIN32) - set(TARGET_NAME physics-tests) set(ROOT_DIR ../..) diff --git a/tests/shared/CMakeLists.txt b/tests/shared/CMakeLists.txt index b9513e3f26..0785314d36 100644 --- a/tests/shared/CMakeLists.txt +++ b/tests/shared/CMakeLists.txt @@ -1,9 +1,3 @@ -cmake_minimum_required(VERSION 2.8) - -if (WIN32) - cmake_policy (SET CMP0020 NEW) -endif (WIN32) - set(TARGET_NAME shared-tests) set(ROOT_DIR ../..) diff --git a/tools/CMakeLists.txt b/tools/CMakeLists.txt index 79db82e90f..c9c0690cc7 100644 --- a/tools/CMakeLists.txt +++ b/tools/CMakeLists.txt @@ -1,4 +1,3 @@ -cmake_minimum_required(VERSION 2.8) # add the tool directories add_subdirectory(bitstream2json) diff --git a/tools/bitstream2json/CMakeLists.txt b/tools/bitstream2json/CMakeLists.txt index d5b82adbd9..576406e787 100644 --- a/tools/bitstream2json/CMakeLists.txt +++ b/tools/bitstream2json/CMakeLists.txt @@ -1,9 +1,3 @@ -cmake_minimum_required(VERSION 2.8) - -if (WIN32) - cmake_policy (SET CMP0020 NEW) -endif (WIN32) - set(TARGET_NAME bitstream2json) set(ROOT_DIR ../..) diff --git a/tools/json2bitstream/CMakeLists.txt b/tools/json2bitstream/CMakeLists.txt index b93c57b582..5ff4673298 100644 --- a/tools/json2bitstream/CMakeLists.txt +++ b/tools/json2bitstream/CMakeLists.txt @@ -1,9 +1,3 @@ -cmake_minimum_required(VERSION 2.8) - -if (WIN32) - cmake_policy (SET CMP0020 NEW) -endif (WIN32) - set(TARGET_NAME json2bitstream) set(ROOT_DIR ../..) diff --git a/tools/mtc/CMakeLists.txt b/tools/mtc/CMakeLists.txt index a7ab97c7f2..582c5e3bfd 100644 --- a/tools/mtc/CMakeLists.txt +++ b/tools/mtc/CMakeLists.txt @@ -1,15 +1,7 @@ -cmake_minimum_required(VERSION 2.8) - -if (WIN32) - cmake_policy (SET CMP0020 NEW) -endif (WIN32) - set(TARGET_NAME mtc) set(ROOT_DIR ../..) set(MACRO_DIR "${ROOT_DIR}/cmake/macros") include(${MACRO_DIR}/SetupHifiProject.cmake) -setup_hifi_project(${TARGET_NAME} TRUE) - - +setup_hifi_project(${TARGET_NAME} TRUE) \ No newline at end of file diff --git a/voxel-edit/CMakeLists.txt b/voxel-edit/CMakeLists.txt index 6ebf23efba..006dfb0599 100644 --- a/voxel-edit/CMakeLists.txt +++ b/voxel-edit/CMakeLists.txt @@ -1,9 +1,3 @@ -cmake_minimum_required(VERSION 2.8) - -if (WIN32) - cmake_policy (SET CMP0020 NEW) -endif (WIN32) - set(TARGET_NAME voxel-edit) set(ROOT_DIR ..) From 4f17902c6b69ca0a3b5df33342b2ca5c1811b1a9 Mon Sep 17 00:00:00 2001 From: Stephen Birarda Date: Wed, 30 Jul 2014 15:08:31 -0700 Subject: [PATCH 06/16] fix set of LIBOVR_LIBRARIES in FindLibOVR module --- cmake/modules/FindLibOVR.cmake | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmake/modules/FindLibOVR.cmake b/cmake/modules/FindLibOVR.cmake index 805f673682..d6bb34cf8d 100644 --- a/cmake/modules/FindLibOVR.cmake +++ b/cmake/modules/FindLibOVR.cmake @@ -52,7 +52,7 @@ endif () select_library_configurations(LIBOVR) -set(LIBOVR_LIBRARIES "${LIBOVR_LIBRARIES}" "${UDEV_LIBRARY}" "${XINERAMA_LIBRARY}") +set(LIBOVR_LIBRARIES "${LIBOVR_LIBRARY}" "${UDEV_LIBRARY}" "${XINERAMA_LIBRARY}") include(FindPackageHandleStandardArgs) if (UNIX AND NOT APPLE) From 21229f22a70a0f39e901d6b53a3e12f61842de15 Mon Sep 17 00:00:00 2001 From: Stephen Birarda Date: Wed, 30 Jul 2014 15:12:07 -0700 Subject: [PATCH 07/16] only set the policy if it exists --- CMakeLists.txt | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 91290c6a96..de23f52271 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -4,8 +4,16 @@ if (WIN32) cmake_policy(SET CMP0020 NEW) endif (WIN32) -cmake_policy(SET CMP0028 OLD) -cmake_policy(SET CMP0043 OLD) +if (POLICY CMP0028) + cmake_policy(SET CMP0028 OLD) +endif () + +if (POLICY CMP0043) + cmake_policy(SET CMP0043 OLD) +endif () + + + project(hifi) add_definitions(-DGLM_FORCE_RADIANS) @@ -42,7 +50,7 @@ set(CMAKE_AUTOMOC ON) # targets not supported on windows if (NOT WIN32) add_subdirectory(animation-server) -endif (NOT WIN32) +endif () # targets on all platforms add_subdirectory(assignment-client) From 54390600a32b89aec66fa9d0d7b20a8415b8ef96 Mon Sep 17 00:00:00 2001 From: Stephen Birarda Date: Wed, 30 Jul 2014 15:13:01 -0700 Subject: [PATCH 08/16] remove some extra spaces --- CMakeLists.txt | 3 --- 1 file changed, 3 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index de23f52271..2dbc89b75f 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -12,9 +12,6 @@ if (POLICY CMP0043) cmake_policy(SET CMP0043 OLD) endif () - - - project(hifi) add_definitions(-DGLM_FORCE_RADIANS) From 4c59c0ebfe47ff6ac565606cfc3fb399e0999aee Mon Sep 17 00:00:00 2001 From: Stephen Birarda Date: Wed, 30 Jul 2014 15:19:43 -0700 Subject: [PATCH 09/16] fix reference to INCLUDE_QT variable in SetupHifiProject macro --- cmake/macros/SetupHifiProject.cmake | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmake/macros/SetupHifiProject.cmake b/cmake/macros/SetupHifiProject.cmake index 15c70cc2a4..ec731859d4 100644 --- a/cmake/macros/SetupHifiProject.cmake +++ b/cmake/macros/SetupHifiProject.cmake @@ -25,7 +25,7 @@ macro(SETUP_HIFI_PROJECT TARGET INCLUDE_QT) # add the executable, include additional optional sources add_executable(${TARGET} ${TARGET_SRCS} ${ARGN}) - if (INCLUDE_QT) + if (${INCLUDE_QT}) find_package(Qt5Core REQUIRED) qt5_use_modules(${TARGET} Core) endif () From f25e8b0b7597ad0ce1278713e82d62dd749a2d6b Mon Sep 17 00:00:00 2001 From: Stephen Birarda Date: Wed, 30 Jul 2014 15:28:45 -0700 Subject: [PATCH 10/16] add NAMES to find_library commands --- cmake/modules/FindLibOVR.cmake | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/cmake/modules/FindLibOVR.cmake b/cmake/modules/FindLibOVR.cmake index d6bb34cf8d..16be7470b6 100644 --- a/cmake/modules/FindLibOVR.cmake +++ b/cmake/modules/FindLibOVR.cmake @@ -27,8 +27,8 @@ find_path(LIBOVR_SRC_DIR Util_Render_Stereo.h PATH_SUFFIXES Src/Util HINTS ${OCU include(SelectLibraryConfigurations) if (APPLE) - find_library(LIBOVR_LIBRARY_DEBUG ovr PATH_SUFFIXES Lib/MacOS/Debug HINTS ${OCULUS_SEARCH_DIRS}) - find_library(LIBOVR_LIBRARY_RELEASE ovr PATH_SUFFIXES Lib/MacOS/Release HINTS ${OCULUS_SEARCH_DIRS}) + find_library(LIBOVR_LIBRARY_DEBUG NAMES ovr PATH_SUFFIXES Lib/MacOS/Debug HINTS ${OCULUS_SEARCH_DIRS}) + find_library(LIBOVR_LIBRARY_RELEASE NAMES ovr PATH_SUFFIXES Lib/MacOS/Release HINTS ${OCULUS_SEARCH_DIRS}) elseif (UNIX) find_library(UDEV_LIBRARY_RELEASE udev /usr/lib/x86_64-linux-gnu/) find_library(XINERAMA_LIBRARY_RELEASE Xinerama /usr/lib/x86_64-linux-gnu/) @@ -39,15 +39,15 @@ elseif (UNIX) set(LINUX_ARCH_DIR "x86_64") endif() - find_library(LIBOVR_LIBRARY_DEBUG ovr PATH_SUFFIXES Lib/Linux/Debug/${LINUX_ARCH_DIR} HINTS ${OCULUS_SEARCH_DIRS}) - find_library(LIBOVR_LIBRARY_RELEASE ovr PATH_SUFFIXES Lib/Linux/Release/${LINUX_ARCH_DIR}/ HINTS ${OCULUS_SEARCH_DIRS}) + find_library(LIBOVR_LIBRARY_DEBUG NAMES ovr PATH_SUFFIXES Lib/Linux/Debug/${LINUX_ARCH_DIR} HINTS ${OCULUS_SEARCH_DIRS}) + find_library(LIBOVR_LIBRARY_RELEASE NAMES ovr PATH_SUFFIXES Lib/Linux/Release/${LINUX_ARCH_DIR}/ HINTS ${OCULUS_SEARCH_DIRS}) select_library_configurations(UDEV) select_library_configurations(XINERAMA) elseif (WIN32) - find_library(LIBOVR_LIBRARY_DEBUG ovrd PATH_SUFFIXES Lib/Win32 Lib/Win32/VS2010 HINTS ${OCULUS_SEARCH_DIRS}) - find_library(LIBOVR_LIBRARY_RELEASE ovr PATH_SUFFIXES Lib/Win32 Lib/Win32/VS2010 HINTS ${OCULUS_SEARCH_DIRS}) + find_library(LIBOVR_LIBRARY_DEBUG NAMES ovrd PATH_SUFFIXES Lib/Win32 Lib/Win32/VS2010 HINTS ${OCULUS_SEARCH_DIRS}) + find_library(LIBOVR_LIBRARY_RELEASE NAMES ovr PATH_SUFFIXES Lib/Win32 Lib/Win32/VS2010 HINTS ${OCULUS_SEARCH_DIRS}) endif () select_library_configurations(LIBOVR) From e702738694ba8fdb701f94b79c866ad0d317ceb3 Mon Sep 17 00:00:00 2001 From: Stephen Birarda Date: Wed, 30 Jul 2014 15:31:05 -0700 Subject: [PATCH 11/16] only add udev and xinerama on UNIX --- cmake/modules/FindLibOVR.cmake | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/cmake/modules/FindLibOVR.cmake b/cmake/modules/FindLibOVR.cmake index 16be7470b6..b2c0655991 100644 --- a/cmake/modules/FindLibOVR.cmake +++ b/cmake/modules/FindLibOVR.cmake @@ -51,8 +51,11 @@ elseif (WIN32) endif () select_library_configurations(LIBOVR) +set(LIBOVR_LIBRARIES "${LIBOVR_LIBRARY}") -set(LIBOVR_LIBRARIES "${LIBOVR_LIBRARY}" "${UDEV_LIBRARY}" "${XINERAMA_LIBRARY}") +if (UNIX) + set(LIBOVR_LIBRARIES "${LIBOVR_LIBRARIES}" "${UDEV_LIBRARY}" "${XINERAMA_LIBRARY}" +endif () include(FindPackageHandleStandardArgs) if (UNIX AND NOT APPLE) From 4e27738cb16806d2e3c0951a4d0c3efc958e90ee Mon Sep 17 00:00:00 2001 From: Stephen Birarda Date: Wed, 30 Jul 2014 15:31:47 -0700 Subject: [PATCH 12/16] don't apply udev and xinerama libraries to APPLE --- cmake/modules/FindLibOVR.cmake | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmake/modules/FindLibOVR.cmake b/cmake/modules/FindLibOVR.cmake index b2c0655991..f6af36a18e 100644 --- a/cmake/modules/FindLibOVR.cmake +++ b/cmake/modules/FindLibOVR.cmake @@ -53,7 +53,7 @@ endif () select_library_configurations(LIBOVR) set(LIBOVR_LIBRARIES "${LIBOVR_LIBRARY}") -if (UNIX) +if (UNIX AND NOT APPLE) set(LIBOVR_LIBRARIES "${LIBOVR_LIBRARIES}" "${UDEV_LIBRARY}" "${XINERAMA_LIBRARY}" endif () From d101d321da6e44b4ba8420980a6d675e33d7b54d Mon Sep 17 00:00:00 2001 From: Stephen Birarda Date: Wed, 30 Jul 2014 15:32:45 -0700 Subject: [PATCH 13/16] add a missing closing bracket --- cmake/modules/FindLibOVR.cmake | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmake/modules/FindLibOVR.cmake b/cmake/modules/FindLibOVR.cmake index f6af36a18e..a77858664d 100644 --- a/cmake/modules/FindLibOVR.cmake +++ b/cmake/modules/FindLibOVR.cmake @@ -54,7 +54,7 @@ select_library_configurations(LIBOVR) set(LIBOVR_LIBRARIES "${LIBOVR_LIBRARY}") if (UNIX AND NOT APPLE) - set(LIBOVR_LIBRARIES "${LIBOVR_LIBRARIES}" "${UDEV_LIBRARY}" "${XINERAMA_LIBRARY}" + set(LIBOVR_LIBRARIES "${LIBOVR_LIBRARIES}" "${UDEV_LIBRARY}" "${XINERAMA_LIBRARY}") endif () include(FindPackageHandleStandardArgs) From 4f6a86fc6c3492a3474b41ec2cb596ea3b92a74a Mon Sep 17 00:00:00 2001 From: Stephen Birarda Date: Wed, 30 Jul 2014 16:15:28 -0700 Subject: [PATCH 14/16] tweak to help windows find oculus libraries --- cmake/modules/FindLibOVR.cmake | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/cmake/modules/FindLibOVR.cmake b/cmake/modules/FindLibOVR.cmake index a77858664d..e90afe29e4 100644 --- a/cmake/modules/FindLibOVR.cmake +++ b/cmake/modules/FindLibOVR.cmake @@ -40,14 +40,14 @@ elseif (UNIX) endif() find_library(LIBOVR_LIBRARY_DEBUG NAMES ovr PATH_SUFFIXES Lib/Linux/Debug/${LINUX_ARCH_DIR} HINTS ${OCULUS_SEARCH_DIRS}) - find_library(LIBOVR_LIBRARY_RELEASE NAMES ovr PATH_SUFFIXES Lib/Linux/Release/${LINUX_ARCH_DIR}/ HINTS ${OCULUS_SEARCH_DIRS}) + find_library(LIBOVR_LIBRARY_RELEASE NAMES ovr PATH_SUFFIXES Lib/Linux/Release/${LINUX_ARCH_DIR} HINTS ${OCULUS_SEARCH_DIRS}) select_library_configurations(UDEV) select_library_configurations(XINERAMA) elseif (WIN32) - find_library(LIBOVR_LIBRARY_DEBUG NAMES ovrd PATH_SUFFIXES Lib/Win32 Lib/Win32/VS2010 HINTS ${OCULUS_SEARCH_DIRS}) - find_library(LIBOVR_LIBRARY_RELEASE NAMES ovr PATH_SUFFIXES Lib/Win32 Lib/Win32/VS2010 HINTS ${OCULUS_SEARCH_DIRS}) + find_library(LIBOVR_LIBRARY_DEBUG NAMES libovrd PATH_SUFFIXES Lib/Win32/VS2010 HINTS ${OCULUS_SEARCH_DIRS}) + find_library(LIBOVR_LIBRARY_RELEASE NAMES libovr PATH_SUFFIXES Lib/Win32/VS2010 HINTS ${OCULUS_SEARCH_DIRS}) endif () select_library_configurations(LIBOVR) From ff1ae434742678b3ad2237978175a2fb252d93c4 Mon Sep 17 00:00:00 2001 From: Stephen Birarda Date: Wed, 30 Jul 2014 16:16:50 -0700 Subject: [PATCH 15/16] remove useless lib prefix in oculus find module --- cmake/modules/FindLibOVR.cmake | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cmake/modules/FindLibOVR.cmake b/cmake/modules/FindLibOVR.cmake index e90afe29e4..de1384c586 100644 --- a/cmake/modules/FindLibOVR.cmake +++ b/cmake/modules/FindLibOVR.cmake @@ -46,8 +46,8 @@ elseif (UNIX) select_library_configurations(XINERAMA) elseif (WIN32) - find_library(LIBOVR_LIBRARY_DEBUG NAMES libovrd PATH_SUFFIXES Lib/Win32/VS2010 HINTS ${OCULUS_SEARCH_DIRS}) - find_library(LIBOVR_LIBRARY_RELEASE NAMES libovr PATH_SUFFIXES Lib/Win32/VS2010 HINTS ${OCULUS_SEARCH_DIRS}) + find_library(LIBOVR_LIBRARY_DEBUG NAMES ovrd PATH_SUFFIXES Lib/Win32/VS2010 HINTS ${OCULUS_SEARCH_DIRS}) + find_library(LIBOVR_LIBRARY_RELEASE NAMES ovr PATH_SUFFIXES Lib/Win32/VS2010 HINTS ${OCULUS_SEARCH_DIRS}) endif () select_library_configurations(LIBOVR) From 5b371cedb97e04745366cc8e9b2bb155e78b4ae0 Mon Sep 17 00:00:00 2001 From: Stephen Birarda Date: Wed, 30 Jul 2014 16:18:04 -0700 Subject: [PATCH 16/16] Revert "remove useless lib prefix in oculus find module" This reverts commit ff1ae434742678b3ad2237978175a2fb252d93c4. --- cmake/modules/FindLibOVR.cmake | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cmake/modules/FindLibOVR.cmake b/cmake/modules/FindLibOVR.cmake index de1384c586..e90afe29e4 100644 --- a/cmake/modules/FindLibOVR.cmake +++ b/cmake/modules/FindLibOVR.cmake @@ -46,8 +46,8 @@ elseif (UNIX) select_library_configurations(XINERAMA) elseif (WIN32) - find_library(LIBOVR_LIBRARY_DEBUG NAMES ovrd PATH_SUFFIXES Lib/Win32/VS2010 HINTS ${OCULUS_SEARCH_DIRS}) - find_library(LIBOVR_LIBRARY_RELEASE NAMES ovr PATH_SUFFIXES Lib/Win32/VS2010 HINTS ${OCULUS_SEARCH_DIRS}) + find_library(LIBOVR_LIBRARY_DEBUG NAMES libovrd PATH_SUFFIXES Lib/Win32/VS2010 HINTS ${OCULUS_SEARCH_DIRS}) + find_library(LIBOVR_LIBRARY_RELEASE NAMES libovr PATH_SUFFIXES Lib/Win32/VS2010 HINTS ${OCULUS_SEARCH_DIRS}) endif () select_library_configurations(LIBOVR)