Mirrors/overte
3
0
Fork 0
mirror of https://github.com/overte-org/overte.git synced 2025-08-09 23:40:11 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Add placeholder image when previous snapshot can't be loaded

Browse source
This commit is contained in:
Zach Fox 2017-05-31 10:11:59 -07:00
parent 4a52f4090d
commit 0441d8c703
3 changed files with 23 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

BIN
interface/resources/snapshot/img/no-image.jpg Normal file
View file

Binary file not shown.
Side by side

After

Width:  |  Height:  |  Size: 20 KiB

32
scripts/system/html/js/SnapshotReview.js
View file

@ -293,19 +293,25 @@ function addImage(image_data, isLoggedIn, canShare, isGifLoading, isShowingPrevi
isGif = img.src.split('.').pop().toLowerCase() === "gif"; isGif = img.src.split('.').pop().toLowerCase() === "gif";
imageContainer.appendChild(img); imageContainer.appendChild(img);
document.getElementById("snapshot-images").appendChild(imageContainer); document.getElementById("snapshot-images").appendChild(imageContainer);
paths.push(image_data.localPath); img.onload = function () {
if (isGif) { paths.push(image_data.localPath);
imageContainer.innerHTML += '<span class="gifLabel">GIF</span>'; if (isGif) {
} imageContainer.innerHTML += '<span class="gifLabel">GIF</span>';
if (!isGifLoading) { }
appendShareBar(id, isLoggedIn, canShare, isGif, blastButtonDisabled, hifiButtonDisabled, canBlast); if (!isGifLoading) {
} appendShareBar(id, isLoggedIn, canShare, isGif, blastButtonDisabled, hifiButtonDisabled, canBlast);
if (!isGifLoading || (isShowingPreviousImages && !image_data.story_id)) { }
shareForUrl(id); if (!isGifLoading || (isShowingPreviousImages && !image_data.story_id)) {
} shareForUrl(id);
if (isShowingPreviousImages && isLoggedIn && image_data.story_id) { }
updateShareInfo(id, image_data.story_id); if (isShowingPreviousImages && isLoggedIn && image_data.story_id) {
} updateShareInfo(id, image_data.story_id);
}
};
img.onerror = function () {
img.onload = null;
img.src = image_data.errorPath;
};
} }
function showConfirmationMessage(selectedID, destination) { function showConfirmationMessage(selectedID, destination) {
if (selectedID.id) { if (selectedID.id) {

6
scripts/system/snapshot.js
View file

@ -273,7 +273,8 @@ function fillImageDataFromPrevious() {
localPath: previousStillSnapPath, localPath: previousStillSnapPath,
story_id: previousStillSnapStoryID, story_id: previousStillSnapStoryID,
blastButtonDisabled: previousStillSnapBlastingDisabled, blastButtonDisabled: previousStillSnapBlastingDisabled,
hifiButtonDisabled: previousStillSnapHifiSharingDisabled hifiButtonDisabled: previousStillSnapHifiSharingDisabled,
errorPath: Script.resolvePath(Script.resourcesPath() + 'snapshot/img/no-image.jpg')
}); });
} }
if (previousAnimatedSnapPath !== "") { if (previousAnimatedSnapPath !== "") {
@ -281,7 +282,8 @@ function fillImageDataFromPrevious() {
localPath: previousAnimatedSnapPath, localPath: previousAnimatedSnapPath,
story_id: previousAnimatedSnapStoryID, story_id: previousAnimatedSnapStoryID,
blastButtonDisabled: previousAnimatedSnapBlastingDisabled, blastButtonDisabled: previousAnimatedSnapBlastingDisabled,
hifiButtonDisabled: previousAnimatedSnapHifiSharingDisabled hifiButtonDisabled: previousAnimatedSnapHifiSharingDisabled,
errorPath: Script.resolvePath(Script.resourcesPath() + 'snapshot/img/no-image.jpg')
}); });
} }
} }