From f82de05f9cc4622464ed0410f8eaa39905cd6cf2 Mon Sep 17 00:00:00 2001 From: Andrew Meadows Date: Wed, 6 Dec 2017 10:41:28 -0800 Subject: [PATCH 1/3] defang accidental disable of MyAvatar's default motor --- interface/src/Application.cpp | 3 +-- interface/src/Menu.cpp | 8 ++++---- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/interface/src/Application.cpp b/interface/src/Application.cpp index 81ed5a0578..21adf23b67 100644 --- a/interface/src/Application.cpp +++ b/interface/src/Application.cpp @@ -1443,7 +1443,6 @@ Application::Application(int& argc, char** argv, QElapsedTimer& startupTimer, bo connect(audioIO.data(), &AudioClient::noiseGateClosed, audioScriptingInterface.data(), &AudioScriptingInterface::noiseGateClosed); connect(audioIO.data(), &AudioClient::inputReceived, audioScriptingInterface.data(), &AudioScriptingInterface::inputReceived); - this->installEventFilter(this); #ifdef HAVE_DDE @@ -1468,7 +1467,7 @@ Application::Application(int& argc, char** argv, QElapsedTimer& startupTimer, bo } // Now that menu is initialized we can sync myAvatar with it's state. - myAvatar->updateMotionBehaviorFromMenu(); + Menu::getInstance()->setIsOptionChecked(MenuOption::ActionMotorControl, true); // FIXME spacemouse code still needs cleanup #if 0 diff --git a/interface/src/Menu.cpp b/interface/src/Menu.cpp index eeda9e9036..15fad425a9 100644 --- a/interface/src/Menu.cpp +++ b/interface/src/Menu.cpp @@ -589,12 +589,12 @@ Menu::Menu() { addCheckableActionToQMenuAndActionHash(avatarDebugMenu, MenuOption::RenderDetailedCollision, 0, false, avatar.get(), SLOT(setEnableDebugDrawDetailedCollision(bool))); - addCheckableActionToQMenuAndActionHash(avatarDebugMenu, MenuOption::ActionMotorControl, - Qt::CTRL | Qt::SHIFT | Qt::Key_K, true, avatar.get(), SLOT(updateMotionBehaviorFromMenu()), + addCheckableActionToQMenuAndActionHash(avatarDebugMenu, MenuOption::ActionMotorControl, 0, true, + avatar.get(), SLOT(updateMotionBehaviorFromMenu()), UNSPECIFIED_POSITION, "Developer"); - addCheckableActionToQMenuAndActionHash(avatarDebugMenu, MenuOption::ScriptedMotorControl, 0, true, - avatar.get(), SLOT(updateMotionBehaviorFromMenu()), + addCheckableActionToQMenuAndActionHash(avatarDebugMenu, MenuOption::ScriptedMotorControl, + Qt::CTRL | Qt::SHIFT | Qt::Key_K, true, avatar.get(), SLOT(updateMotionBehaviorFromMenu()), UNSPECIFIED_POSITION, "Developer"); // Developer > Hands >>> From 6ad3a0598cabdd94d11f30b4431312c1de7c8b21 Mon Sep 17 00:00:00 2001 From: Andrew Meadows Date: Sat, 9 Dec 2017 21:42:03 -0800 Subject: [PATCH 2/3] remove crufty comment --- interface/src/Application.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/interface/src/Application.cpp b/interface/src/Application.cpp index 21adf23b67..5d1b0136f2 100644 --- a/interface/src/Application.cpp +++ b/interface/src/Application.cpp @@ -1466,7 +1466,6 @@ Application::Application(int& argc, char** argv, QElapsedTimer& startupTimer, bo applicationUpdater->checkForUpdate(); } - // Now that menu is initialized we can sync myAvatar with it's state. Menu::getInstance()->setIsOptionChecked(MenuOption::ActionMotorControl, true); // FIXME spacemouse code still needs cleanup From 02e3b2262148a7ab721eb92095f2a56dbc40407f Mon Sep 17 00:00:00 2001 From: Andrew Meadows Date: Wed, 20 Dec 2017 08:43:56 -0800 Subject: [PATCH 3/3] remove hot-key for disable of scripted motor --- interface/src/Menu.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/interface/src/Menu.cpp b/interface/src/Menu.cpp index 15fad425a9..3f168f28ea 100644 --- a/interface/src/Menu.cpp +++ b/interface/src/Menu.cpp @@ -593,8 +593,8 @@ Menu::Menu() { avatar.get(), SLOT(updateMotionBehaviorFromMenu()), UNSPECIFIED_POSITION, "Developer"); - addCheckableActionToQMenuAndActionHash(avatarDebugMenu, MenuOption::ScriptedMotorControl, - Qt::CTRL | Qt::SHIFT | Qt::Key_K, true, avatar.get(), SLOT(updateMotionBehaviorFromMenu()), + addCheckableActionToQMenuAndActionHash(avatarDebugMenu, MenuOption::ScriptedMotorControl, 0, true, + avatar.get(), SLOT(updateMotionBehaviorFromMenu()), UNSPECIFIED_POSITION, "Developer"); // Developer > Hands >>>