From ef326a38518969dff000d550717b40027394cfc1 Mon Sep 17 00:00:00 2001 From: Andrew Meadows Date: Tue, 3 Oct 2017 11:59:25 -0700 Subject: [PATCH 1/2] expose performance hot spot in stats details --- .../src/EntityTreeRenderer.cpp | 26 ++++++++++++++----- 1 file changed, 19 insertions(+), 7 deletions(-) diff --git a/libraries/entities-renderer/src/EntityTreeRenderer.cpp b/libraries/entities-renderer/src/EntityTreeRenderer.cpp index 0cb25a2e2f..e42a307d96 100644 --- a/libraries/entities-renderer/src/EntityTreeRenderer.cpp +++ b/libraries/entities-renderer/src/EntityTreeRenderer.cpp @@ -260,12 +260,24 @@ void EntityTreeRenderer::update(bool simulate) { } } - auto scene = _viewState->getMain3DScene(); - if (scene) { - render::Transaction transaction; - addPendingEntities(scene, transaction); - updateChangedEntities(scene, transaction); - scene->enqueueTransaction(transaction); + { + PerformanceTimer sceneTimer("scene"); + auto scene = _viewState->getMain3DScene(); + if (scene) { + render::Transaction transaction; + { + PerformanceTimer foo("add"); + addPendingEntities(scene, transaction); + } + { + PerformanceTimer foo("change"); + updateChangedEntities(scene, transaction); + } + { + PerformanceTimer foo("enqueue"); + scene->enqueueTransaction(transaction); + } + } } } } @@ -1078,4 +1090,4 @@ void EntityTreeRenderer::onEntityChanged(const EntityItemID& id) { _changedEntitiesGuard.withWriteLock([&] { _changedEntities.insert(id); }); -} \ No newline at end of file +} From 46e809bbb25e64e912daf64ecd89b478c2645fec Mon Sep 17 00:00:00 2001 From: Andrew Meadows Date: Tue, 3 Oct 2017 12:19:19 -0700 Subject: [PATCH 2/2] use a better variable name --- libraries/entities-renderer/src/EntityTreeRenderer.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libraries/entities-renderer/src/EntityTreeRenderer.cpp b/libraries/entities-renderer/src/EntityTreeRenderer.cpp index e42a307d96..67fcc5cc69 100644 --- a/libraries/entities-renderer/src/EntityTreeRenderer.cpp +++ b/libraries/entities-renderer/src/EntityTreeRenderer.cpp @@ -266,15 +266,15 @@ void EntityTreeRenderer::update(bool simulate) { if (scene) { render::Transaction transaction; { - PerformanceTimer foo("add"); + PerformanceTimer pt("add"); addPendingEntities(scene, transaction); } { - PerformanceTimer foo("change"); + PerformanceTimer pt("change"); updateChangedEntities(scene, transaction); } { - PerformanceTimer foo("enqueue"); + PerformanceTimer pt("enqueue"); scene->enqueueTransaction(transaction); } }