From 00799e39e1ee27748f65fac9deb0b265386517e2 Mon Sep 17 00:00:00 2001 From: ZappoMan Date: Fri, 3 Oct 2014 09:48:54 -0700 Subject: [PATCH] CR feedback --- interface/src/ui/overlays/Base3DOverlay.cpp | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/interface/src/ui/overlays/Base3DOverlay.cpp b/interface/src/ui/overlays/Base3DOverlay.cpp index f58dc8e29e..efa2a2bdcd 100644 --- a/interface/src/ui/overlays/Base3DOverlay.cpp +++ b/interface/src/ui/overlays/Base3DOverlay.cpp @@ -129,16 +129,16 @@ void Base3DOverlay::drawDashedLine(const glm::vec3& start, const glm::vec3& end) glBegin(GL_LINES); // draw each line segment with appropriate gaps - const float dashLength = 0.05f; - const float gapLength = 0.025f; - const float segmentLength = dashLength + gapLength; + const float DASH_LENGTH = 0.05f; + const float GAP_LENGTH = 0.025f; + const float SEGMENT_LENGTH = DASH_LENGTH + GAP_LENGTH; float length = glm::distance(start, end); - float segmentCount = length / segmentLength; + float segmentCount = length / SEGMENT_LENGTH; int segmentCountFloor = (int)glm::floor(segmentCount); glm::vec3 segmentVector = (end - start) / segmentCount; - glm::vec3 dashVector = segmentVector / segmentLength * dashLength; - glm::vec3 gapVector = segmentVector / segmentLength * gapLength; + glm::vec3 dashVector = segmentVector / SEGMENT_LENGTH * DASH_LENGTH; + glm::vec3 gapVector = segmentVector / SEGMENT_LENGTH * GAP_LENGTH; glm::vec3 point = start; glVertex3f(point.x, point.y, point.z);