mirror of
https://thingvellir.net/git/overte
synced 2025-03-27 23:52:03 +01:00
fe171af31b
Fixes situations where attempting to click on a rotate, grab,
or scale handle that was in front of others might unexpectedly
activate the obscured handle.
As of this commit the flow of mousePressEvent such that the
first item whether it be a tool or selection is what reacts
and absorbs the click/touch. This is counter to the prior
behavior where whichever item or tool last passed the check
would determine what was hit and handled the touch _even_
when it wasn't the first thing to be touched.
* Got rid of some unused/stale vars
* Added some convenience functions
* setRotationHandlesVisible function
* setStretchHandlesVisible function
* setGrabberMoveUpVisible function
* Removed checkIntersectWith helper functions as they're
no longer used.
* Normalized onBegin signatures for all GrabberTools to
support the new flow within mousePressEvent.
* These are tools registered via addGrabberTool/makeStretchTool.
* The onBegin signature changes from onBegin( event ) to
onBegin( event, intersectResult ).
* This allows for a simpler tool triggering where tools which
utilized the additional information provided will have it,
those which may need it the future shall have it with little
issue, and those that don't care may ignore it.
NOTE(s):
* Tested normal movement within opening creation menu: Passed
* With Creation Menu Open:
* Tested clicking around the world in empty space: Passed
* Tested single selection: Passed
* Tested single selection rotation (pitch, yaw, roll): Passed
* Tested single selection translation (xz, y): Passed
* Tested multiple selection: Passed
* Tested multiple selection rotation (pitch, yaw, roll): Passed
* Tested multiple selection translation (xz, y): Passed
Reviewed-by: Leander Hasty <leander@1stplayable.com>
Changes Committed:
modified: scripts/system/libraries/entitySelectionTool.js
|
||
|---|---|---|
| .. | ||
| assets | ||
| commerce | ||
| controllers | ||
| html | ||
| libraries | ||
| marketplaces | ||
| particle_explorer | ||
| tablet-ui | ||
| attachedEntitiesManager.js | ||
| audio.js | ||
| audioMuteOverlay.js | ||
| audioScope.js | ||
| avatarFinderBeacon.js | ||
| away.js | ||
| bubble.js | ||
| chat.js | ||
| dialTone.js | ||
| directory.js | ||
| edit.js | ||
| fingerPaint.js | ||
| firstPersonHMD.js | ||
| generalSettings.js | ||
| goto.js | ||
| help.js | ||
| hmd.js | ||
| makeUserConnection.js | ||
| menu.js | ||
| mod.js | ||
| nameTag.js | ||
| notifications.js | ||
| pal.js | ||
| progress.js | ||
| snapshot.js | ||
| tablet-goto.js | ||
| tablet-users.js | ||
| voxels.js | ||