Mirrors/overte-thingvellir
3
0
Fork 0
mirror of https://thingvellir.net/git/overte synced 2025-03-27 23:52:03 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

simplify waitTillDoneRunning

Browse source
This commit is contained in:
ZappoMan 2015-02-24 17:45:22 -08:00
parent 310654831c
commit f1017f8a5d
1 changed files with 6 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
libraries/script-engine/src/ScriptEngine.cpp
View file

@ -176,23 +176,14 @@ void ScriptEngine::waitTillDoneRunning() {
_doneRunningThisScript = false; // NOTE: this is static, we serialize our waiting for scripts to finish
// What can we do here???
// we will be calling this on the main Application thread, inside of stopAllScripts()
// we want the application thread to continue to process events, because the script will
// likely need to marshall messages across to the main thread.
while (!_doneRunningThisScript && _isRunning) {
// NOTE: waitTillDoneRunning() will be called on the main Application thread, inside of stopAllScripts()
// we want the application thread to continue to process events, because the scripts will likely need to
// marshall messages across to the main thread. For example if they access Settings or Meny in any of their
// shutdown code.
while (!_doneRunningThisScript) {
// and run a QEventLoop???
QEventLoop loop;
QObject::connect(this, &ScriptEngine::doneRunning, &loop, &QEventLoop::quit);
loop.exec();
// process events
// process events for the main application thread, allowing invokeMethod calls to pass between threads
QCoreApplication::processEvents();
if (_doneRunningThisScript) {
break;
}
}
}
}