From cb2fd206b3d3593a7784175751ede4c5c6c7cebe Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Julian=20Gro=C3=9F?= Date: Sun, 17 Oct 2021 15:13:16 +0200 Subject: [PATCH] Add notes to why we use macOS SDK 10.12 --- .github/workflows/master_build.yml | 2 ++ .github/workflows/pr_build.yml | 2 ++ 2 files changed, 4 insertions(+) diff --git a/.github/workflows/master_build.yml b/.github/workflows/master_build.yml index 2a29624179..e4c8cc528e 100644 --- a/.github/workflows/master_build.yml +++ b/.github/workflows/master_build.yml @@ -20,6 +20,8 @@ env: # OSX-specific variables DEVELOPER_DIR: /Applications/Xcode_11.2.app/Contents/Developer + # We are using macOS SDK 10.12 to work around a lot of OpenGL issues in newer SDKs. + # There is crashes on startup, crashes on window resize, etc. on newer macOS SDKs. MACOSX_DEPLOYMENT_TARGET: '10.12' # WIN-specific variables diff --git a/.github/workflows/pr_build.yml b/.github/workflows/pr_build.yml index d3c1054a7a..fb4d854176 100644 --- a/.github/workflows/pr_build.yml +++ b/.github/workflows/pr_build.yml @@ -20,6 +20,8 @@ env: # OSX specific variables DEVELOPER_DIR: /Applications/Xcode_11.2.app/Contents/Developer + # We are using macOS SDK 10.12 to work around a lot of OpenGL issues in newer SDKs. + # There is crashes on startup, crashes on window resize, etc. on newer macOS SDKs. MACOSX_DEPLOYMENT_TARGET: '10.12' # WIN32 specific variables