diff --git a/assignment-client/src/avatars/ScriptableAvatar.cpp b/assignment-client/src/avatars/ScriptableAvatar.cpp index 9fcd71cf05..25860863cf 100644 --- a/assignment-client/src/avatars/ScriptableAvatar.cpp +++ b/assignment-client/src/avatars/ScriptableAvatar.cpp @@ -279,7 +279,7 @@ void ScriptableAvatar::setJointMappingsFromNetworkReply() { networkReply->deleteLater(); } -AvatarEntityMap ScriptableAvatar::getAvatarEntityData() const { +AvatarEntityMap ScriptableAvatar::getAvatarEntityDataNonDefault() const { // DANGER: Now that we store the AvatarEntityData in packed format this call is potentially Very Expensive! // Avoid calling this method if possible. AvatarEntityMap data; diff --git a/assignment-client/src/avatars/ScriptableAvatar.h b/assignment-client/src/avatars/ScriptableAvatar.h index 47f61a2b64..c08b7e2336 100644 --- a/assignment-client/src/avatars/ScriptableAvatar.h +++ b/assignment-client/src/avatars/ScriptableAvatar.h @@ -178,7 +178,8 @@ public: * var avatarEntityData = Avatar.getAvatarEntityData(); * print("Avatar entities: " + JSON.stringify(avatarEntityData)); */ - Q_INVOKABLE AvatarEntityMap getAvatarEntityData() const override; + + AvatarEntityMap getAvatarEntityDataNonDefault() const override; /**jsdoc * Sets all avatar entities from an object. diff --git a/interface/src/AvatarBookmarks.cpp b/interface/src/AvatarBookmarks.cpp index 6f6a93ff19..8f666ddbfa 100644 --- a/interface/src/AvatarBookmarks.cpp +++ b/interface/src/AvatarBookmarks.cpp @@ -154,7 +154,7 @@ void AvatarBookmarks::deleteBookmark() { void AvatarBookmarks::updateAvatarEntities(const QVariantList &avatarEntities) { auto myAvatar = DependencyManager::get()->getMyAvatar(); - auto currentAvatarEntities = myAvatar->getAvatarEntityData(); + auto currentAvatarEntities = myAvatar->getAvatarEntityDataNonDefault(); std::set newAvatarEntities; // Update or add all the new avatar entities @@ -296,7 +296,7 @@ QVariantMap AvatarBookmarks::getAvatarDataToBookmark() { if (entityTree) { QScriptEngine scriptEngine; - auto avatarEntities = myAvatar->getAvatarEntityData(); + auto avatarEntities = myAvatar->getAvatarEntityDataNonDefault(); for (auto entityID : avatarEntities.keys()) { auto entity = entityTree->findEntityByID(entityID); if (!entity || !isWearableEntity(entity)) { diff --git a/interface/src/avatar/MyAvatar.cpp b/interface/src/avatar/MyAvatar.cpp index c3e4758e50..4287062094 100644 --- a/interface/src/avatar/MyAvatar.cpp +++ b/interface/src/avatar/MyAvatar.cpp @@ -1810,7 +1810,7 @@ void MyAvatar::prepareAvatarEntityDataForReload() { _reloadAvatarEntityDataFromSettings = true; } -AvatarEntityMap MyAvatar::getAvatarEntityData() const { +AvatarEntityMap MyAvatar::getAvatarEntityDataNonDefault() const { // NOTE: the return value is expected to be a map of unfortunately-formatted-binary-blobs updateStaleAvatarEntityBlobs(); AvatarEntityMap result; diff --git a/interface/src/avatar/MyAvatar.h b/interface/src/avatar/MyAvatar.h index cc12e4fcee..2e87f5ef94 100644 --- a/interface/src/avatar/MyAvatar.h +++ b/interface/src/avatar/MyAvatar.h @@ -1861,7 +1861,8 @@ public: * var avatarEntityData = MyAvatar.getAvatarEntityData(); * print("Avatar entities: " + JSON.stringify(avatarEntityData)); */ - AvatarEntityMap getAvatarEntityData() const override; + + AvatarEntityMap getAvatarEntityDataNonDefault() const override; /**jsdoc * Sets all avatar entities from an object. diff --git a/libraries/avatars/src/AvatarData.cpp b/libraries/avatars/src/AvatarData.cpp index e670a5437a..0b7ea76f3f 100755 --- a/libraries/avatars/src/AvatarData.cpp +++ b/libraries/avatars/src/AvatarData.cpp @@ -3046,7 +3046,7 @@ void AvatarData::clearAvatarEntity(const QUuid& entityID, bool requiresRemovalFr } } -AvatarEntityMap AvatarData::getAvatarEntityData() const { +AvatarEntityMap AvatarData::getAvatarEntityDataNonDefault() const { // overridden where needed // NOTE: the return value is expected to be a map of unfortunately-formatted-binary-blobs return AvatarEntityMap(); diff --git a/libraries/avatars/src/AvatarData.h b/libraries/avatars/src/AvatarData.h index fd15273e15..5b4e959d03 100755 --- a/libraries/avatars/src/AvatarData.h +++ b/libraries/avatars/src/AvatarData.h @@ -1390,7 +1390,9 @@ public: /**jsdoc * @comment Documented in derived classes' JSDoc because implementations are different. */ - Q_INVOKABLE virtual AvatarEntityMap getAvatarEntityData() const; + + // Get avatar entity data with non-default property values. Used internally. + virtual AvatarEntityMap getAvatarEntityDataNonDefault() const; /**jsdoc * @comment Documented in derived classes' JSDoc because implementations are different. diff --git a/libraries/avatars/src/ScriptAvatarData.cpp b/libraries/avatars/src/ScriptAvatarData.cpp index 18717c8ca3..a67af18c40 100644 --- a/libraries/avatars/src/ScriptAvatarData.cpp +++ b/libraries/avatars/src/ScriptAvatarData.cpp @@ -278,7 +278,7 @@ AvatarEntityMap ScriptAvatarData::getAvatarEntities() const { AvatarEntityMap scriptEntityData; if (AvatarSharedPointer sharedAvatarData = _avatarData.lock()) { - return sharedAvatarData->getAvatarEntityData(); + return sharedAvatarData->getAvatarEntityDataNonDefault(); } return scriptEntityData;