From 65dcd583718c055ef08ad622fa053295c62978bf Mon Sep 17 00:00:00 2001 From: Penguin-Guru Date: Wed, 24 Nov 2021 08:51:43 -0800 Subject: [PATCH] This seems fine? --- interface/resources/qml/hifi/audio/PlaySampleSound.qml | 4 +--- .../qml/hifi/simplifiedUI/settingsApp/audio/Audio.qml | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/interface/resources/qml/hifi/audio/PlaySampleSound.qml b/interface/resources/qml/hifi/audio/PlaySampleSound.qml index f1351b8cbf..847f876140 100644 --- a/interface/resources/qml/hifi/audio/PlaySampleSound.qml +++ b/interface/resources/qml/hifi/audio/PlaySampleSound.qml @@ -25,10 +25,8 @@ RowLayout { sample = null; } function playSound() { - // FIXME: MyAvatar is not properly exposed to QML; MyAvatar.qmlPosition is a stopgap - // FIXME: AudioScriptingInterface.playSystemSound should not require position if (sample === null && !isPlaying) { - sample = AudioScriptingInterface.playSystemSound(sound, MyAvatar.qmlPosition); + sample = AudioScriptingInterface.playSystemSound(sound); isPlaying = true; sample.finished.connect(reset); } diff --git a/interface/resources/qml/hifi/simplifiedUI/settingsApp/audio/Audio.qml b/interface/resources/qml/hifi/simplifiedUI/settingsApp/audio/Audio.qml index 345c124725..ea2b1467b5 100644 --- a/interface/resources/qml/hifi/simplifiedUI/settingsApp/audio/Audio.qml +++ b/interface/resources/qml/hifi/simplifiedUI/settingsApp/audio/Audio.qml @@ -384,10 +384,8 @@ Flickable { sample = null; } function playSound() { - // FIXME: MyAvatar is not properly exposed to QML; MyAvatar.qmlPosition is a stopgap - // FIXME: AudioScriptingInterface.playSystemSound should not require position if (sample === null && !isPlaying) { - sample = AudioScriptingInterface.playSystemSound(sound, MyAvatar.qmlPosition); + sample = AudioScriptingInterface.playSystemSound(sound); isPlaying = true; sample.finished.connect(reset); }